From 871559cb6a27abdb1d042405db926ddd9bea347d Mon Sep 17 00:00:00 2001
From: henryruhs <info@henryruhs.com>
Date: Fri, 29 May 2026 15:44:07 +0200
Subject: [PATCH] clean and simplify tests

---
 tests/test_api_stream.py    |  9 +--------
 tests/test_rtc.py           |  3 +++
 tests/test_stream_helper.py | 13 ++++++-------
 3 files changed, 10 insertions(+), 15 deletions(-)

diff --git a/tests/test_api_stream.py b/tests/test_api_stream.py
index e0b0af80..9420dbf2 100644
--- a/tests/test_api_stream.py
+++ b/tests/test_api_stream.py
@@ -119,6 +119,7 @@ def test_stream_video(test_client : TestClient, video_codec : VideoCodec) -> Non
 
 	if video_codec == 'av1':
 		rtc.add_video_track(peer_connection, 'sendrecv', video_codec, 35)
+
 	if video_codec == 'vp8':
 		rtc.add_video_track(peer_connection, 'sendrecv', video_codec, 96)
 
@@ -136,14 +137,6 @@ def test_stream_video(test_client : TestClient, video_codec : VideoCodec) -> Non
 		assert stream_response.status_code == 201
 		assert 'm=video' in stream_response.text
 
-		session_id = session_manager.find_session_id(access_token)
-
-		for peer in rtc_store.get_peers(session_id):
-			bitrate = peer.get('bitrate')
-			assert bitrate.value == 0
-			rtc.handle_remb(0, 6000000, ctypes.addressof(bitrate))
-			assert bitrate.value == 6000
-
 
 def test_delete_stream_video(test_client : TestClient) -> None:
 	create_session_response = test_client.post('/session', json =
diff --git a/tests/test_rtc.py b/tests/test_rtc.py
index d4d9e9bc..b16742ca 100644
--- a/tests/test_rtc.py
+++ b/tests/test_rtc.py
@@ -154,6 +154,9 @@ def test_wire_remb(video_codec : VideoCodec, payload_type : int) -> None:
 	}
 
 	wire_remb(video_sender_track, rtc_peer.get('bitrate'))
+
+	assert rtc_peer.get('bitrate').value == 0
+
 	handle_remb(0, 6000000, ctypes.addressof(rtc_peer.get('bitrate')))
 
 	assert rtc_peer.get('bitrate').value == 6000
diff --git a/tests/test_stream_helper.py b/tests/test_stream_helper.py
index fb9fe302..31ab4ce9 100644
--- a/tests/test_stream_helper.py
+++ b/tests/test_stream_helper.py
@@ -101,22 +101,21 @@ def test_create_and_destroy_video_encoder(video_codec : VideoCodec) -> None:
 	resolution = (vision_frame.shape[1], vision_frame.shape[0])
 	frame_buffer = cv2.cvtColor(vision_frame, cv2.COLOR_BGR2YUV_I420).tobytes()
 
-	encoder = create_video_encoder(video_codec, resolution, 4000)
-	assert encoder is not None
+	video_encoder = create_video_encoder(video_codec, resolution, 4000)
 
 	if video_codec == 'av1':
-		assert aom_encoder.encode(encoder, frame_buffer, resolution, 0)
+		assert aom_encoder.encode(video_encoder, frame_buffer, resolution, 0)
 
 	if video_codec == 'vp8':
-		assert vpx_encoder.encode(encoder, frame_buffer, resolution, 0)
+		assert vpx_encoder.encode(video_encoder, frame_buffer, resolution, 0)
 
-	destroy_video_encoder(video_codec, encoder)
+	destroy_video_encoder(video_codec, video_encoder)
 
 	if video_codec == 'av1':
-		assert not aom_encoder.encode(encoder, frame_buffer, resolution, 1)
+		assert not aom_encoder.encode(video_encoder, frame_buffer, resolution, 1)
 
 	if video_codec == 'vp8':
-		assert not vpx_encoder.encode(encoder, frame_buffer, resolution, 1)
+		assert not vpx_encoder.encode(video_encoder, frame_buffer, resolution, 1)
 
 
 # TODO: refine test