Refactor RTC structure (#1113)

* refactor rtc part1

* skip for macos

* merge create spd and create sdp offer

* fix lint

* add test for create_sdp_offer

* better naming for negotiate method as we get an answer

* extend tests based on mutations

* remove dead code

* rename rtc store and related methods

* clean store, move sender logic to stream helper under apis

* generate tests for rtc store
This commit is contained in:
Henry Ruhs
2026-05-15 11:46:51 +02:00
committed by GitHub
parent 3def6c8fcd
commit 98adce8a2b
8 changed files with 281 additions and 224 deletions
+50 -7
View File
@@ -1,7 +1,10 @@
from typing import List
import pytest
from facefusion import state_manager
from facefusion import rtc, rtc_store, state_manager
from facefusion.libraries import datachannel as datachannel_module, opus as opus_module, vpx as vpx_module
from facefusion.types import RtcPeer
@pytest.fixture(scope = 'module', autouse = True)
@@ -13,11 +16,51 @@ def before_all() -> None:
vpx_module.pre_check()
# TODO: test create_rtc_stream, get_rtc_stream, destroy_rtc_stream lifecycle
def test_rtc_stream_lifecycle() -> None:
pass
@pytest.fixture(autouse = True)
def before_each() -> None:
rtc_store.RTC_STORE.clear()
# TODO: test add_rtc_viewer with valid session and sdp offer
def test_add_rtc_viewer() -> None:
pass
# TODO: needs review
def test_create_rtc_peers() -> None:
rtc_store.create_rtc_peers('test-session')
assert rtc_store.RTC_STORE.get('test-session') == []
# TODO: needs review
def test_get_rtc_peers() -> None:
assert rtc_store.get_rtc_peers('test-session') is None
rtc_store.create_rtc_peers('test-session')
assert rtc_store.get_rtc_peers('test-session') == []
# TODO: needs review
def test_destroy_rtc_peers() -> None:
rtc_store.create_rtc_peers('test-session')
rtc_store.destroy_rtc_peers('test-session')
assert rtc_store.get_rtc_peers('test-session') is None
# TODO: needs review
def test_destroy_rtc_peers_with_connections() -> None:
datachannel_library = datachannel_module.create_static_library()
peer_connection = rtc.create_peer_connection()
rtc_store.create_rtc_peers('test-session')
rtc_peers : List[RtcPeer] =\
[
{
'peer_connection': peer_connection,
'video_track': 0,
'audio_track': 0
}
]
rtc_store.RTC_STORE['test-session'] = rtc_peers
rtc_store.destroy_rtc_peers('test-session')
assert rtc_store.get_rtc_peers('test-session') is None
assert datachannel_library.rtcDeletePeerConnection(peer_connection) < 0