From a1e9a4180b31cfd34b1ab3eb148b8bb026646338 Mon Sep 17 00:00:00 2001 From: Henry Ruhs Date: Thu, 23 Jul 2026 11:16:49 +0200 Subject: [PATCH] drop keep_temp and the common options component (#1180) Claude-Session: https://claude.ai/code/session_01Tbcd6VWCiU4BQP1gywPr2a Co-authored-by: Claude Opus 4.8 --- facefusion.ini | 1 - facefusion/args.py | 1 - facefusion/locales.py | 2 -- facefusion/program.py | 3 +- facefusion/temp_helper.py | 6 ++-- facefusion/types.py | 2 -- facefusion/uis/choices.py | 2 -- facefusion/uis/components/common_options.py | 32 --------------------- facefusion/uis/layouts/default.py | 5 +--- 9 files changed, 4 insertions(+), 50 deletions(-) delete mode 100644 facefusion/uis/components/common_options.py diff --git a/facefusion.ini b/facefusion.ini index 4d8a73e0..3223a30d 100644 --- a/facefusion.ini +++ b/facefusion.ini @@ -51,7 +51,6 @@ voice_extractor_model = trim_frame_start = trim_frame_end = temp_frame_format = -keep_temp = [frame_distribution] target_frame_amount = diff --git a/facefusion/args.py b/facefusion/args.py index 06adfc57..e3a65765 100644 --- a/facefusion/args.py +++ b/facefusion/args.py @@ -45,7 +45,6 @@ def apply_args(args : Args, apply_state_item : ApplyStateItem) -> None: apply_state_item('trim_frame_start', args.get('trim_frame_start')) apply_state_item('trim_frame_end', args.get('trim_frame_end')) apply_state_item('temp_frame_format', args.get('temp_frame_format')) - apply_state_item('keep_temp', args.get('keep_temp')) apply_state_item('target_frame_amount', args.get('target_frame_amount')) apply_state_item('output_image_quality', args.get('output_image_quality')) apply_state_item('output_image_scale', args.get('output_image_scale')) diff --git a/facefusion/locales.py b/facefusion/locales.py index a8b31b60..35c38b95 100644 --- a/facefusion/locales.py +++ b/facefusion/locales.py @@ -135,7 +135,6 @@ LOCALES : Locales =\ 'trim_frame_start': 'specify the starting frame of the target video', 'trim_frame_end': 'specify the ending frame of the target video', 'temp_frame_format': 'specify the temporary resources format', - 'keep_temp': 'keep the temporary resources after processing', 'target_frame_amount': 'specify the amount of target frames forwarded to the processor', 'output_image_quality': 'specify the image quality which translates to the image compression', 'output_image_scale': 'specify the image scale based on the target image', @@ -200,7 +199,6 @@ LOCALES : Locales =\ 'benchmark_cycle_count_slider': 'BENCHMARK CYCLE COUNT', 'benchmark_resolutions_checkbox_group': 'BENCHMARK RESOLUTIONS', 'clear_button': 'CLEAR', - 'common_options_checkbox_group': 'OPTIONS', 'download_providers_checkbox_group': 'DOWNLOAD PROVIDERS', 'execution_providers_checkbox_group': 'EXECUTION PROVIDERS', 'execution_thread_count_slider': 'EXECUTION THREAD COUNT', diff --git a/facefusion/program.py b/facefusion/program.py index ae2d9667..c59a9efc 100755 --- a/facefusion/program.py +++ b/facefusion/program.py @@ -169,8 +169,7 @@ def create_frame_extraction_program() -> ArgumentParser: group_frame_extraction.add_argument('--trim-frame-start', help = translator.get('help.trim_frame_start'), type = int, default = facefusion.config.get_int_value('frame_extraction', 'trim_frame_start')) group_frame_extraction.add_argument('--trim-frame-end', help = translator.get('help.trim_frame_end'), type = int, default = facefusion.config.get_int_value('frame_extraction', 'trim_frame_end')) group_frame_extraction.add_argument('--temp-frame-format', help = translator.get('help.temp_frame_format'), default = config.get_str_value('frame_extraction', 'temp_frame_format', 'png'), choices = facefusion.choices.temp_frame_formats) - group_frame_extraction.add_argument('--keep-temp', help = translator.get('help.keep_temp'), action = 'store_true', default = config.get_bool_value('frame_extraction', 'keep_temp')) - job_store.register_step_keys([ 'trim_frame_start', 'trim_frame_end', 'temp_frame_format', 'keep_temp' ]) + job_store.register_step_keys([ 'trim_frame_start', 'trim_frame_end', 'temp_frame_format' ]) return program diff --git a/facefusion/temp_helper.py b/facefusion/temp_helper.py index 33d69a94..990ed864 100644 --- a/facefusion/temp_helper.py +++ b/facefusion/temp_helper.py @@ -43,7 +43,5 @@ def create_temp_directory(file_path : str) -> bool: def clear_temp_directory(file_path : str) -> bool: - if not state_manager.get_item('keep_temp'): - temp_directory_path = get_temp_directory_path(file_path) - return remove_directory(temp_directory_path) - return True + temp_directory_path = get_temp_directory_path(file_path) + return remove_directory(temp_directory_path) diff --git a/facefusion/types.py b/facefusion/types.py index 1b1a1a81..75a58752 100755 --- a/facefusion/types.py +++ b/facefusion/types.py @@ -313,7 +313,6 @@ StateKey = Literal\ 'trim_frame_start', 'trim_frame_end', 'temp_frame_format', - 'keep_temp', 'target_frame_amount', 'output_image_quality', 'output_image_scale', @@ -384,7 +383,6 @@ State = TypedDict('State', 'trim_frame_start' : int, 'trim_frame_end' : int, 'temp_frame_format' : TempFrameFormat, - 'keep_temp' : bool, 'target_frame_amount' : int, 'output_image_quality' : int, 'output_image_scale' : Scale, diff --git a/facefusion/uis/choices.py b/facefusion/uis/choices.py index 15349bae..e7bea390 100644 --- a/facefusion/uis/choices.py +++ b/facefusion/uis/choices.py @@ -6,8 +6,6 @@ from facefusion.uis.types import JobManagerAction, JobRunnerAction, PreviewMode job_manager_actions : List[JobManagerAction] = [ 'job-create', 'job-submit', 'job-delete', 'job-add-step', 'job-remix-step', 'job-insert-step', 'job-remove-step' ] job_runner_actions : List[JobRunnerAction] = [ 'job-run', 'job-run-all', 'job-retry', 'job-retry-all' ] -common_options : List[str] = [ 'keep-temp' ] - preview_modes : List[PreviewMode] = [ 'default', 'frame-by-frame', 'face-by-face' ] preview_resolutions : List[str] = [ '512x512', '768x768', '1024x1024' ] diff --git a/facefusion/uis/components/common_options.py b/facefusion/uis/components/common_options.py deleted file mode 100644 index b4352fd3..00000000 --- a/facefusion/uis/components/common_options.py +++ /dev/null @@ -1,32 +0,0 @@ -from typing import List, Optional - -import gradio - -from facefusion import state_manager, translator -from facefusion.uis import choices as uis_choices - -COMMON_OPTIONS_CHECKBOX_GROUP : Optional[gradio.Checkboxgroup] = None - - -def render() -> None: - global COMMON_OPTIONS_CHECKBOX_GROUP - - common_options = [] - - if state_manager.get_item('keep_temp'): - common_options.append('keep-temp') - - COMMON_OPTIONS_CHECKBOX_GROUP = gradio.Checkboxgroup( - label = translator.get('uis.common_options_checkbox_group'), - choices = uis_choices.common_options, - value = common_options - ) - - -def listen() -> None: - COMMON_OPTIONS_CHECKBOX_GROUP.change(update, inputs = COMMON_OPTIONS_CHECKBOX_GROUP) - - -def update(common_options : List[str]) -> None: - keep_temp = 'keep-temp' in common_options - state_manager.set_item('keep_temp', keep_temp) diff --git a/facefusion/uis/layouts/default.py b/facefusion/uis/layouts/default.py index cf0aeace..3d60d1fd 100755 --- a/facefusion/uis/layouts/default.py +++ b/facefusion/uis/layouts/default.py @@ -1,7 +1,7 @@ import gradio from facefusion import state_manager -from facefusion.uis.components import about, age_modifier_options, background_remover_options, common_options, deep_swapper_options, download, execution, execution_thread_count, expression_restorer_options, face_debugger_options, face_detector, face_editor_options, face_enhancer_options, face_landmarker, face_masker, face_selector, face_swapper_options, face_tracker, frame_colorizer_options, frame_enhancer_options, instant_runner, job_manager, job_runner, lip_syncer_options, memory, output, output_options, preview, preview_options, processors, source, target, temp_frame, terminal, trim_frame, ui_workflow, voice_extractor +from facefusion.uis.components import about, age_modifier_options, background_remover_options, deep_swapper_options, download, execution, execution_thread_count, expression_restorer_options, face_debugger_options, face_detector, face_editor_options, face_enhancer_options, face_landmarker, face_masker, face_selector, face_swapper_options, face_tracker, frame_colorizer_options, frame_enhancer_options, instant_runner, job_manager, job_runner, lip_syncer_options, memory, output, output_options, preview, preview_options, processors, source, target, temp_frame, terminal, trim_frame, ui_workflow, voice_extractor def pre_check() -> bool: @@ -81,8 +81,6 @@ def render() -> gradio.Blocks: face_detector.render() with gradio.Blocks(): face_landmarker.render() - with gradio.Blocks(): - common_options.render() return layout @@ -121,7 +119,6 @@ def listen() -> None: face_detector.listen() face_landmarker.listen() voice_extractor.listen() - common_options.listen() def run(ui : gradio.Blocks) -> None: