restrict hdr color transfer and tag the merge output as bt709 (#1188)

* restrict hdr color transfer and tag the merge output as bt709

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tbcd6VWCiU4BQP1gywPr2a

* restrict hdr color transfer and tag the merge output as bt709

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tbcd6VWCiU4BQP1gywPr2a

* full video migration

* compose the hdr fixture via the builder chain

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tbcd6VWCiU4BQP1gywPr2a

* compose the test fixtures via the builder and run_ffmpeg

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tbcd6VWCiU4BQP1gywPr2a

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Henry Ruhs
2026-07-23 14:38:22 +02:00
committed by GitHub
parent 4d92e8b5b7
commit a515d7fc3f
7 changed files with 123 additions and 38 deletions
+78 -30
View File
@@ -1,16 +1,17 @@
import os
import subprocess
import tempfile
import pytest
import facefusion.ffmpeg
from facefusion import process_manager, state_manager
from facefusion import ffmpeg, ffmpeg_builder, process_manager, state_manager
from facefusion.download import conditional_download
from facefusion.ffmpeg import concat_video, extract_frames, merge_video, read_audio_buffer, replace_audio, restore_audio
from facefusion.ffprobe import extract_video_metadata
from facefusion.filesystem import copy_file
from facefusion.temp_helper import clear_temp_directory, create_temp_directory, get_temp_file_path, resolve_temp_frame_set
from facefusion.types import EncoderSet
from facefusion.vision import read_image
from .helper import get_test_example_file, get_test_examples_directory, get_test_output_file, prepare_test_output_directory
@@ -23,15 +24,52 @@ def before_all() -> None:
'https://github.com/facefusion/facefusion-assets/releases/download/examples-3.0.0/source.mp3',
'https://github.com/facefusion/facefusion-assets/releases/download/examples-3.0.0/target-240p.mp4'
])
subprocess.run([ 'ffmpeg', '-i', get_test_example_file('source.mp3'), get_test_example_file('source.wav') ])
subprocess.run([ 'ffmpeg', '-i', get_test_example_file('target-240p.mp4'), '-vf', 'fps=25', get_test_example_file('target-240p-25fps.mp4') ])
subprocess.run([ 'ffmpeg', '-i', get_test_example_file('target-240p.mp4'), '-vf', 'fps=30', get_test_example_file('target-240p-30fps.mp4') ])
subprocess.run([ 'ffmpeg', '-i', get_test_example_file('target-240p.mp4'), '-vf', 'fps=60', get_test_example_file('target-240p-60fps.mp4') ])
ffmpeg.run_ffmpeg(
ffmpeg_builder.chain(
ffmpeg_builder.set_input(get_test_example_file('source.mp3')),
ffmpeg_builder.set_output(get_test_example_file('source.wav'))
)
)
for video_fps in [ 25, 30, 60 ]:
ffmpeg.run_ffmpeg(
ffmpeg_builder.chain(
ffmpeg_builder.set_input(get_test_example_file('target-240p.mp4')),
ffmpeg_builder.set_video_fps(video_fps),
ffmpeg_builder.set_output(get_test_example_file('target-240p-' + str(video_fps) + 'fps.mp4'))
)
)
ffmpeg.run_ffmpeg(
ffmpeg_builder.chain(
ffmpeg_builder.set_input(get_test_example_file('target-240p.mp4')),
[
'-vf',
'scale=out_transfer=smpte2084'
],
ffmpeg_builder.set_output(get_test_example_file('target-240p-smpte2084.mp4'))
)
)
for output_video_format in [ 'avi', 'm4v', 'mkv', 'mov', 'mp4', 'webm', 'wmv' ]:
subprocess.run([ 'ffmpeg', '-i', get_test_example_file('source.mp3'), '-i', get_test_example_file('target-240p.mp4'), '-ar', '16000', get_test_example_file('target-240p-16khz.' + output_video_format) ])
ffmpeg.run_ffmpeg(
ffmpeg_builder.chain(
ffmpeg_builder.set_input(get_test_example_file('source.mp3')),
ffmpeg_builder.set_input(get_test_example_file('target-240p.mp4')),
ffmpeg_builder.set_audio_sample_rate(16000),
ffmpeg_builder.set_output(get_test_example_file('target-240p-16khz.' + output_video_format))
)
)
ffmpeg.run_ffmpeg(
ffmpeg_builder.chain(
ffmpeg_builder.set_input(get_test_example_file('source.mp3')),
ffmpeg_builder.set_input(get_test_example_file('target-240p.mp4')),
ffmpeg_builder.set_audio_sample_rate(48000),
ffmpeg_builder.set_output(get_test_example_file('target-240p-48khz.mp4'))
)
)
subprocess.run([ 'ffmpeg', '-i', get_test_example_file('source.mp3'), '-i', get_test_example_file('target-240p.mp4'), '-ar', '48000', get_test_example_file('target-240p-48khz.mp4') ])
state_manager.init_item('temp_path', tempfile.gettempdir())
state_manager.init_item('temp_frame_format', 'png')
state_manager.init_item('output_audio_encoder', 'aac')
@@ -67,43 +105,49 @@ def test_get_available_encoder_set() -> None:
def test_extract_frames() -> None:
test_set =\
[
(get_test_example_file('target-240p-25fps.mp4'), 0, 270, 324),
(get_test_example_file('target-240p-25fps.mp4'), 224, 270, 55),
(get_test_example_file('target-240p-25fps.mp4'), 124, 224, 120),
(get_test_example_file('target-240p-25fps.mp4'), 0, 100, 120),
(get_test_example_file('target-240p-30fps.mp4'), 0, 324, 324),
(get_test_example_file('target-240p-30fps.mp4'), 224, 324, 100),
(get_test_example_file('target-240p-30fps.mp4'), 124, 224, 100),
(get_test_example_file('target-240p-30fps.mp4'), 0, 100, 100),
(get_test_example_file('target-240p-60fps.mp4'), 0, 648, 324),
(get_test_example_file('target-240p-60fps.mp4'), 224, 648, 212),
(get_test_example_file('target-240p-60fps.mp4'), 124, 224, 50),
(get_test_example_file('target-240p-60fps.mp4'), 0, 100, 50)
(get_test_example_file('target-240p-25fps.mp4'), 0, 270, 324, 55, 250),
(get_test_example_file('target-240p-25fps.mp4'), 224, 270, 55, 55, 250),
(get_test_example_file('target-240p-25fps.mp4'), 124, 224, 120, 55, 250),
(get_test_example_file('target-240p-25fps.mp4'), 0, 100, 120, 55, 250),
(get_test_example_file('target-240p-30fps.mp4'), 0, 324, 324, 55, 250),
(get_test_example_file('target-240p-30fps.mp4'), 224, 324, 100, 55, 250),
(get_test_example_file('target-240p-30fps.mp4'), 124, 224, 100, 55, 250),
(get_test_example_file('target-240p-30fps.mp4'), 0, 100, 100, 55, 250),
(get_test_example_file('target-240p-60fps.mp4'), 0, 648, 324, 55, 250),
(get_test_example_file('target-240p-60fps.mp4'), 224, 648, 212, 55, 250),
(get_test_example_file('target-240p-60fps.mp4'), 124, 224, 50, 55, 250),
(get_test_example_file('target-240p-60fps.mp4'), 0, 100, 50, 55, 250),
(get_test_example_file('target-240p-smpte2084.mp4'), 0, 1, 1, 32, 190)
]
for target_path, trim_frame_start, trim_frame_end, frame_total in test_set:
for target_path, trim_frame_start, trim_frame_end, frame_total, frame_std, frame_max in test_set:
create_temp_directory(target_path)
assert extract_frames(target_path, (452, 240), 30.0, trim_frame_start, trim_frame_end) is True
assert len(resolve_temp_frame_set(target_path)) == frame_total
temp_vision_frame = read_image(resolve_temp_frame_set(target_path).get(trim_frame_start))
assert temp_vision_frame.std() > frame_std
assert temp_vision_frame.max() > frame_max
clear_temp_directory(target_path)
def test_merge_video() -> None:
target_paths =\
test_set =\
[
get_test_example_file('target-240p-16khz.avi'),
get_test_example_file('target-240p-16khz.m4v'),
get_test_example_file('target-240p-16khz.mkv'),
get_test_example_file('target-240p-16khz.mp4'),
get_test_example_file('target-240p-16khz.mov'),
get_test_example_file('target-240p-16khz.webm'),
get_test_example_file('target-240p-16khz.wmv')
(get_test_example_file('target-240p-16khz.avi'), [ 'bt709', 'unknown' ]),
(get_test_example_file('target-240p-16khz.m4v'), [ 'bt709' ]),
(get_test_example_file('target-240p-16khz.mkv'), [ 'bt709' ]),
(get_test_example_file('target-240p-16khz.mp4'), [ 'bt709' ]),
(get_test_example_file('target-240p-16khz.mov'), [ 'bt709' ]),
(get_test_example_file('target-240p-16khz.webm'), [ 'bt709' ]),
(get_test_example_file('target-240p-16khz.wmv'), [ 'bt709' ])
]
output_video_encoders = get_available_encoder_set().get('video')
for target_path in target_paths:
for target_path, color_transfers in test_set:
for output_video_encoder in output_video_encoders:
state_manager.init_item('output_video_encoder', output_video_encoder)
create_temp_directory(target_path)
@@ -111,6 +155,10 @@ def test_merge_video() -> None:
assert merge_video(target_path, 25.0, (452, 240), 25.0, 0, 1) is True
video_metadata = extract_video_metadata(get_temp_file_path(target_path))
assert video_metadata.get('color_transfer') in color_transfers
clear_temp_directory(target_path)
state_manager.init_item('output_video_encoder', 'libx264')