CalvinBackup/facefusion
1
0
Fork 0
mirror of https://github.com/facefusion/facefusion.git synced 2026-08-10 19:10:21 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix SDP line endings and media description builder (#1085)

Browse Source 
* SDP \r\n fix + build_media_description

* improve tests and remove default arguments

* improve tests

* Refine RTC types and tests with loopback SDP validation

* cleanup
This commit is contained in:
Harisreedhar
2026-05-07 21:34:57 +05:30
committed by GitHub
parent 0ff16d4e7c
commit abed8e9ccc
6 changed files with 125 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/stream_helper.py
+4 -24
View File
@@ -1,5 +1,4 @@
import ctypes
import os
import threading
import time
from typing import Optional
@@ -7,33 +6,15 @@ from typing import Optional
from starlette.testclient import TestClient
from facefusion import rtc
from facefusion.types import RtcSdpOffer
from facefusion.types import SdpOffer
# TODO: reuse media description building from rtc.py
def create_sdp_offer() -> Optional[RtcSdpOffer]:
def create_sdp_offer() -> Optional[SdpOffer]:
rtc_library = rtc.create_static_rtc_library()
peer_connection = rtc.create_peer_connection(disable_auto_negotiation = True)
media_video = os.linesep.join(
[
'm=video 9 UDP/TLS/RTP/SAVPF 96',
'a=rtpmap:96 VP8/90000',
'a=recvonly',
'a=mid:0',
''
]).encode()
media_audio = os.linesep.join(
[
'm=audio 9 UDP/TLS/RTP/SAVPF 111',
'a=rtpmap:111 opus/48000/2',
'a=recvonly',
'a=mid:1',
''
]).encode()
rtc_library.rtcAddTrack(peer_connection, media_video)
rtc_library.rtcAddTrack(peer_connection, media_audio)
rtc_library.rtcAddTrack(peer_connection, rtc.build_media_description('video', 96, 'VP8/90000', 'recvonly', 0))
rtc_library.rtcAddTrack(peer_connection, rtc.build_media_description('audio', 111, 'opus/48000/2', 'recvonly', 1))
rtc_library.rtcSetLocalDescription(peer_connection, b'offer')
buffer_size = 16384
@@ -44,7 +25,6 @@ def create_sdp_offer() -> Optional[RtcSdpOffer]:
if rtc_library.rtcGetLocalDescription(peer_connection, buffer_string, buffer_size) > 0:
sdp = buffer_string.value.decode()
rtc_library.rtcDeletePeerConnection(peer_connection)
#TODO: use return buffer_string.value.decode()
return sdp
time.sleep(0.05)