From dbc4b8778e103a4a43e7c57d2f48ad63ff6eba08 Mon Sep 17 00:00:00 2001 From: Harisreedhar <46858047+harisreedhar@users.noreply.github.com> Date: Mon, 23 Mar 2026 21:50:48 +0530 Subject: [PATCH] fix false vram numbers (#1065) --- facefusion/system.py | 8 ++++---- facefusion/types.py | 2 +- tests/test_api_metrics.py | 6 ++++-- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/facefusion/system.py b/facefusion/system.py index 3966b928..8e62a544 100644 --- a/facefusion/system.py +++ b/facefusion/system.py @@ -60,9 +60,9 @@ def detect_nvidia_graphic_devices() -> List[GraphicDevice]: 'value': pynvml.nvmlDeviceGetMemoryInfo(handle).total // (1024 * 1024 * 1024), 'unit': 'GB' }, - 'free': + 'used': { - 'value': pynvml.nvmlDeviceGetMemoryInfo(handle).free // (1024 * 1024 * 1024), + 'value': pynvml.nvmlDeviceGetMemoryInfo(handle).used // (1024 * 1024 * 1024), 'unit': 'GB' } }, @@ -131,9 +131,9 @@ def detect_amd_graphic_devices() -> List[GraphicDevice]: 'value': vram_usage.get('vram_total', 0) // (1024 * 1024 * 1024), 'unit': 'GB' }, - 'free': + 'used': { - 'value': (vram_usage.get('vram_total', 0) - vram_usage.get('vram_used', 0)) // (1024 * 1024 * 1024), + 'value': vram_usage.get('vram_used', 0) // (1024 * 1024 * 1024), 'unit': 'GB' } }, diff --git a/facefusion/types.py b/facefusion/types.py index f9137325..a4b6c3e3 100755 --- a/facefusion/types.py +++ b/facefusion/types.py @@ -292,7 +292,7 @@ ExecutionDeviceProduct = TypedDict('ExecutionDeviceProduct', ExecutionDeviceVideoMemory = TypedDict('ExecutionDeviceVideoMemory', { 'total' : Optional[ValueAndUnit], - 'free' : Optional[ValueAndUnit] + 'used' : Optional[ValueAndUnit] }) ExecutionDeviceTemperature = TypedDict('ExecutionDeviceTemperature', { diff --git a/tests/test_api_metrics.py b/tests/test_api_metrics.py index c2b830fa..7f6600d7 100644 --- a/tests/test_api_metrics.py +++ b/tests/test_api_metrics.py @@ -112,9 +112,9 @@ def mock_detect_execution_devices(mocker : MockerFixture) -> None: 'value': 24, 'unit': 'GB' }, - 'free': + 'used': { - 'value': 20, + 'value': 4, 'unit': 'GB' } }, @@ -170,6 +170,7 @@ def test_get_metrics(test_client : TestClient) -> None: assert metrics_body.get('graphic_devices')[0].get('driver_version') == '555.42' assert metrics_body.get('graphic_devices')[0].get('product').get('name') == 'RTX 4090' assert metrics_body.get('graphic_devices')[0].get('video_memory').get('total').get('value') == 24 + assert metrics_body.get('graphic_devices')[0].get('video_memory').get('used').get('value') == 4 assert metrics_body.get('disks')[0].get('total').get('value') == 500 assert metrics_body.get('disks')[0].get('free').get('unit') == 'GB' @@ -204,6 +205,7 @@ def test_websocket_metrics(test_client : TestClient) -> None: assert metrics_set.get('graphic_devices')[0].get('driver_version') == '555.42' assert metrics_set.get('graphic_devices')[0].get('product').get('name') == 'RTX 4090' assert metrics_set.get('graphic_devices')[0].get('video_memory').get('total').get('value') == 24 + assert metrics_set.get('graphic_devices')[0].get('video_memory').get('used').get('value') == 4 assert metrics_set.get('disks')[0].get('total').get('value') == 500 assert metrics_set.get('disks')[0].get('free').get('unit') == 'GB'