Refactor/rtc cleanup 3 (#1118)

* tweak rtc store and make the decision to ban trivial testing

* clear todos for rtc_test, remove redundant tests

* clear todos for rtc_test, remove redundant tests

* break negotiation out of rtc flow, introduce create_sdp_answer and set_remote_description

* add todo

* move timeline control to the stream helper, clean send_audio|video_to_peers

* rename some methods

* fix test

* introduce detect_sdp_media

* introduce detect_sdp_media
This commit is contained in:
Henry Ruhs
2026-05-16 09:06:04 +02:00
committed by GitHub
parent 95435f842c
commit dd1ded1408
10 changed files with 157 additions and 219 deletions
-66
View File
@@ -1,66 +0,0 @@
from typing import List
import pytest
from facefusion import rtc, rtc_store, state_manager
from facefusion.libraries import datachannel as datachannel_module, opus as opus_module, vpx as vpx_module
from facefusion.types import RtcPeer
@pytest.fixture(scope = 'module', autouse = True)
def before_all() -> None:
state_manager.init_item('download_providers', [ 'github', 'huggingface' ])
datachannel_module.pre_check()
opus_module.pre_check()
vpx_module.pre_check()
@pytest.fixture(autouse = True)
def before_each() -> None:
rtc_store.RTC_STORE.clear()
# TODO: needs review
def test_create_rtc_peers() -> None:
rtc_store.create_rtc_peers('test-session')
assert rtc_store.RTC_STORE.get('test-session') == []
# TODO: needs review
def test_get_rtc_peers() -> None:
assert rtc_store.get_rtc_peers('test-session') is None
rtc_store.create_rtc_peers('test-session')
assert rtc_store.get_rtc_peers('test-session') == []
# TODO: needs review
def test_destroy_rtc_peers() -> None:
rtc_store.create_rtc_peers('test-session')
rtc_store.destroy_rtc_peers('test-session')
assert rtc_store.get_rtc_peers('test-session') is None
# TODO: needs review
def test_destroy_rtc_peers_with_connections() -> None:
datachannel_library = datachannel_module.create_static_library()
peer_connection = rtc.create_peer_connection()
rtc_store.create_rtc_peers('test-session')
rtc_peers : List[RtcPeer] =\
[
{
'peer_connection': peer_connection,
'video_track': 0,
'audio_track': 0
}
]
rtc_store.RTC_STORE['test-session'] = rtc_peers
rtc_store.destroy_rtc_peers('test-session')
assert rtc_store.get_rtc_peers('test-session') is None
assert datachannel_library.rtcDeletePeerConnection(peer_connection) < 0