mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-16 01:45:29 +02:00
Merge remote-tracking branch 'origin/main' into moscow-v4
# Conflicts: # .github/workflows/evals.yml # test/helpers/touchfiles-data.ts
This commit is contained in:
@@ -74,6 +74,37 @@ describe('directiveFor — per-session-kind instruction', () => {
|
||||
test('spawned directive auto-chooses', () => {
|
||||
expect(directiveFor('spawned')).toMatch(/auto-choose/i);
|
||||
});
|
||||
|
||||
test('spawned directive carries a self-contained destructive carve-out (#2733 review)', () => {
|
||||
// The "Spawned session block" it defers to exists only when a gstack
|
||||
// preamble ran; an AUQ error outside a skill still needs the exception.
|
||||
const d = directiveFor('spawned');
|
||||
expect(d).toMatch(/never auto-choose a destructive or irreversible option/i);
|
||||
expect(d).toMatch(/conservative non-destructive/);
|
||||
});
|
||||
|
||||
test('interactive directive carries the spawned escape sentence (#2733)', () => {
|
||||
// The sessionKind() shell-out runs in the HARNESS env, so a subagent
|
||||
// marked spawned via a per-command prefix classifies interactive here —
|
||||
// the directive text is the only lever for that topology.
|
||||
const d = directiveFor('interactive');
|
||||
expect(d).toMatch(/spawned subagent[\s\S]*auto-choose the recommended option/i);
|
||||
expect(d).toMatch(/destructive or irreversible gate[\s\S]*conservative/i);
|
||||
});
|
||||
|
||||
test('headless directive ALSO carries the spawned escape sentence (#2733 review, multi-specialist)', () => {
|
||||
// A spawned-marked subagent under a headless-classified parent env
|
||||
// (CI/eval-hosted /ship) hits the headless branch — the self-gating
|
||||
// escape keeps the JSON contract alive; plain headless still BLOCKs.
|
||||
const d = directiveFor('headless');
|
||||
expect(d).toMatch(/BLOCKED — AskUserQuestion unavailable/);
|
||||
expect(d).toMatch(/spawned subagent[\s\S]*auto-choose the recommended option/i);
|
||||
});
|
||||
|
||||
test('escape sentence scopes spawned claims to the creating prompt (anti-injection)', () => {
|
||||
const d = directiveFor('interactive');
|
||||
expect(d).toMatch(/NEVER qualify[\s\S]*prompt injection/i);
|
||||
});
|
||||
});
|
||||
|
||||
/** Spawn the hook with synthetic stdin + controlled env; parse its JSON stdout. */
|
||||
@@ -114,6 +145,15 @@ describe('hook integration — invoked as PostToolUse', () => {
|
||||
expect(out.additionalContext).toMatch(/auto-choose/i);
|
||||
});
|
||||
|
||||
test('error result + GSTACK_SESSION_KIND=spawned env → override beats Conductor-interactive (#2733)', () => {
|
||||
const out = runHook(
|
||||
{ tool_name: 'AskUserQuestion', tool_response: { is_error: true } },
|
||||
{ GSTACK_SESSION_KIND: 'spawned', CONDUCTOR_PORT: '55010' },
|
||||
);
|
||||
expect(out.additionalContext).toMatch(/SESSION_KIND=spawned/);
|
||||
expect(out.additionalContext).toMatch(/auto-choose/i);
|
||||
});
|
||||
|
||||
test('SUCCESSFUL answer → no injection (inert on real answers)', () => {
|
||||
const out = runHook(
|
||||
{ tool_name: 'AskUserQuestion', tool_response: { answers: [{ option_label: 'A' }] } },
|
||||
|
||||
Reference in New Issue
Block a user