v1.91.2.0 fix: consolidate gstack reliability wave (#2959)

* fix(memory-ingest): --scan-secrets scans the rendered page and fails closed

--scan-secrets ran gitleaks on the raw transcript .jsonl, then imported a
page rendered from it. gitleaks' assignment rules don't match across a
JSON-escaped quote (KEY=\"v\" on disk), so a secret the rendered page
shows as KEY="v" was imported unflagged. And the gate skipped a file only
on scanner "gitleaks" with findings, so a scan that errored (non-zero
exit, 16MB maxBuffer overflow on a file with many findings, unparseable
report) or could not run (gitleaks missing, slow-probe cooldown) imported
the file unscanned.

Scan the rendered page body, the exact bytes writeStaged() writes, via a
new secretScanText() helper, and skip the file whenever the scan did not
complete. Skipped files stay out of the state file, so the next run
retries them. Reword the helper warnings and setup-gbrain/memory.md,
which described the fail-open as intended.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(test): reconcile Bun failure markers and footer counts

* fix(sync-gbrain): verify source-scoped reads without mutation

* fix(test): recognize grounded TTHW target choices structurally

* fix(aside): make the readiness probe work under zsh and report why it failed

The probe built its deadline into `_T` and expanded it unquoted, so
`$_T aside repl …` only worked in a shell that word-splits. zsh does not: it
looked for a command literally named "gtimeout 30", the probe answered
ASIDE_NOT_RUNNING with Aside installed and ready, and every browsing skill
fell back to the bundled Chromium in silence. zsh is the macOS default and
Aside is macOS-only, so on a stock Mac the probe could never report READY.

The deadline becomes a function, `_gs_d`. It receives the command as "$@",
already split, so sh, bash and zsh all behave the same, and the gtimeout →
timeout → perl alarm chain is unchanged. A 4th arm runs the call unbounded
when none of the three is present, which is what the empty `_T` did before.
Not `eval`: it re-parses the string, so the parens and `;` of the perl arm
become syntax and that arm dies in bash *and* zsh — on a stock Mac, the arm
that actually runs.

On failure the probe now prints the CLI's reason after ASIDE_NOT_RUNNING:,
the shape gstack-render already uses: the first line that starts with a
capital letter, i.e. the CLI's own sentence or Node's `Error:` line below its
loader frame. "Not running" covers states with different fixes — no window
open for the profile, a NODE_OPTIONS preload that kills the CLI — and a bare
verdict sent all of them to "open the Aside app". The BROWSER SETUP prose
quotes that reason before asking the user to open the app.

The text pin asserted the broken invocation verbatim, so it now pins the
function and asserts neither `$_T aside repl` nor an eval form comes back. A
second test executes the rendered probe in sh, bash and zsh on each of the
four deadline arms with stubbed binaries on a narrowed PATH, plus two failing
CLIs: one that prints its own sentence, one that crashes like Node with the
useful line below the frame.

The deadline function costs zero bytes against the lines it replaces; the
reason costs 53 per copy of the probe (44 where the reworded BROWSER SETUP
line gives 9 back). That moves four guards by the measured amount:
plan-devex-review's skeleton cap to 68,550 (measured 68,544), plan-ceo-review's
skeleton cap to 80,150 (measured 80,111) and union ratio to 1.081 (measured
1.0803), and plan-eng-review's union ratio to 1.151 (measured 1.1504).

Fixes #2842, #2941.

* Clarify engineering review startup and decision flow

* Fix Windows readiness fixture PATH and command shim

* fix(test): recognize grounded TTHW target choices structurally

* Clarify engineering review startup and decision flow

* fix(test): restrict QA-only fixture tools to its no-Edit contract

* v1.90.0.0 fix(sync-gbrain): guard readiness verdicts and refresh metadata

* fix(browse): validate canonical upload targets

* fix(gbrain): classify structured PGLite busy response

* fix(browse): preserve native extension runtime APIs

* Fix displayless browser handoff ownership

* Accept unique installed autoplan methodology aliases

* fix(skills): preserve positional literals during installation

* fix(browse): checksum installer contents through stdin

* fix(test): normalize Windows checksum fixture paths

* test: emulate unavailable shasum in Windows checksum fixture

* fix(investigate): preserve owned freeze lifecycle

* fix(review): preserve N+1 retry and Red Team completion

* fix: bound Aside readiness and preserve safe fallback

* test: exercise setup and Chromium on native ARM

* fix: preserve install ownership and ARM browser selection

* Fix gbrain ingest scan boundaries and seed observation

* Refresh managed ship hooks and supervise expanded paid census

* Reject resumed gbrain pages excluded by current policy

* Recover zombie agent locks safely and enable CI Python venv

* Repair paid actor declarations and Aside pitch assertions

* Bump consolidated wave to next free minor release

* Clarify CEO review admin choices and option tradeoffs

* Preserve CEO mode handoff anchors in clarified workflow

* Make Windows portability fixtures use shell-native paths

* Restore ARM Bun alias and clarify ship review gates

* Refresh ship workflow golden snapshots

* Fix Windows DX documentation controls without piped stdin

* Decode Codex child pipes without Bun's encoded-stream stall

* Bound DX pre-review audit before product questions

* Clarify trusted review-start read in paid revalidation

* Bump consolidated wave to next free minor release

* Clarify CEO review admin choices and option tradeoffs

* Preserve CEO mode handoff anchors in clarified workflow

* Make Windows portability fixtures use shell-native paths

* Restore ARM Bun alias and clarify ship review gates

* Refresh ship workflow golden snapshots

* Fix Windows DX documentation controls without piped stdin

* Decode Codex child pipes without Bun's encoded-stream stall

* Bound DX pre-review audit before product questions

* Clarify trusted review-start read in paid revalidation

* Reconcile new main planning flow and paid judge census

* fix: reconcile rebased planning and source-bound validation

* test: pin cookie workflow judge to scored Sonnet model

* fix: keep terminal agent boot out of module imports

* fix: preserve pending-question uncertainty in engineering review

* fix: stabilize Windows reliability-wave fixtures

* fix: clarify design consultation research workflow

* fix: preserve independent design consultation inputs

* fix: resolve design taste scope and browser research guidance

* fix: make consultation opt-in preflight unambiguous

* test: await native Edge owner readiness or terminal result

---------

Co-authored-by: Bruce Krysiak <brucek@alum.mit.edu>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Antonio Vitalic <antoninte99@gmail.com>
This commit is contained in:
Garry Tan
2026-09-26 18:57:53 -04:00
committed by GitHub
co-authored by Bruce Krysiak Claude Opus 5.5 Antonio Vitalic
parent 2a113ae7e6
commit 01593aa67c
204 changed files with 9958 additions and 1705 deletions
+141
View File
@@ -0,0 +1,141 @@
name: Native ARM Setup Smoke
on:
pull_request:
paths:
- 'setup'
- 'package.json'
- 'bun.lock'
- 'patches/playwright-core*'
- 'scripts/build*.sh'
- 'browse/src/**'
- 'test/setup-playwright*.test.ts'
- 'test/arm-setup-smoke-workflow.test.ts'
- '.github/workflows/arm-setup-smoke.yml'
permissions:
contents: read
concurrency:
group: arm-setup-smoke-${{ github.event.pull_request.number }}
cancel-in-progress: true
jobs:
native-arm-setup:
runs-on: ubuntu-24.04-arm
timeout-minutes: 35
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1
with:
persist-credentials: false
- uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6
with:
bun-version: 1.4.0
- name: Seal the checked-out source and native toolchain
shell: bash
run: |
set -euo pipefail
test "$(uname -m)" = aarch64
test "$(bun --version)" = 1.4.0
test "$(bun -p 'process.arch')" = arm64
test "$(git rev-parse HEAD)" = "$GITHUB_SHA"
mkdir -p "$RUNNER_TEMP/arm-input" "$RUNNER_TEMP/arm-evidence"
git archive --format=tar HEAD > "$RUNNER_TEMP/arm-input/source.tar"
cp "$(command -v bun)" "$RUNNER_TEMP/arm-input/bun"
git rev-parse HEAD | tee "$RUNNER_TEMP/arm-evidence/source-sha.txt"
sha256sum setup bun.lock package.json | tee "$RUNNER_TEMP/arm-input/source.sha256"
cp "$RUNNER_TEMP/arm-input/source.sha256" "$RUNNER_TEMP/arm-evidence/"
(cd "$RUNNER_TEMP/arm-input" && sha256sum source.tar bun) > "$RUNNER_TEMP/arm-evidence/input.sha256"
- name: Install and launch Chromium on native Ubuntu 26.04 ARM64
shell: bash
timeout-minutes: 28
run: |
set -euo pipefail
export DOCKER_HOST=unix:///var/run/docker.sock
image=ubuntu:26.04@sha256:e03767b4dc7cb87fc57b1f119d40d9a997ecc5570dc6e22d57d6b7e333bbe78c
container="gstack-arm-${GITHUB_RUN_ID}-${GITHUB_RUN_ATTEMPT}"
trap 'docker rm -f "$container" >/dev/null 2>&1 || true' EXIT
test "$(docker info --format '{{.Architecture}}')" = aarch64
docker pull --platform linux/arm64 "$image"
docker image inspect "$image" > "$RUNNER_TEMP/arm-evidence/image.json"
test "$(docker image inspect "$image" --format '{{.Architecture}}')" = arm64
timeout --signal=TERM --kill-after=30s 1500s \
docker run --rm -i --name "$container" --platform linux/arm64 \
--cpus=2 --memory=6g --pids-limit=1024 --shm-size=1g \
--security-opt no-new-privileges \
--mount "type=bind,src=$RUNNER_TEMP/arm-input,dst=/input,readonly" \
"$image" bash -se <<'CONTAINER' 2>&1 | tee "$RUNNER_TEMP/arm-evidence/smoke.log"
set -euo pipefail
test "$(uname -m)" = aarch64
. /etc/os-release
test "$ID" = ubuntu
test "$VERSION_ID" = 26.04
printf 'NATIVE_OS=%s %s ARCH=%s\n' "$ID" "$VERSION_ID" "$(uname -m)"
export DEBIAN_FRONTEND=noninteractive
apt-get update
apt-get install -y --no-install-recommends ca-certificates git nodejs npm fonts-noto-color-emoji
install -m 0755 /input/bun /usr/local/bin/bun
ln -s bun /usr/local/bin/bunx
test "$(bun --version)" = 1.4.0
test "$(bunx --version)" = 1.4.0
test "$(bun -p 'process.arch')" = arm64
test "$(node -p 'process.arch')" = arm64
node --version
useradd --create-home --uid 10001 smoke
mkdir /work
tar --extract --file=/input/source.tar --directory=/work --no-same-owner
cd /work
sha256sum --check /input/source.sha256
chown -R smoke:smoke /work
as_smoke() {
runuser -u smoke -- env -i HOME=/home/smoke PATH=/usr/local/bin:/usr/bin:/bin \
LANG=C.UTF-8 GSTACK_HOME=/home/smoke/state \
PLAYWRIGHT_BROWSERS_PATH=/home/smoke/browsers \
GSTACK_PLAYWRIGHT_INSTALL_TIMEOUT=600 "$@"
}
as_smoke bun install --frozen-lockfile
bun node_modules/playwright/cli.js install-deps chromium
as_smoke bash -se <<'SMOKE'
set -euo pipefail
test ! -e "$PLAYWRIGHT_BROWSERS_PATH"
bin/gstack-config set telemetry off
bash setup --host claude --no-team --no-plan-tune-hooks --no-timeline-stop-hook </dev/null 2>&1 | tee /home/smoke/setup.log
if grep -Eq 'Browser unavailable:|Chromium install skipped by request' /home/smoke/setup.log; then
exit 1
fi
sha256sum --check /input/source.sha256
test -x browse/dist/browse
node <<'BROWSER'
const assert = require('node:assert/strict');
const fs = require('node:fs');
const { chromium } = require('/work/node_modules/playwright');
(async () => {
const executable = chromium.executablePath();
assert.ok(executable.startsWith('/home/smoke/browsers/'));
const elf = fs.readFileSync(executable);
assert.equal(elf.subarray(0, 4).toString('hex'), '7f454c46');
assert.equal(elf.readUInt16LE(18), 183);
const browser = await chromium.launch({ executablePath: executable, timeout: 30000 });
try {
const page = await browser.newPage();
await page.setContent('<title>Native ARM smoke</title><h1>Ubuntu 26.04 ARM64</h1>');
assert.equal(await page.title(), 'Native ARM smoke');
assert.equal(await page.locator('h1').innerText(), 'Ubuntu 26.04 ARM64');
assert.ok((await page.screenshot()).length > 0);
console.log(JSON.stringify({ status: 'PASS', arch: process.arch, elfMachine: 183,
browserVersion: browser.version(), executable }));
} finally {
await browser.close();
}
})().catch(error => { console.error(error); process.exit(1); });
BROWSER
SMOKE
CONTAINER
- name: Retain source seals and native smoke evidence
if: always()
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a
with:
name: native-arm-setup-${{ github.run_id }}-${{ github.run_attempt }}
path: ${{ runner.temp }}/arm-evidence/
retention-days: 14
if-no-files-found: error
+6 -6
View File
@@ -107,7 +107,7 @@ jobs:
- name: Emit gate census manifest (ALL gate tests)
env:
EVALS_ALL: "1"
run: EVALS_TIER=gate bun run scripts/test-paid-shards.ts --tier gate --emit-plan /tmp/gate-census-plan/manifest.json --slices 6
run: EVALS_TIER=gate bun run scripts/test-paid-shards.ts --tier gate --emit-plan /tmp/gate-census-plan/manifest.json --slices 7
- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
with:
@@ -119,8 +119,8 @@ jobs:
runs-on: ubicloud-standard-8
needs: [build-image, plan-slices]
# Eight slices retain every registered case and retry. The complete
# census needs at most 318m40 per slice, plus 20 minutes setup/upload.
timeout-minutes: 355
# census needs at most 338 minutes per slice, plus 20 minutes setup/upload.
timeout-minutes: 358
permissions:
contents: read
packages: read
@@ -212,7 +212,7 @@ jobs:
gate-census:
runs-on: ubicloud-standard-8
needs: [build-image, plan-slices]
# Six slices need at most 332m each, plus 20 minutes setup/upload.
# Seven slices need at most 304m each, plus 20 minutes setup/upload.
timeout-minutes: 352
permissions:
contents: read
@@ -228,7 +228,7 @@ jobs:
fail-fast: false
max-parallel: 4
matrix:
slice: [1, 2, 3, 4, 5, 6]
slice: [1, 2, 3, 4, 5, 6, 7]
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
@@ -253,7 +253,7 @@ jobs:
name: gate-census-plan
path: /tmp/gate-census-plan
- name: Run gate census slice ${{ matrix.slice }}/6
- name: Run gate census slice ${{ matrix.slice }}/7
env:
ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }}
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
+2 -2
View File
@@ -184,9 +184,9 @@ jobs:
# 40-way per row queued claude session STARTUP behind 39 siblings and ate
# per-test budgets — the documented timeout-flake family). Tune with
# parity data before raising.
# The complete gate census needs at most 201 minutes per slice; keep
# The complete gate census needs at most 236 minutes per slice; keep
# 20 minutes for setup/upload without preempting configured retries.
timeout-minutes: 221
timeout-minutes: 256
permissions:
contents: read
packages: read