mirror of
https://github.com/garrytan/gstack.git
synced 2026-05-06 05:35:46 +02:00
feat: add distribution pipeline checks across skill workflow
When designing CLI tools, libraries, or other standalone artifacts, the workflow now checks whether a build/publish pipeline exists at every stage: - /office-hours: Phase 3 premise challenge asks "how will users get it?" Design doc templates include a "Distribution Plan" section. - /plan-eng-review: Step 0 Scope Challenge adds distribution check (#6). Architecture Review checks distribution architecture for new artifacts. - /ship: New Step 1.5 detects new cmd/main.go additions and verifies a release workflow exists. Offers to add one or defer to TODOS.md. - /review checklist: New "Distribution & CI/CD Pipeline" category in Pass 2 (INFORMATIONAL) covers CI version pins, cross-platform builds, publish idempotency, and version tag consistency. Motivation: In a real project, we designed and shipped a complete CLI tool (design doc, eng review, implementation, deployment) but forgot the CI/CD release pipeline. The binary was built locally but never published — users couldn't download it. This gap was invisible because no skill in the chain asked "how does the artifact reach users?" Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -83,6 +83,33 @@ If the Eng Review is NOT "CLEAR":
|
||||
|
||||
---
|
||||
|
||||
## Step 1.5: Distribution Pipeline Check
|
||||
|
||||
If the diff introduces a new standalone artifact (CLI binary, library package, tool) — not a web
|
||||
service with existing deployment — verify that a distribution pipeline exists.
|
||||
|
||||
1. Check if the diff adds a new `cmd/` directory, `main.go`, or `bin/` entry point:
|
||||
```bash
|
||||
git diff origin/<base> --name-only | grep -E '(cmd/.*/main\.go|bin/|Cargo\.toml|setup\.py|package\.json)' | head -5
|
||||
```
|
||||
|
||||
2. If new artifact detected, check for a release workflow:
|
||||
```bash
|
||||
ls .github/workflows/ 2>/dev/null | grep -iE 'release|publish|dist'
|
||||
```
|
||||
|
||||
3. **If no release pipeline exists and a new artifact was added:** Use AskUserQuestion:
|
||||
- "This PR adds a new binary/tool but there's no CI/CD pipeline to build and publish it.
|
||||
Users won't be able to download the artifact after merge."
|
||||
- A) Add a release workflow now (GitHub Actions cross-platform build + GitHub Releases)
|
||||
- B) Defer — add to TODOS.md
|
||||
- C) Not needed — this is internal/web-only, existing deployment covers it
|
||||
|
||||
4. **If release pipeline exists:** Continue silently.
|
||||
5. **If no new artifact detected:** Skip silently.
|
||||
|
||||
---
|
||||
|
||||
## Step 2: Merge the base branch (BEFORE tests)
|
||||
|
||||
Fetch and merge the base branch into the feature branch so tests run against the merged state:
|
||||
|
||||
Reference in New Issue
Block a user