From 02eba57f3a1f28aaa45c10585d82c5f980b5b88b Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Sun, 7 Jun 2026 18:21:41 -0700 Subject: [PATCH] fix(test): align section-loading E2E testNames with their TOUCHFILES keys MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Pre-existing on main (v1.56.x): the two section-loading E2E tests used human-label testNames ('/ship section-loading') that don't match their slug keys ('ship-section-loading') in E2E_TOUCHFILES/E2E_TIERS. Every other E2E test uses the slug as its testName, and the TOUCHFILES completeness gate requires testName to be a registered key — so the gate was red. Align both testNames to their slug keys (also fixes tier lookup for these two periodic tests). Verified failing on a clean origin/main checkout before the fix. Co-Authored-By: Claude Opus 4.8 (1M context) --- test/skill-e2e-plan-ceo-review-section-loading.test.ts | 2 +- test/skill-e2e-ship-section-loading.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/skill-e2e-plan-ceo-review-section-loading.test.ts b/test/skill-e2e-plan-ceo-review-section-loading.test.ts index a4f96e080..6cac8960e 100644 --- a/test/skill-e2e-plan-ceo-review-section-loading.test.ts +++ b/test/skill-e2e-plan-ceo-review-section-loading.test.ts @@ -74,7 +74,7 @@ describeE2E('/plan-ceo-review section-loading E2E (periodic, SDK capture)', () = 'Review the plan in PLAN.md. Hold the current scope (HOLD SCOPE mode) — do not challenge or expand scope. Run the full CEO review and produce the review report.', requiredSections: REQUIRED_SECTIONS, reportMarker: /GSTACK REVIEW REPORT|COMPLETION SUMMARY|review/i, - testName: '/plan-ceo-review section-loading', + testName: 'plan-ceo-section-loading', runId, }); diff --git a/test/skill-e2e-ship-section-loading.test.ts b/test/skill-e2e-ship-section-loading.test.ts index a681ff114..4e6a717cf 100644 --- a/test/skill-e2e-ship-section-loading.test.ts +++ b/test/skill-e2e-ship-section-loading.test.ts @@ -65,7 +65,7 @@ describeE2E('/ship section-loading E2E (periodic, SDK capture)', () => { 'This is a FRESH version-changing ship: the branch has a real code change (app.js gained a new function with a test), VERSION still equals the base version (0.0.1, so it needs a bump), and CHANGELOG.md needs a new entry. Follow the skill\'s flow for a version-changing ship: run the pre-landing review and prepare the CHANGELOG entry. Produce the ship plan / review report. Do NOT actually commit, push, or open a PR.', requiredSections: REQUIRED_SECTIONS, reportMarker: /version|changelog|review|ship/i, - testName: '/ship section-loading', + testName: 'ship-section-loading', runId, });