CalvinBackup/gstack
1
0 Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-10-05 02:47:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

test: pin DISABLE_AUTOUPDATER in hermetic env and capture corrupt-seed warning

Browse Source 
Both EVALS_HERMETIC branches of buildHermeticEnv now carry
DISABLE_AUTOUPDATER=1 (the allowlist scrubbed the workflow's copy, so every
PTY screen showed the updater's npm-prefix failure). Per-test overrides
still win. The corrupt durations-seed test now captures its expected
warning and restores the console spy.
This commit is contained in:
garrytan committed 2026-09-29 14:22:05 +00:00
1 parent dcaea52800
commit 049fdc315b
4 files changed
+33 -8
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

test/helpers/hermetic-env.ts
+9 -3
View File
@@ -21,11 +21,15 @@
* └─────────────────────────────┘
* + per-runner extraAllow (codex: OpenAI vars; gemini: Google vars)
* + CLAUDE_CONFIG_DIR=<runRoot>/.claude GSTACK_HOME=<runRoot>/gstack-home
* + DISABLE_AUTOUPDATER=1 (pinned in both branches; the scrub drops the
* workflow's copy and every PTY screen otherwise shows the updater's
* "no write permission to npm prefix" failure)
* + per-test overrides spread LAST
*
* Escape hatch: EVALS_HERMETIC=0 restores the legacy contaminated env
* byte-identically (runners must also gate --strict-mcp-config on
* isHermeticEnabled() so the escape hatch restores args too).
* plus only the DISABLE_AUTOUPDATER pin (runners must also gate
* --strict-mcp-config on isHermeticEnabled() so the escape hatch restores
* args too).
*
* isHermeticEnabled() is evaluated at CALL time, never at module load —
* ESM hoists imports above any in-file `process.env.EVALS_HERMETIC = '0'`
@@ -100,9 +104,10 @@ export function buildHermeticEnv(
opts?: HermeticEnvOpts,
): Record<string, string> {
if (!isHermeticEnabled(base)) {
// Escape hatch: byte-identical to the legacy spread.
// Escape hatch: the legacy spread plus the updater pin.
const legacy: Record<string, string> = {};
for (const [k, v] of Object.entries(base)) if (v !== undefined) legacy[k] = v;
legacy.DISABLE_AUTOUPDATER = '1';
for (const [k, v] of Object.entries(overrides ?? {})) if (v !== undefined) legacy[k] = v;
return legacy;
}
@@ -127,6 +132,7 @@ export function buildHermeticEnv(
if (allowed) out[k] = v;
}
if (!out.TERM) out.TERM = 'xterm-256color';
out.DISABLE_AUTOUPDATER = '1';
Object.assign(out, hermeticVars);
for (const [k, v] of Object.entries(overrides ?? {})) if (v !== undefined) out[k] = v;
return out;