mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-07 17:28:23 +01:00
wave github-99ae73c79d3c: merge #3833 (234b6d37ee)
This commit is contained in:
commit
0543d54d3c
3 files changed
+14
-2
No files matched your search
@@ -200,7 +200,8 @@ jobs:
|
|||||||
# code that compares a realpath with an unresolved path passes on Linux's
|
# code that compares a realpath with an unresolved path passes on Linux's
|
||||||
# /tmp and fails here (#2982). TMPDIR is deliberately left at the runner's
|
# /tmp and fails here (#2982). TMPDIR is deliberately left at the runner's
|
||||||
# default, and the job fails if that layout is not symlinked. It also sources
|
# default, and the job fails if that layout is not symlinked. It also sources
|
||||||
# the Codex probe from zsh, macOS's default shell (#3024; no paid call).
|
# the Codex probe from zsh, macOS's default shell (#3024; no paid call), and
|
||||||
|
# runs ubi-runner under macOS's bsdtar and one-true-awk (#3680, #3679).
|
||||||
macos-named-regressions:
|
macos-named-regressions:
|
||||||
needs: reuse
|
needs: reuse
|
||||||
if: ${{ !cancelled() && (needs.reuse.result != 'success' || needs.reuse.outputs.reused != 'true') }}
|
if: ${{ !cancelled() && (needs.reuse.result != 'success' || needs.reuse.outputs.reused != 'true') }}
|
||||||
@@ -243,7 +244,7 @@ jobs:
|
|||||||
resolved="$(realpath "$tmp")"
|
resolved="$(realpath "$tmp")"
|
||||||
echo "temp root: $tmp -> $resolved"
|
echo "temp root: $tmp -> $resolved"
|
||||||
test "$resolved" != "${tmp%/}"
|
test "$resolved" != "${tmp%/}"
|
||||||
files=(test/gstack-design-detect.test.ts browse/test/chromium-profile-isolation.test.ts test/cso-git-hardening.test.ts test/plan-count-file-permission.test.ts test/spec-quality-gate-secret-sink.test.ts test/gstack-memory-ingest.test.ts test/regression-issue3024-zsh-sourced-helpers.test.ts test/codex-probe-subcommands.test.ts browse/test/proxy-env-daemon.test.ts browse/test/proxy-direct-launch-args.test.ts)
|
files=(test/gstack-design-detect.test.ts browse/test/chromium-profile-isolation.test.ts test/cso-git-hardening.test.ts test/plan-count-file-permission.test.ts test/spec-quality-gate-secret-sink.test.ts test/gstack-memory-ingest.test.ts test/regression-issue3024-zsh-sourced-helpers.test.ts test/codex-probe-subcommands.test.ts browse/test/proxy-env-daemon.test.ts browse/test/proxy-direct-launch-args.test.ts test/regression-issue3680-ubicloud-bsd-userland.test.ts)
|
||||||
for file in "${files[@]}"; do test -f "$file"; done
|
for file in "${files[@]}"; do test -f "$file"; done
|
||||||
bun test "${files[@]}"
|
bun test "${files[@]}"
|
||||||
|
|
||||||
|
|||||||
@@ -0,0 +1 @@
|
|||||||
|
The macOS `macos-named-regressions` CI job now runs `test/regression-issue3680-ubicloud-bsd-userland.test.ts`, so the ubi-runner cases for #3680 (bsdtar) and #3679 (macOS awk) run on a real Mac against `/usr/bin/tar` and `/usr/bin/awk`. Before, the file ran only on Linux CI, where bsdtar and one-true-awk aren't installed, so every case skipped and a regression in either could merge green. A new wiring test fails if the macOS job stops naming the file.
|
||||||
@@ -120,3 +120,13 @@ printf 200
|
|||||||
} finally { rmSync(f.root, { recursive: true, force: true }); }
|
} finally { rmSync(f.root, { recursive: true, force: true }); }
|
||||||
}, 60_000);
|
}, 60_000);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('CI runs these cases on the BSD userland itself', () => {
|
||||||
|
// Value: protects=the cases above run where /usr/bin/tar and /usr/bin/awk are the BSD tools; fails_when=macos-named-regressions stops naming this file, so Linux CI (no bsdtar or one-true-awk installed) skips every case and a #3680 or #3679 regression ships green; why_new=the file was only in the Linux free suite; seam=.github/workflows/free-tests.yml; no_claim=the job's runner image or its tool versions
|
||||||
|
test('free-tests.yml macos-named-regressions names this file', () => {
|
||||||
|
const workflow = Bun.YAML.parse(readFileSync(join(ROOT, '.github/workflows/free-tests.yml'), 'utf8')) as any;
|
||||||
|
const mac = workflow.jobs['macos-named-regressions'];
|
||||||
|
expect(mac['runs-on']).toMatch(/^macos-/);
|
||||||
|
expect((mac.steps as any[]).map(step => String(step.run ?? '')).join('\n')).toContain('test/regression-issue3680-ubicloud-bsd-userland.test.ts');
|
||||||
|
});
|
||||||
|
});
|
||||||
Reference in new issue
Block a user