mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-27 07:01:54 +02:00
v1.89.0.0 feat: add shared-code extraction audit (#2925)
* feat: bind shared-code review advice to source and branch * feat: add shared-code extraction audit and scoped review checks * test: recognize complete source reads and explicit coverage legends * chore: bump version and changelog (v1.88.0.0) Co-Authored-By: OpenAI Codex <noreply@openai.com> * test: capture native review questions and retain public evidence Capture the actual first public native question with strict ownership and display matching. Preserve terminal failures and raw evidence, and retain SDK completion checks. * test: recognize verified review evidence and complete fixtures Recognize complete source and diagram evidence, concrete design and developer-experience decisions, and the complete planted scenario contracts. Preserve negative controls and grading thresholds. * fix: preserve decision brief structure in native questions Keep the required pros-and-cons heading and final Net field in native question text. Regenerate host outputs and document the release and evaluation repairs. Co-Authored-By: OpenAI Codex <noreply@openai.com> * docs: update project documentation for v1.88.0.0 Co-Authored-By: OpenAI Codex <noreply@openai.com> * fix: correct eval retry accounting and ship workflow gates * fix: capture native eval evidence and stabilize CI fixtures * fix: keep shared-code eval skips read-only Choose explicit no-change answers instead of mixed fix/preservation options. Reuse the bounded revalidation prompt for path fixtures so required review metadata is available without repeated discovery. Preserve source checks, retry limits, and failed native terminal outcomes. Add captured-question and callback regressions, plus evaluation selection coverage for the affected fixtures. --------- Co-authored-by: OpenAI Codex <noreply@openai.com>
This commit is contained in:
co-authored by
OpenAI Codex
parent
b9706f3635
commit
06ed920a97
@@ -18,6 +18,30 @@ function rendered(rel: string): string {
|
||||
}
|
||||
|
||||
describe('content-binding template drift', () => {
|
||||
test('design-lite records outside coverage after the outside step in ship', () => {
|
||||
const text = rendered('ship/sections/review-army.md');
|
||||
const outside = text.indexOf('design voice**');
|
||||
expect(outside).toBeGreaterThan(-1);
|
||||
expect(text.indexOf('--finish DESIGN_START')).toBeGreaterThan(outside);
|
||||
expect(text).toContain('Use the original DESIGN_START token');
|
||||
});
|
||||
|
||||
test('ship eval selection scopes the Rails example below the project-native path', () => {
|
||||
const text = rendered('ship/sections/tests.md');
|
||||
const native = text.indexOf('**Project-native path:**');
|
||||
const rails = text.indexOf('**Rails example only');
|
||||
expect(native).toBeGreaterThan(-1);
|
||||
expect(rails).toBeGreaterThan(native);
|
||||
expect(text).not.toContain('**If no matches:**');
|
||||
expect(text).toContain('If any eval fails');
|
||||
});
|
||||
|
||||
test('ship historical readiness does not replace the current pre-landing gate', () => {
|
||||
const text = rendered('ship/SKILL.md');
|
||||
expect(text).not.toContain('The only review that gates shipping');
|
||||
expect(text).toContain('Step 9 remains mandatory');
|
||||
});
|
||||
|
||||
test('ship Step 16 carries the evidence check (mechanized IRON LAW)', () => {
|
||||
const ship = rendered('ship/SKILL.md');
|
||||
expect(ship).toMatch(/gstack-evidence check --label tests --expect-cmd '[^']+' --label vitest --expect-cmd '[^']+' --max-age 24 --allow-paths CHANGELOG\.md,VERSION,package\.json/);
|
||||
@@ -80,7 +104,7 @@ describe('content-binding template drift', () => {
|
||||
const army = rendered('ship/sections/review-army.md');
|
||||
expect(army.indexOf('gstack-review-log --start review')).toBeLessThan(army.indexOf('run `git diff origin/<base>`'));
|
||||
expect(army).toContain('--finish REVIEW_START');
|
||||
expect(army).toContain('persist item 9 with `converged:false`');
|
||||
expect(army).toContain('persist item 6 below with `converged:false`');
|
||||
expect(army).toContain('--start design-review-lite');
|
||||
expect(army).toContain('--finish DESIGN_START');
|
||||
const codex = rendered('codex/sections/review-mode.md');
|
||||
|
||||
Reference in New Issue
Block a user