mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-27 15:11:47 +02:00
v1.89.0.0 feat: add shared-code extraction audit (#2925)
* feat: bind shared-code review advice to source and branch * feat: add shared-code extraction audit and scoped review checks * test: recognize complete source reads and explicit coverage legends * chore: bump version and changelog (v1.88.0.0) Co-Authored-By: OpenAI Codex <noreply@openai.com> * test: capture native review questions and retain public evidence Capture the actual first public native question with strict ownership and display matching. Preserve terminal failures and raw evidence, and retain SDK completion checks. * test: recognize verified review evidence and complete fixtures Recognize complete source and diagram evidence, concrete design and developer-experience decisions, and the complete planted scenario contracts. Preserve negative controls and grading thresholds. * fix: preserve decision brief structure in native questions Keep the required pros-and-cons heading and final Net field in native question text. Regenerate host outputs and document the release and evaluation repairs. Co-Authored-By: OpenAI Codex <noreply@openai.com> * docs: update project documentation for v1.88.0.0 Co-Authored-By: OpenAI Codex <noreply@openai.com> * fix: correct eval retry accounting and ship workflow gates * fix: capture native eval evidence and stabilize CI fixtures * fix: keep shared-code eval skips read-only Choose explicit no-change answers instead of mixed fix/preservation options. Reuse the bounded revalidation prompt for path fixtures so required review metadata is available without repeated discovery. Preserve source checks, retry limits, and failed native terminal outcomes. Add captured-question and callback regressions, plus evaluation selection coverage for the affected fixtures. --------- Co-authored-by: OpenAI Codex <noreply@openai.com>
This commit is contained in:
co-authored by
OpenAI Codex
parent
b9706f3635
commit
06ed920a97
@@ -189,17 +189,19 @@ describe('workflow judge file bundle', () => {
|
||||
test('generated ship includes base-branch initialization and every lazy section once', () => {
|
||||
const skillPath = 'ship/SKILL.md';
|
||||
const source = readFileSync(join(ROOT, skillPath), 'utf8');
|
||||
// Read the paid caller's actual slice so changing its marker back to the
|
||||
// title cannot silently drop initialization while this helper test passes.
|
||||
// Bind to the paid caller's actual slice and retain both the opening contract
|
||||
// and initialization, regardless of their ordering in the authored workflow.
|
||||
const caller = readFileSync(join(ROOT, 'test/skill-llm-eval.test.ts'), 'utf8');
|
||||
const markers = caller.match(/skillPath: 'ship\/SKILL\.md',\s+startMarker: '([^']+)',\s+endMarker: '([^']+)'/);
|
||||
expect(markers).not.toBeNull();
|
||||
const [, startMarker, endMarker] = markers!;
|
||||
expect(startMarker).toBe('## Step 0: Detect platform and base branch');
|
||||
expect(startMarker).toBe('# Ship:');
|
||||
const input = readWorkflowJudgeInput({ root: ROOT, skillPath, startMarker, endMarker });
|
||||
const entrypoint = input.files.find(file => file.kind === 'entrypoint');
|
||||
expect(entrypoint?.content).toBe(source.slice(source.indexOf(startMarker), source.indexOf(endMarker, source.indexOf(startMarker))));
|
||||
expect(entrypoint?.content).toContain('git remote get-url origin');
|
||||
expect(entrypoint?.content).toContain('**Follow every STOP and AskUserQuestion gate**');
|
||||
expect(entrypoint?.content).toContain('## Step 0: Detect platform and base branch');
|
||||
expect(entrypoint?.content).toContain('gh pr view --json baseRefName');
|
||||
expect(entrypoint?.content).toContain('Print the detected base branch name.');
|
||||
expect(occurrences(input.text, startMarker)).toBe(1);
|
||||
|
||||
Reference in New Issue
Block a user