/ship no longer reports zero blockers when the second-model review found one (GST-3075) (#4485)

When /ship stopped on a second-model review finding marked "Blocks:
yes", the record it left on the PR said no blockers were found; now the
finding is counted and /ship will not write that record until it is
fixed or ruled.

Why: `ready` and the merge step trust that record, so an undercount let
a blocked PR look clean.

Nothing to do: the next /ship run logs Step 11's findings and checks
them before writing.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: h2p1/red-team#1 reader=red-team
Review-Finding: h2p1/red-team#2 reader=red-team
Review-Finding: h2p1/red-team#3 reader=red-team
Review-Finding: v1/outside-voice#1 reader=outside-voice
This commit is contained in:
Garry Tanandcapy-ai[bot] authored and GitHub committed 2026-11-18 12:51:14 +00:00
1 parent bbf48aa7ef
commit 07611a00a7
19 files changed
+190 -16

No files matched your search

+1
View File
@@ -802,6 +802,7 @@ puts in the receipt:
| `review_loop.passes` | full review passes this ship ran (1 or 2; up to 3 under `review_scope: diff-plus-blocking` or `all`) |
| `review_loop.blocking_found` | every blocker found (GST-951): the rows' blocking findings (classified, or an unclassified CRITICAL), plus each ledger CRITICAL (as collected or judged) that no row finding from the same reviewer at the same path:line accounts for (each row finding pairs with one per ledger), so an adversarial, outside-voice or not-yet-classified blocker counts and one whose newest classification is below the floor does not. An unreadable ledger, merged file or judged set, or a judged set changed since `judge`, is `REVIEW_SCOPE_LEDGER`, never a count |
| `review_loop.unrecorded` | blockers found that no row gives a disposition (fixed, deferred, noted, skipped, a gate answer); absent when 0 |
| `review_loop.open` | blockers a row still holds as `open` at its newest action, gate findings aside (GST-3075), each its ledger id or fingerprint (or `{ id, fingerprint }`); Step 11's `adversarial-review` row counts here like a pass's row but is never a pass or a round. Only a later row's action clears one, and while any is left with no owner ruling, `gstack-ship-receipt write` refuses with [`RECEIPT_BLOCKER_OPEN`](troubleshooting.md#receipt-blocker-open); absent when 0 |
| `review_loop.unbound` | what could not bind (GST-1168), each printed as `REVIEW_SCOPE_UNBOUND: <what>: <why>`: a row with no start token and no readable time, a `pN` ledger with no review row of pass N (a fix-check ledger in a `pN` directory is not a pass ledger, GST-1775), a row finding's `ledger_id` no ledger collected, a `Review-Finding` trailer naming nothing; absent when 0 |
| `review_loop.ledgers_read` | dispatch ledgers the count read; absent under `--no-ledger` |
| `REVIEW_SCOPE_VOIDED:` (stderr, not a receipt field) | an abandoned pass (GBEV-3): a `pN` ledger never judged that no row names, replaced by a later `pM` ledger (M > N) that was judged or is named. Its findings are left out of every count above instead of counting as unbound and unrecorded. A fix-check ledger and the last pass are never voided |
+20
View File
@@ -7284,6 +7284,26 @@ outside the range is listed as `not applied`, and a path edited after the
fix-check still routes by the post-review rules. When the owner wants the
findings fixed instead, fix them and ask for a grant for one more fix-check.
<a id="receipt-blocker-open"></a>
### `RECEIPT_BLOCKER_OPEN`
**Meaning.** `gstack-ship-receipt write` wrote nothing because the
`--review-loop` record (`gstack-review-scope summary`) lists a blocking
finding that is still `open`: a review-log row holds it, its newest action is
`open`, and no owner ruled note closes it. That happens when /ship
stops with a blocker unfixed, for example a second-model review finding marked
`Blocks: yes` in Step 11 that no later Step 9 pass fixed. A receipt there would
claim a review that never cleared the blocker (GST-3075). Gate findings keep
their own path (an `open` gate finding makes the PR a draft) and are not
counted here.
**Fix.** Fix the finding, commit, and run /ship again on the new head; that
run's Step 9 row records it `fixed`. If it should ship unfixed, take the stop
to the owner: their ruled note (`gstack-approvals rule`) closes it, or their
grant buys one fix-check. Never edit the review-log row or the loop file to
drop the finding, and never write the receipt by hand
([ship-policy.md](ship-policy.md#ship-receipt)).
<a id="review-loop-exception-invalid"></a>
### `REVIEW_LOOP_EXCEPTION_INVALID`