mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-18 22:24:17 +01:00
/ship no longer reports zero blockers when the second-model review found one (GST-3075) (#4485)
When /ship stopped on a second-model review finding marked "Blocks: yes", the record it left on the PR said no blockers were found; now the finding is counted and /ship will not write that record until it is fixed or ruled. Why: `ready` and the merge step trust that record, so an undercount let a blocked PR look clean. Nothing to do: the next /ship run logs Step 11's findings and checks them before writing. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> Review-Finding: h2p1/red-team#1 reader=red-team Review-Finding: h2p1/red-team#2 reader=red-team Review-Finding: h2p1/red-team#3 reader=red-team Review-Finding: v1/outside-voice#1 reader=outside-voice
This commit is contained in:
1 parent
bbf48aa7ef
commit
07611a00a7
19 files changed
+190
-16
No files matched your search
@@ -309,6 +309,10 @@ export const KNOWN_WINDOWS_INCOMPATIBLE: Array<{ file: string; reason: string }>
|
||||
file: 'test/gstack-ship-receipt.test.ts',
|
||||
reason: 'spawns bin/gstack-ship-receipt and bin/gstack-artifact (shebangs) plus a #!/bin/sh gh shim through test/helpers/restamp-fixture.ts',
|
||||
},
|
||||
{
|
||||
file: 'test/ship-receipt-voice-blockers.test.ts',
|
||||
reason: 'spawns bin/gstack-review-scope and bin/gstack-ship-receipt (shebangs) through test/helpers/restamp-fixture.ts runBin, like test/gstack-ship-receipt.test.ts',
|
||||
},
|
||||
// Field list 2, W1 (shared merge queue): same fixture helpers, same shebang spawns.
|
||||
{
|
||||
file: 'test/gstack-ship-queue.test.ts',
|
||||
|
||||
@@ -208,7 +208,7 @@ its original token. If it never started because it was unavailable, disabled or
|
||||
size-gated, omit \`--finish PASS_START\` and set completed/converged false.
|
||||
Do not create or borrow a token just to save a result.
|
||||
\`\`\`bash
|
||||
~/.claude/skills/gstack/bin/gstack-review-log '{"skill":"adversarial-review","timestamp":"'"$(date -u +%Y-%m-%dT%H:%M:%SZ)"'","status":"STATUS","source":"SOURCE","host":"${ctx.host}","outside_provider":"${outsideVoiceFor(ctx).id}","outside_status":"OUTSIDE_STATUS","phase":"PHASE","tier":"always","gate":"GATE","commit":"'"$(git rev-parse --short HEAD)"'","completed":COMPLETED,"converged":CONVERGED}' --finish PASS_START
|
||||
~/.claude/skills/gstack/bin/gstack-review-log '{"skill":"adversarial-review",${isShip ? '"via":"ship",' : ''}"timestamp":"'"$(date -u +%Y-%m-%dT%H:%M:%SZ)"'","status":"STATUS","source":"SOURCE","host":"${ctx.host}","outside_provider":"${outsideVoiceFor(ctx).id}","outside_status":"OUTSIDE_STATUS","phase":"PHASE","tier":"always","gate":"GATE","commit":"'"$(git rev-parse --short HEAD)"'","completed":COMPLETED,"converged":CONVERGED${isShip ? ',"findings":FINDINGS' : ''}}' --finish PASS_START
|
||||
\`\`\`
|
||||
PASS_START belongs to that attempt, not the parent's REVIEW_START. Each token is consumed once.
|
||||
Fill fields from this attempt, not the parent's ${isShip ? 'Step 9.4' : 'Step 5.8'} result:
|
||||
@@ -222,7 +222,13 @@ Fill fields from this attempt, not the parent's ${isShip ? 'Step 9.4' : 'Step 5.
|
||||
a completed pass with findings, or "unavailable" for an incomplete pass.
|
||||
- GATE is "informational" for adversarial passes. For structured review, use
|
||||
"pass" or "fail" from its completed result, "skipped" when size-gated, or
|
||||
"informational" with completed:false when coverage is missing.
|
||||
"informational" with completed:false when coverage is missing.${isShip ? `
|
||||
- FINDINGS is a JSON array, one record per finding this attempt raised, in Step 9.4's
|
||||
shape (\`fingerprint\`, \`severity\`, \`blocking\`, \`raised_by\`, \`ledger_id\`) with ACTION
|
||||
\`"open"\` for a blocker (CRITICAL, High or \`Blocks: yes\`) and \`"noted"\` below the floor;
|
||||
\`[]\` when it raised none. The receipt counts these rows' blockers, and one still
|
||||
\`open\` when the run stops (no later Step 9 row fixed or deferred it) makes
|
||||
\`gstack-ship-receipt write\` refuse (\`RECEIPT_BLOCKER_OPEN\`).` : ''}
|
||||
|
||||
---`;
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user