mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-19 06:34:43 +01:00
/ship no longer reports zero blockers when the second-model review found one (GST-3075) (#4485)
When /ship stopped on a second-model review finding marked "Blocks: yes", the record it left on the PR said no blockers were found; now the finding is counted and /ship will not write that record until it is fixed or ruled. Why: `ready` and the merge step trust that record, so an undercount let a blocked PR look clean. Nothing to do: the next /ship run logs Step 11's findings and checks them before writing. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> Review-Finding: h2p1/red-team#1 reader=red-team Review-Finding: h2p1/red-team#2 reader=red-team Review-Finding: h2p1/red-team#3 reader=red-team Review-Finding: v1/outside-voice#1 reader=outside-voice
This commit is contained in:
1 parent
bbf48aa7ef
commit
07611a00a7
19 files changed
+190
-16
No files matched your search
@@ -1 +1 @@
|
||||
{"sha":"72d45950b82d885fea5aa67a05b516912f54e5080ceeb360cfad44380b282dd0","replay":"GST-1821"}
|
||||
{"sha":"18b1627a6886fe2e0f0e6cc80a33ac2ee138ac2c8996f51bcb68a108f281acb6","replay":"GST-3075"}
|
||||
@@ -0,0 +1 @@
|
||||
{"replay":"GST-3075","justification":"GST-3075 (a /ship record counts the second-model review's blockers): ship/sections/adversarial.md changes only Step 11's review-log persistence prose for the lead, the gstack-review-log call that records each voice attempt (it now adds via:ship and a FINDINGS array) and one FINDINGS bullet saying what that array holds and that an open blocker makes gstack-ship-receipt write refuse. No reviewer reads that prose. Deterministic no-loss check, no paid run: every brief body lib/review-brief.ts cuts from the ship sections keeps its pinned hash (test/fixtures/review-pins/brief-bodies unchanged; test/review-packets-removed.test.ts 'every reviewer brief cut from the ship sections is byte-identical to its pinned body' passes at this tree). No reader, depth, dispatch, brief, checklist or finding rule changes; CREW rule 15 exempts non-reviewer /ship prose."}
|
||||
Reference in new issue
Block a user