mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-19 06:34:43 +01:00
/ship no longer reports zero blockers when the second-model review found one (GST-3075) (#4485)
When /ship stopped on a second-model review finding marked "Blocks: yes", the record it left on the PR said no blockers were found; now the finding is counted and /ship will not write that record until it is fixed or ruled. Why: `ready` and the merge step trust that record, so an undercount let a blocked PR look clean. Nothing to do: the next /ship run logs Step 11's findings and checks them before writing. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> Review-Finding: h2p1/red-team#1 reader=red-team Review-Finding: h2p1/red-team#2 reader=red-team Review-Finding: h2p1/red-team#3 reader=red-team Review-Finding: v1/outside-voice#1 reader=outside-voice
This commit is contained in:
1 parent
bbf48aa7ef
commit
07611a00a7
19 files changed
+190
-16
No files matched your search
@@ -0,0 +1,4 @@
|
||||
{
|
||||
"bytes": 613,
|
||||
"why": "GST-3075: Step 11's row logs via ship and its findings, so a voice blocker left open at a stop counts and the receipt write refuses"
|
||||
}
|
||||
Reference in new issue
Block a user