mirror of
https://github.com/garrytan/gstack.git
synced 2026-11-19 06:34:43 +01:00
/ship's changed-number check no longer stops on tests that only use the same word as a changed property: lowering `limit: 120` to `30` used to report every test that said "limit" and held 120. Why: `docs/pregate.md` already said a test counts for a word like `limit` only when it also names the changed module, but the code enforced that only for one-character values. Tests that import the module are still reported. Nothing to do. Thanks to @dtoelke, who reported this and sent the first fix in #4478. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> Co-authored-by: dtoelke <14206719+dtoelke@users.noreply.github.com>
This commit is contained in:
4 files changed
+26
-3
No files matched your search
+2
-1
@@ -268,7 +268,8 @@ Two stages with separate clocks, both printed:
|
||||
above. A `$2` in a shell stub, a comment, or `export default 2` in a fixture
|
||||
elsewhere in the file is not a consumer. A call-site name such as `attempts`
|
||||
or `limit` is an ordinary word, so for it the file must also name the changed
|
||||
module.
|
||||
module, whatever the old value's length: a test that only uses the word is not
|
||||
a consumer, and a test that imports the module still is.
|
||||
A test that keeps the old value on purpose, such as the refused input after a
|
||||
minimum version goes up, marks that one line with a comment on it or on the
|
||||
comment line directly above it:
|
||||
|
||||
Reference in new issue
Block a user