mirror of
https://github.com/garrytan/gstack.git
synced 2026-10-09 04:41:15 +02:00
test(auto-decide): ask for the selected mode in the skill's mode handoff line, not a separate public decision
This commit is contained in:
1 parent
005352ddc7
commit
0b62c51ddb
2 files changed
+3
-3
No files matched your search
@@ -87,7 +87,7 @@ mock.module(path.join(root, 'test/helpers/claude-pty-runner.ts'), () => ({
|
|||||||
// the observer must declare its audit interface before any model starts.
|
// the observer must declare its audit interface before any model starts.
|
||||||
expect(fs.readFileSync(path.join(opts.cwd, 'PLAN.md'), 'utf8')).toBe(opts.initialPlanContent);
|
expect(fs.readFileSync(path.join(opts.cwd, 'PLAN.md'), 'utf8')).toBe(opts.initialPlanContent);
|
||||||
expect(opts.initialPlanContent).toMatch(/full selected mode name[\\s\\S]*user_choice and recommended/);
|
expect(opts.initialPlanContent).toMatch(/full selected mode name[\\s\\S]*user_choice and recommended/);
|
||||||
expect(opts.initialPlanContent).toContain('public decision');
|
expect(opts.initialPlanContent).toContain("in the skill's\\nnormal mode handoff line");
|
||||||
expect(opts.initialPlanContent).toContain('No review mode has\\nbeen selected.');
|
expect(opts.initialPlanContent).toContain('No review mode has\\nbeen selected.');
|
||||||
expect(opts.initialPlanContent).not.toMatch(/HOLD SCOPE|SCOPE EXPANSION|SELECTIVE EXPANSION|SCOPE REDUCTION/);
|
expect(opts.initialPlanContent).not.toMatch(/HOLD SCOPE|SCOPE EXPANSION|SELECTIVE EXPANSION|SCOPE REDUCTION/);
|
||||||
const run = (bin, args) => execFileSync(path.join(root, 'bin', bin), args, {
|
const run = (bin, args) => execFileSync(path.join(root, 'bin', bin), args, {
|
||||||
|
|||||||
@@ -62,8 +62,8 @@ This draft is the review target, not the current branch. For this invocation,
|
|||||||
I want only the review-mode decision; I will handle optional Office Hours and
|
I want only the review-mode decision; I will handle optional Office Hours and
|
||||||
setup separately, and run the substantive review later. No review mode has
|
setup separately, and run the substantive review later. No review mode has
|
||||||
been selected. For this mode-only handoff, use the full selected mode name in
|
been selected. For this mode-only handoff, use the full selected mode name in
|
||||||
the normal audit record's user_choice and recommended fields, and name it in
|
the normal audit record's user_choice and recommended fields and in the skill's
|
||||||
your public decision. A menu letter alone would not identify the chosen mode.`;
|
normal mode handoff line. A menu letter alone would not identify the chosen mode.`;
|
||||||
|
|
||||||
describeE2E('AUTO_DECIDE opt-in preserved under Conductor flags (periodic)', () => {
|
describeE2E('AUTO_DECIDE opt-in preserved under Conductor flags (periodic)', () => {
|
||||||
test('user-opted-in question still auto-decides when AskUserQuestion is --disallowedTools', async () => {
|
test('user-opted-in question still auto-decides when AskUserQuestion is --disallowedTools', async () => {
|
||||||
|
|||||||
Reference in new issue
Block a user