From 0c66cc7862266783464f7aacc5aea53f2d7c537e Mon Sep 17 00:00:00 2001 From: garrytan Date: Mon, 2 Nov 2026 17:13:21 +0000 Subject: [PATCH] fix: pre-landing review fixes (Step 12 names the no-write kept line exactly) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --- ship/SKILL.md | 2 +- ship/SKILL.md.tmpl | 2 +- test/fixtures/golden/agy-ship-SKILL.md | 2 +- test/fixtures/golden/claude-ship-SKILL.md | 2 +- test/fixtures/golden/codex-ship-SKILL.md | 2 +- test/fixtures/golden/factory-ship-SKILL.md | 2 +- test/ship-plan-completion-invariants.test.ts | 3 ++- 7 files changed, 8 insertions(+), 7 deletions(-) diff --git a/ship/SKILL.md b/ship/SKILL.md index 127b61bf0..c735316e0 100644 --- a/ship/SKILL.md +++ b/ship/SKILL.md @@ -520,7 +520,7 @@ chooses it in item 2 and ALREADY_BUMPED derives it in item 1. runs items 1 and 3–5; each decision left to you is a `STOP:` naming its rerun flag (`--bump`, `--accept-incomplete`, `--version `, `--keep-current`, `--answer`). -`VERSION: skipped` (stamp-at-merge, fragments) or `VERSION: kept` ends Step 12 with +`VERSION: skipped` (fragments) or `VERSION: kept (…; no write)` ends Step 12 with `NEW_VERSION` unset: Step 13 follows its `NEXT:`; Steps 18 and 20 take NO_VERSION's branch. 1. **Classify state** — pure reader, never writes: diff --git a/ship/SKILL.md.tmpl b/ship/SKILL.md.tmpl index c39077c73..05d0f5537 100644 --- a/ship/SKILL.md.tmpl +++ b/ship/SKILL.md.tmpl @@ -243,7 +243,7 @@ chooses it in item 2 and ALREADY_BUMPED derives it in item 1. runs items 1 and 3–5; each decision left to you is a `STOP:` naming its rerun flag (`--bump`, `--accept-incomplete`, `--version `, `--keep-current`, `--answer`). -`VERSION: skipped` (stamp-at-merge, fragments) or `VERSION: kept` ends Step 12 with +`VERSION: skipped` (fragments) or `VERSION: kept (…; no write)` ends Step 12 with `NEW_VERSION` unset: Step 13 follows its `NEXT:`; Steps 18 and 20 take NO_VERSION's branch. 1. **Classify state** — pure reader, never writes: diff --git a/test/fixtures/golden/agy-ship-SKILL.md b/test/fixtures/golden/agy-ship-SKILL.md index 04ea780f9..dd3575a37 100644 --- a/test/fixtures/golden/agy-ship-SKILL.md +++ b/test/fixtures/golden/agy-ship-SKILL.md @@ -521,7 +521,7 @@ chooses it in item 2 and ALREADY_BUMPED derives it in item 1. runs items 1 and 3–5; each decision left to you is a `STOP:` naming its rerun flag (`--bump`, `--accept-incomplete`, `--version `, `--keep-current`, `--answer`). -`VERSION: skipped` (stamp-at-merge, fragments) or `VERSION: kept` ends Step 12 with +`VERSION: skipped` (fragments) or `VERSION: kept (…; no write)` ends Step 12 with `NEW_VERSION` unset: Step 13 follows its `NEXT:`; Steps 18 and 20 take NO_VERSION's branch. 1. **Classify state** — pure reader, never writes: diff --git a/test/fixtures/golden/claude-ship-SKILL.md b/test/fixtures/golden/claude-ship-SKILL.md index 127b61bf0..c735316e0 100644 --- a/test/fixtures/golden/claude-ship-SKILL.md +++ b/test/fixtures/golden/claude-ship-SKILL.md @@ -520,7 +520,7 @@ chooses it in item 2 and ALREADY_BUMPED derives it in item 1. runs items 1 and 3–5; each decision left to you is a `STOP:` naming its rerun flag (`--bump`, `--accept-incomplete`, `--version `, `--keep-current`, `--answer`). -`VERSION: skipped` (stamp-at-merge, fragments) or `VERSION: kept` ends Step 12 with +`VERSION: skipped` (fragments) or `VERSION: kept (…; no write)` ends Step 12 with `NEW_VERSION` unset: Step 13 follows its `NEXT:`; Steps 18 and 20 take NO_VERSION's branch. 1. **Classify state** — pure reader, never writes: diff --git a/test/fixtures/golden/codex-ship-SKILL.md b/test/fixtures/golden/codex-ship-SKILL.md index 1e1294b89..2354b068c 100644 --- a/test/fixtures/golden/codex-ship-SKILL.md +++ b/test/fixtures/golden/codex-ship-SKILL.md @@ -520,7 +520,7 @@ chooses it in item 2 and ALREADY_BUMPED derives it in item 1. runs items 1 and 3–5; each decision left to you is a `STOP:` naming its rerun flag (`--bump`, `--accept-incomplete`, `--version `, `--keep-current`, `--answer`). -`VERSION: skipped` (stamp-at-merge, fragments) or `VERSION: kept` ends Step 12 with +`VERSION: skipped` (fragments) or `VERSION: kept (…; no write)` ends Step 12 with `NEW_VERSION` unset: Step 13 follows its `NEXT:`; Steps 18 and 20 take NO_VERSION's branch. 1. **Classify state** — pure reader, never writes: diff --git a/test/fixtures/golden/factory-ship-SKILL.md b/test/fixtures/golden/factory-ship-SKILL.md index 2e2af5228..84cbf4d6b 100644 --- a/test/fixtures/golden/factory-ship-SKILL.md +++ b/test/fixtures/golden/factory-ship-SKILL.md @@ -522,7 +522,7 @@ chooses it in item 2 and ALREADY_BUMPED derives it in item 1. runs items 1 and 3–5; each decision left to you is a `STOP:` naming its rerun flag (`--bump`, `--accept-incomplete`, `--version `, `--keep-current`, `--answer`). -`VERSION: skipped` (stamp-at-merge, fragments) or `VERSION: kept` ends Step 12 with +`VERSION: skipped` (fragments) or `VERSION: kept (…; no write)` ends Step 12 with `NEW_VERSION` unset: Step 13 follows its `NEXT:`; Steps 18 and 20 take NO_VERSION's branch. 1. **Classify state** — pure reader, never writes: diff --git a/test/ship-plan-completion-invariants.test.ts b/test/ship-plan-completion-invariants.test.ts index 8a0a769a9..4a292edd4 100644 --- a/test/ship-plan-completion-invariants.test.ts +++ b/test/ship-plan-completion-invariants.test.ts @@ -196,7 +196,8 @@ describe('ship/SKILL.md — Plan Completion gate invariants', () => { const version = entry.slice(entry.indexOf('## Step 12:'), entry.indexOf('1. **Classify state**')).replace(/\s+/g, ' '); expect(version).not.toContain('replaces items 1–4'); expect(version).toContain('`VERSION: skipped`'); - expect(version).toContain('`VERSION: kept` ends Step 12 with `NEW_VERSION` unset'); + expect(version).toContain('`VERSION: kept (…; no write)` ends Step 12 with `NEW_VERSION` unset'); + expect(version).toContain('ALREADY_BUMPED derives it in item 1'); expect(version).toContain("Steps 18 and 20 take NO_VERSION's branch"); });