From 0c9eb8048c7d167a064ac191135dbc85f3519601 Mon Sep 17 00:00:00 2001 From: garrytan Date: Sat, 31 Oct 2026 18:58:07 +0000 Subject: [PATCH] fix(windows): doctor launches its Git Bash probe without MSYS_NO_PATHCONV so the #3468 warning can show Windows CI run 41230328769 shard 1 failed the new doctor test: with MSYS_NO_PATHCONV=1 exported, the probe's own bun launch got an unconverted /tmp path (Module not found), so the row said 'not checked' instead of the warning. Unset it for that one launch. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --- bin/gstack-doctor | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/gstack-doctor b/bin/gstack-doctor index 3613979e7..d787f5435 100755 --- a/bin/gstack-doctor +++ b/bin/gstack-doctor @@ -520,7 +520,7 @@ check_windows_bash() { row warn "windows bash" "not checked: bun not found" "install Bun (see the bun row), then rerun $BIN/gstack-doctor" return fi - out=$(bun --no-env-file --config="${GSTACK_BUN_CONFIG:-/dev/null}" "$BIN/gstack-windows-bash.ts" ${GSTACK_DOCTOR_BASH_PROBE:+--probe "$GSTACK_DOCTOR_BASH_PROBE"} &1) + out=$(unset MSYS_NO_PATHCONV; bun --no-env-file --config="${GSTACK_BUN_CONFIG:-/dev/null}" "$BIN/gstack-windows-bash.ts" ${GSTACK_DOCTOR_BASH_PROBE:+--probe "$GSTACK_DOCTOR_BASH_PROBE"} &1) rc=$? out=$(printf '%s\n' "$out" | tr -d '\000-\010\013-\037') bash=$(printf '%s\n' "$out" | sed -n 's/^WINDOWS_BASH: //p' | head -1)