From 10eac648baab7f1a5e1b8d7a00ebfbcb25b7e5e9 Mon Sep 17 00:00:00 2001 From: garrytan Date: Sat, 3 Oct 2026 21:25:46 +0000 Subject: [PATCH] E8: count the BROWSE_EXTENSIONS_DIR persistent launch in the signal-flags guard The new launch site carries handleSIGINT/SIGTERM/SIGHUP false like the other three, so the guard's expected count moves from 3 to 4. --- browse/test/launch-signal-flags.test.ts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/browse/test/launch-signal-flags.test.ts b/browse/test/launch-signal-flags.test.ts index 2a26fa4bc..de4f2920c 100644 --- a/browse/test/launch-signal-flags.test.ts +++ b/browse/test/launch-signal-flags.test.ts @@ -51,10 +51,11 @@ describe('Playwright launch sites disable signal handlers (#2220)', () => { const src = SRC('browser-manager.ts'); const launchCount = expectSignalFlagsNearEvery(src, 'chromium.launch({'); const persistentCount = expectSignalFlagsNearEvery(src, 'chromium.launchPersistentContext('); - // Three launch sites today: headless launch(), headed launchHeaded(), - // and the handoff relaunch. A NEW launch site must carry the flags too — - // bump this only after adding them. - expect(launchCount + persistentCount).toBe(3); + // Four launch sites today: headless launch(), its BROWSE_EXTENSIONS_DIR + // persistent context (#2281), headed launchHeaded(), and the handoff + // relaunch. A NEW launch site must carry the flags too — bump this only + // after adding them. + expect(launchCount + persistentCount).toBe(4); }); test('server.ts owns SIGHUP cleanup now that Playwright does not (ENG-OV4)', () => {