v1.58.5.0 feat: first-run activation scaffold + gstack router front door (#2078)

* feat: first-run activation — project-aware scaffold, router front door, onboarding nudges

Adds the activation system that drives a new install toward a concrete first move:
- bin/gstack-first-task-detect: local-git+filesystem repo classifier emitting one
  validated enum bucket (greenfield/code_<lang>/branch_ahead/dirty_default/clean_default),
  portable timeouts, fail-safe empty output.
- generate-first-run-guidance.ts: unified preamble section — first-run project-aware
  scaffold + returning-session plan->review->ship tip, gated on a persistent .activated
  marker and never run in headless. Detection wired lazily in generate-preamble-bash.ts.
- SKILL.md.tmpl: top-level gstack skill is now a pure router (browse body removed; it
  lives in /browse), routing any request and sending browser/QA work to /browse.
- setup: first-move nudge on first install. office-hours: closing handoff that launches
  the next review via the Skill tool.
- telemetry-ingest: accept onboarding/first_task_scaffold_shown/handoff/route event types.

* test: cover first-run detection + repoint browse-content assertions to /browse

- New unit tests for every detection bucket, the eval-safe enum contract, and the
  first-run gating (test/preamble-first-task-scaffold.test.ts); periodic E2E that runs
  the detector through the real harness (test/skill-e2e-first-task-scaffold.test.ts).
- Repoint browse-content assertions (gen-skill-docs, audit-compliance, skill-validation,
  LLM-judge eval) from the root skill to browse/SKILL.md following the router split;
  add a regression pinning that the router carries no browse body.
- Register first-task-scaffold touchfiles + periodic tier; bump parity/carve size caps
  ~1-2KB per skill for the shared first-run-guidance preamble section.
- Refresh ship golden fixtures for the preamble addition.

* chore: regenerate SKILL.md + llms.txt for first-run activation

* chore: bump version and changelog (v1.58.5.0)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(test): repoint bws skillmd-* setup-block assertions to browse/SKILL.md

The skillmd-setup-discovery / -no-local-binary / -outside-git E2E tests extracted
the `## SETUP`→`## IMPORTANT` browse binary-discovery block from the root SKILL.md.
P2 moved that block to browse/SKILL.md (end anchor is now `## Core QA Patterns`),
so the slice came back empty and the `browse/dist/browse` guard failed. Repoint to
browse/SKILL.md. Verified: 7/7 e2e-browse pass locally.

* fix(test): tolerate skill-discovery race in PTY plan-mode smoke

The e2e-pty-plan-smoke suite (office-hours / plan-mode-no-op) failed in CI with
`Unknown command: /office-hours` (claude exited ~10s) while passing locally. Root
cause: a cold CI container's overlay-FS scan of the symlinked ~/.claude/skills
registry finishes AFTER the runner's 8s boot grace, so the first `/skill` send
reaches claude before the skill is indexed and is rejected as unknown. The runner
gave up on the first "Unknown command:" line.

runPlanSkillObservation now re-sends the skill command up to 3x (6s apart),
re-marking the buffer each time so stale scrollback can't re-trip the check,
before concluding the skill is genuinely unregistered. A real dangling-symlink /
missing-skill still surfaces as 'exited' (after retries), preserving the original
diagnostic. Pure-helper contract unchanged: 95/95 unit tests pass.

This is a pre-existing harness bug (fails identically on #2077's own branch, which
introduced the suite) surfaced while shipping the activation feature.

* debug(ci): temporarily instrument pty-smoke skill discovery

Capture claude version, env, registry tree, and a claude -p discovery probe to
pin why /office-hours isn't discovered in CI (retries proved it's not a race).
Temporary — revert once the registry fix is identified.

* chore: revert pty-smoke harness experiments (race-retry + CI debug step)

Diagnosis is conclusive and the experiments aren't the fix, so restore the
harness to its original state (net-zero diff vs main for both files).

What the CI debug step proved: `claude -p` returns READY — claude v2.1.187 fully
DISCOVERS /office-hours from the symlinked registry. Only the interactive PTY TUI
rejects it as "Unknown command" (and it received the full command text). So the
e2e-pty-plan-smoke failure is a claude 2.1.187 interactive-TUI regression (skills
discovered by `claude -p` aren't exposed as TUI slash commands), pre-existing in
the #2077 harness and failing identically on its own origin branch — unrelated to
this activation PR. The race-retry can't help (the TUI genuinely lacks the
command); the debug step also tripped actionlint (shellcheck SC2012). Both reverted.

* fix(ci): copy SKILL.md as real files in pty-smoke registry (cross-mount symlink)

The e2e-pty-plan-smoke suite failed with "Unknown command: /office-hours" in CI
while passing locally. Root cause (proven, not guessed): claude 2.1.187's
interactive-TUI skill scanner does not follow the /github/home -> /__w cross-mount
symlink the registry used for per-skill SKILL.md. Evidence: a CI debug step showed
`claude -p` discovered the skill (printed READY), and a local macOS repro with the
identical symlinked registry recognized /office-hours — isolating the failure to
the container's cross-mount symlink, not registration content, claude version,
duplicate names, or a race.

Fix: register the per-skill SKILL.md + sections as REAL copies (same mount as
$HOME) so the TUI reads them directly. The gstack root stays a symlink — the
preamble's runtime bash resolves bin/* and sections/* through it and bash follows
cross-mount symlinks fine.

* fix(ci): guard rm expansion in pty-smoke registry (shellcheck SC2115)

* fix(ci): also register pty-smoke skills project-scoped (cwd/.claude/skills)

The real-file user-dir registration still left the TUI rejecting /office-hours in
the container. claude's interactive TUI surfaces /slash commands from the PROJECT
dir (<cwd>/.claude/skills); the smokes run with cwd=$REPO whose .claude/skills is
gitignored (absent on a fresh CI checkout), so the user-dir registry feeds
`claude -p` (READY) but not the TUI. Populate $REPO/.claude/skills with real
SKILL.md + sections copies (no gstack symlink there — it would point at its own
parent; runtime paths use the user-dir gstack symlink).

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-06-25 09:42:45 -07:00
committed by GitHub
parent 9fd03fae9e
commit 11de390be1
77 changed files with 2292 additions and 762 deletions
+105
View File
@@ -0,0 +1,105 @@
#!/usr/bin/env bash
# gstack-first-task-detect — classify the current project into ONE first-task
# bucket so the first-run scaffold can suggest a concrete next skill.
#
# Contract (load-bearing — the preamble eval's nothing but a single token):
# - Prints EXACTLY ONE whitelisted enum token to stdout, or nothing.
# - Never hangs: every git call is wrapped in a portable 2s timeout.
# - Never errors out of the caller: best-effort, fail-safe to no output.
# - Local git + filesystem only. NO network (no gh/glab) — this runs in the
# latency-sensitive skill preamble.
#
# Enum tokens (the ONLY strings this ever emits):
# greenfield | code_node | code_python | code_rust | code_go | code_ruby
# | code_ios | branch_ahead | dirty_default | clean_default | nongit
#
# The caller maps the token to human prose; no description text crosses the
# eval boundary. Usage: TOKEN=$(gstack-first-task-detect)
set -uo pipefail
# --- Portable timeout wrapper (gtimeout → timeout → unwrapped), per gstack-codex-probe ---
_ftd_to=$(command -v gtimeout 2>/dev/null || command -v timeout 2>/dev/null || echo "")
_git() {
if [ -n "$_ftd_to" ]; then
"$_ftd_to" 2 git "$@" 2>/dev/null
else
git "$@" 2>/dev/null
fi
}
# Emit only whitelisted tokens — defense in depth even though every emit site
# below is a literal.
_emit() {
case "$1" in
greenfield|code_node|code_python|code_rust|code_go|code_ruby|code_ios|branch_ahead|dirty_default|clean_default|nongit)
printf '%s\n' "$1" ;;
*) : ;; # unknown → emit nothing (caller shows no scaffold)
esac
exit 0
}
# --- 1. Not a git repo → nothing actionable from git, but language may still help ---
if ! _git rev-parse --is-inside-work-tree | grep -q true; then
_emit nongit
fi
# --- 2. Greenfield (no commits) ---
_commits=$(_git rev-list --count HEAD || echo 0)
[ -z "$_commits" ] && _commits=0
if [ "$_commits" -eq 0 ] 2>/dev/null; then
_emit greenfield
fi
# --- 3. Resolve default + current branch (reuse the repo's base-branch fallback) ---
_default=$(_git symbolic-ref refs/remotes/origin/HEAD | sed 's|refs/remotes/origin/||')
if [ -z "$_default" ]; then
if _git rev-parse --verify origin/main >/dev/null; then _default=main
elif _git rev-parse --verify origin/master >/dev/null; then _default=master
else _default=main
fi
fi
_current=$(_git rev-parse --abbrev-ref HEAD || echo "")
# --- 4. On a feature branch ahead of base (local-only) → ready to review/ship ---
if [ -n "$_current" ] && [ "$_current" != "$_default" ] && [ "$_current" != "HEAD" ]; then
# ahead-count vs the REAL base: prefer origin/<default> (the remote truth);
# a stale local <default> would falsely inflate the ahead count.
_base=""
if _git rev-parse --verify "origin/$_default" >/dev/null; then _base="origin/$_default"
elif _git rev-parse --verify "$_default" >/dev/null; then _base="$_default"
fi
if [ -n "$_base" ]; then
_ahead=$(_git rev-list --count "$_base..HEAD" || echo 0)
[ -z "$_ahead" ] && _ahead=0
if [ "$_ahead" -gt 0 ] 2>/dev/null; then
_emit branch_ahead
fi
fi
fi
# --- 5. Uncommitted changes on the default branch → review + commit ---
_dirty=$(_git status --porcelain | head -1)
if [ -n "$_dirty" ] && { [ "$_current" = "$_default" ] || [ "$_current" = "HEAD" ] || [ -z "$_current" ]; }; then
_emit dirty_default
fi
# --- 6. Has code + a recognized language marker → verify tests/build ---
# Resolve to the repo root first so a skill invoked from a subdir doesn't miss
# a root-level package.json / Cargo.toml / etc. Filesystem-only after this.
_TOP=$(_git rev-parse --show-toplevel)
[ -n "$_TOP" ] && cd "$_TOP" 2>/dev/null || true
# Order by specificity/likelihood; stop at first match.
if [ -f package.json ]; then _emit code_node; fi
if [ -f pyproject.toml ] || [ -f setup.py ] || [ -f requirements.txt ]; then _emit code_python; fi
if [ -f Cargo.toml ]; then _emit code_rust; fi
if [ -f go.mod ]; then _emit code_go; fi
if [ -f Gemfile ]; then _emit code_ruby; fi
if ls ./*.xcodeproj >/dev/null 2>&1 || [ -d ios ]; then _emit code_ios; fi
# --- 7. Clean default branch with history, no recognized language → pick something ---
if [ "$_commits" -ge 5 ] 2>/dev/null; then
_emit clean_default
fi
# Nothing confidently actionable → emit nothing (no scaffold).
exit 0