CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-09-01 19:00:40 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(test): landscape --toc gate asserts promotion PRESENCE, not counts

Browse Source 
Two rounds of CI receipts: the exact toBe(3) was font-metric-coupled
(3 on Amazon Linux, 2 on ubuntu), and the baseline-comparison repair
then failed 2-vs-3 across renders SECONDS apart in one CI job while the
sibling no-toc test saw 3 — per-render image-promotion timing makes any
count assertion here a coin flip. The sibling test owns exact promotion
counts; this test's actual invariant is that --toc does not break the
promotion machinery: >=1 landscape page + the TOC rendered. Also drops
the second render (halves the test's runtime).

Flaky per-render image promotion itself is worth its own look — noted
in TODOS with these receipts.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Test
2026-08-29 08:28:58 +00:00
co-authored by Claude Fable 5
parent c49b2ece15
commit 13bd9c2ac1
1 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
make-pdf/test/e2e/landscape-gate.test.ts
+9 -10
View File
@@ -111,19 +111,18 @@ describe("landscape promotion gate", () => {
if (!avail.ok) return;
const workDir = fs.mkdtempSync("/tmp/make-pdf-landscape-toc-");
const outputPdf = path.join(workDir, "out.pdf");
const baselinePdf = path.join(workDir, "baseline.pdf");
try {
// Comparative invariant, not an exact count: whether a wide table
// spills onto an extra landscape page depends on font metrics (the
// fixed `toBe(3)` passed on Amazon Linux and failed on ubuntu CI with
// 2 — the same disease the page-index comment above warns about).
// What --toc must not do is CHANGE the landscape promotion outcome.
generate([], baselinePdf);
const baselineLandscape = pageBoxes(baselinePdf).filter(isLandscape).length;
expect(baselineLandscape).toBeGreaterThanOrEqual(1);
// Presence, not a count: exact landscape-page counts are coupled to
// BOTH font-metric pagination (toBe(3) passed on Amazon Linux, failed
// ubuntu CI with 2) AND per-render image-promotion timing (a baseline
// comparison then failed with 2-vs-3 on renders seconds apart in the
// same CI job, while the sibling no-toc test saw 3). The sibling test
// owns exact promotion counts; THIS test's invariant is that --toc
// does not break the promotion machinery: landscape pages still
// exist, and the TOC rendered.
generate(["--toc"], outputPdf);
const boxes = pageBoxes(outputPdf);
expect(boxes.filter(isLandscape).length).toBe(baselineLandscape);
expect(boxes.filter(isLandscape).length).toBeGreaterThanOrEqual(1);
const pdftotext = resolvePopplerTool("pdftotext")!;
const text = execFileSync(pdftotext, [outputPdf, "-"], { encoding: "utf8", timeout: CHILD_TIMEOUT_MS });