CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-09-11 07:29:00 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: pre-landing review fixes

Browse Source 
Testing-specialist findings, all mechanical: (1) pin the E2E fixture's git
branch (-b main / init.defaultBranch=main) and assert every setup command's
exit status so operator git config can't silently corrupt a paid run;
(2) tighten the dispatch matcher to Step 18-prompt-specific markers
(document-release/SKILL.md | executing the /document-release workflow) so a
subagent merely quoting section text can't false-pass the regression assert
(verified against recorded burn-in transcripts); (3) replace the subsumed
carve-guards anchor with three non-overlapping per-touchpoint anchors
(gerund/imperative/3rd-person) so each touchpoint is independently enforced.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-08-26 15:32:55 +00:00
co-authored by Claude Fable 5
parent 62cdb0811c
commit 14ee421fb1
2 changed files with 42 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/helpers/carve-guards.ts
+8 -5
View File
@@ -118,17 +118,20 @@ export const CARVE_GUARDS: Record<string, CarveGuard> = {
// (CI backstop: test/pr-title-sync-workflow-safety.test.ts).
// Same carve also stranded the Step 18 /document-release dispatch out of
// sight — the skeleton never named it and the handoff "got lost" (#2666
// follow-up). The two subagent anchors pin the restored visibility:
// 'the /document-release subagent' matches all three touchpoints (trigger
// via section-index + STOP pointer, Step 17 handoff, hoisted invariant);
// 'dispatches the /document-release subagent' pins the invariant itself.
// follow-up). Three NON-OVERLAPPING anchors pin the restored visibility,
// one per touchpoint (no anchor is a substring of another, so each is
// independently enforced — a subsumed anchor adds zero enforcement):
// gerund form → manifest trigger (renders 2x: section index + STOP)
// imperative → Step 17 handoff line
// 3rd person → hoisted doc-sync invariant
// Matching is case-sensitive String.includes — "dispatching the" does NOT
// contain "dispatch the" — so update anchors in lockstep with any
// touchpoint rewording.
mustStayInSkeleton: [
'v$NEW_VERSION',
'gstack-pr-title-rewrite',
'the /document-release subagent',
'dispatching the /document-release subagent to sync docs',
'dispatch the /document-release subagent to sync docs',
'dispatches the /document-release subagent',
],
// ...while the full create/update procedure stays carved into pr-body.md