CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-09-20 03:42:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge origin/main (v1.64.1.0 code-smell wave) into test-evals-ci-speedup

Browse Source 
Both sides shipped overlapping test-infra work in parallel; resolutions
compose intent rather than picking sides:

- free-tests.yml (both added): keep this branch's lane (canonical
  strict-parallel runner, secretless, plain runner, ~2min) over main's
  per-file-serial container loop (45min budget, hand-curated skip list,
  needs GITHUB_TOKEN); ported main's git safe.directory insight.
- Dockerfile.ci Bun install: main discovered the installer IGNORES the
  BUN_VERSION env var (the old form silently installed latest) — main's
  arg-form mechanism + this branch's 1.3.13 target.
- parity baseline: both sides rebased after hitting the same silent
  drift; adopted main's v1.64.1.0 union-normalized fixture and dropped
  this branch's interim v1.64.0.0 capture. carve-guards caps: main's
  tighter re-ratchets win (all four).
- touchfiles: kept this branch's three-file facade split; ported main's
  pure-data removals (dead sidebar-agent entries, spec judge entry,
  ship-idempotency) into touchfiles-data.ts.
- ship-idempotency SDK variant: main deliberately removed it as
  redundant with the real-PTY test; adopted — dropped this branch's
  rehomed copy and its periodic matrix row (the zombie-monolith deletion
  stands; coverage-audit + triage rehomes verified untouched by main).
- e2e-tier-alignment: taught the new parent-mapper hard check main's
  consolidated describeE2ETier()/e2eTierEnabled() self-gate shapes (the
  helper's header names this file as a required recognizer).
- browse/test/compare-board.test.ts: quarantined behind
  GSTACK_COMPARE_BOARD_TESTS=1 — all 16 tests fail identically on
  origin/main solo on dev machines (blame protocol receipts in-file);
  main's own CI lane skip-lists it. An always-red file would block every
  PR now that free-tests is a required check.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-08-15 10:29:25 -07:00
co-authored by Claude Fable 5
parent 3f85810b9f c118e2402e
commit 1749ac8cc8
192 changed files with 2371 additions and 22872 deletions
Download Patch File Download Diff File Expand all files Collapse all files
browse/test/commands.test.ts
+45 -28
View File
@@ -12,6 +12,7 @@ import { resolveServerScript } from '../src/cli';
import { handleReadCommand as _handleReadCommand, parseOutArgs, hasOutArg, resultToString } from '../src/read-commands';
import { handleWriteCommand as _handleWriteCommand } from '../src/write-commands';
import { handleMetaCommand } from '../src/meta-commands';
import { WRITE_COMMANDS, READ_COMMANDS, META_COMMANDS, PAGE_CONTENT_COMMANDS, wrapUntrustedContent } from '../src/commands';
import { consoleBuffer, networkBuffer, dialogBuffer, addConsoleEntry, addNetworkEntry, addDialogEntry, CircularBuffer } from '../src/buffers';
import * as fs from 'fs';
import { spawn } from 'child_process';
@@ -19,10 +20,41 @@ import * as path from 'path';
// Thin wrappers that bridge old test calls (bm as 3rd arg) to new signatures (session + bm)
const handleReadCommand = (cmd: string, args: string[], b: BrowserManager) =>
_handleReadCommand(cmd, args, b.getActiveSession());
_handleReadCommand(cmd, args, b.getActiveSession(), b);
const handleWriteCommand = (cmd: string, args: string[], b: BrowserManager) =>
_handleWriteCommand(cmd, args, b.getActiveSession(), b);
// Chain routes every subcommand through the server's executeCommand pipeline in
// production (the direct-dispatch fallback was deleted — it skipped the security
// gates). Tests mirror the pipeline minimally: real handlers + trust-wrapping,
// server-shaped {status, result} envelope.
function makeChainExecute(b: BrowserManager) {
return async (body: { command: string; args?: string[] }) => {
const name = body.command;
const args = body.args ?? [];
try {
let result: string;
if (WRITE_COMMANDS.has(name)) {
result = await _handleWriteCommand(name, args, b.getActiveSession(), b);
} else if (READ_COMMANDS.has(name)) {
result = await _handleReadCommand(name, args, b.getActiveSession(), b);
if (PAGE_CONTENT_COMMANDS.has(name)) {
result = wrapUntrustedContent(result, b.getCurrentUrl());
}
} else if (META_COMMANDS.has(name)) {
result = await handleMetaCommand(name, args, b, async () => {});
} else {
return { status: 404, result: JSON.stringify({ error: `Unknown command: ${name}` }) };
}
return { status: 200, result };
} catch (err: any) {
return { status: 500, result: JSON.stringify({ error: err.message }) };
}
};
}
const chainMeta = (b: BrowserManager, args: string[]) =>
handleMetaCommand('chain', args, b, async () => {}, null, { executeCommand: makeChainExecute(b) });
// ─── Pure arg-parser + result-conversion unit tests (no browser) ───
describe('parseOutArgs / hasOutArg', () => {
test('--out <path> splits the flag from the positional', () => {
@@ -807,7 +839,7 @@ describe('Chain', () => {
['js', 'document.title'],
['css', 'h1', 'color'],
]);
const result = await handleMetaCommand('chain', [commands], bm, async () => {});
const result = await chainMeta(bm, [commands]);
expect(result).toContain('[goto]');
expect(result).toContain('Test Page - Basic');
expect(result).toContain('[css]');
@@ -815,7 +847,7 @@ describe('Chain', () => {
test('chain wraps page-content sub-commands with trust markers', async () => {
await handleWriteCommand('goto', [baseUrl + '/basic.html'], bm);
const result = await handleMetaCommand('chain', ['text'], bm, async () => {});
const result = await chainMeta(bm, ['text']);
expect(result).toContain('BEGIN UNTRUSTED EXTERNAL CONTENT');
expect(result).toContain('END UNTRUSTED EXTERNAL CONTENT');
});
@@ -824,7 +856,7 @@ describe('Chain', () => {
const commands = JSON.stringify([
['goto', 'http://localhost:1/unreachable'],
]);
const result = await handleMetaCommand('chain', [commands], bm, async () => {});
const result = await chainMeta(bm, [commands]);
expect(result).toContain('[goto] ERROR:');
expect(result).not.toContain('Unknown meta command');
expect(result).not.toContain('Unknown read command');
@@ -1511,14 +1543,14 @@ describe('Errors', () => {
test('chain with invalid JSON falls back to pipe format', async () => {
// Non-JSON input is now treated as pipe-delimited format
// 'not json' → [["not", "json"]] → "not" is unknown command → error in result
const result = await handleMetaCommand('chain', ['not json'], bm, async () => {});
const result = await chainMeta(bm, ['not json']);
expect(result).toContain('ERROR');
expect(result).toContain('Unknown command: not');
});
test('chain with no arg throws', async () => {
try {
await handleMetaCommand('chain', [], bm, async () => {});
await chainMeta(bm, []);
expect(true).toBe(false);
} catch (err: any) {
expect(err.message).toContain('Usage');
@@ -2012,7 +2044,7 @@ describe('Chain with cookie-import', () => {
const commands = JSON.stringify([
['cookie-import', tmpCookies],
]);
const result = await handleMetaCommand('chain', [commands], bm, async () => {});
const result = await chainMeta(bm, [commands]);
expect(result).toContain('[cookie-import]');
expect(result).toContain('Loaded 1 cookie');
} finally {
@@ -2057,24 +2089,14 @@ describe('Network idle', () => {
describe('Chain pipe format', () => {
test('pipe-delimited commands work', async () => {
const result = await handleMetaCommand(
'chain',
[`goto ${baseUrl}/basic.html | js document.title`],
bm,
async () => {}
);
const result = await chainMeta(bm, [`goto ${baseUrl}/basic.html | js document.title`]);
expect(result).toContain('[goto]');
expect(result).toContain('[js]');
expect(result).toContain('Test Page - Basic');
});
test('pipe format with quoted args', async () => {
const result = await handleMetaCommand(
'chain',
[`goto ${baseUrl}/forms.html | fill #email "pipe@test.com"`],
bm,
async () => {}
);
const result = await chainMeta(bm, [`goto ${baseUrl}/forms.html | fill #email "pipe@test.com"`]);
expect(result).toContain('[fill]');
expect(result).toContain('Filled');
// Verify the fill actually worked
@@ -2087,18 +2109,13 @@ describe('Chain pipe format', () => {
['goto', baseUrl + '/basic.html'],
['js', 'document.title'],
]);
const result = await handleMetaCommand('chain', [commands], bm, async () => {});
const result = await chainMeta(bm, [commands]);
expect(result).toContain('[goto]');
expect(result).toContain('Test Page - Basic');
});
test('pipe format with unknown command includes error', async () => {
const result = await handleMetaCommand(
'chain',
['bogus command'],
bm,
async () => {}
);
const result = await chainMeta(bm, ['bogus command']);
expect(result).toContain('ERROR');
expect(result).toContain('Unknown command: bogus');
});
@@ -2588,14 +2605,14 @@ describe('Command aliases', () => {
test('setcontent alias routes to load-html via chain', async () => {
// Chain canonicalizes aliases end-to-end; verifies the dispatch path
const result = await handleMetaCommand('chain', [JSON.stringify([['setcontent', aliasFix]])], bm, async () => {});
const result = await chainMeta(bm, [JSON.stringify([['setcontent', aliasFix]])]);
expect(result).toContain('Loaded HTML:');
const text = await handleReadCommand('text', [], bm);
expect(text).toContain('alias routing ok');
});
test('set-content (hyphenated) alias also routes', async () => {
const result = await handleMetaCommand('chain', [JSON.stringify([['set-content', aliasFix]])], bm, async () => {});
const result = await chainMeta(bm, [JSON.stringify([['set-content', aliasFix]])]);
expect(result).toContain('Loaded HTML:');
});
});