CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-09-16 18:05:31 +02:00
Code Issues Packages Projects Releases Wiki Activity

test: repin ~70 assertions to the script contract — every literal gets a successor

Browse Source 
Assertions that pinned inline-bash internals (update-check guard, _SESSIONS
reaping, telemetry start/end blocks, routing probe, repo-strip producer,
first-task gating, EXPLAIN_LEVEL/QUESTION_TUNING echoes, #2499 jq scope
resolution, Issue-8 CONDUCTOR gate) now pin the same invariants in their new
home: bin/gstack-skill-start / bin/gstack-skill-end file content for script
internals, the invocation fence + interpretation prose for render-side
behavior. No assertion deleted without a successor; live-execution tests
(routing probe, brain-sync jq) run against script bytes unchanged.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-08-25 15:37:00 +00:00
co-authored by Claude Fable 5
parent eb1607aaf8
commit 17bebe33ab
9 changed files with 280 additions and 109 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/audit-compliance.test.ts
+36 -15
View File
@@ -35,25 +35,30 @@ describe('Audit compliance', () => {
// Fix 2: Conditional telemetry — binary calls wrapped with existence check
test('preamble telemetry calls are conditional on _TEL and binary existence', () => {
// After the preamble.ts refactor (Item 9), the bash/telemetry logic lives
// in submodules under scripts/resolvers/preamble/. Concatenate all preamble
// source (root + submodules) and assert against the combined text so this
// test tracks the semantic contract, not the file layout.
// Token-reduction Phase 1: the preamble's telemetry bash moved from the
// resolvers into bin/gstack-skill-start (pending finalization) and
// bin/gstack-skill-end (end-of-skill telemetry). Assert the semantic
// contract against the scripts — the new home of the calls.
const skillStart = readFileSync(join(ROOT, 'bin/gstack-skill-start'), 'utf-8');
// Pending finalization must check _TEL and binary existence
expect(skillStart).toContain('_TEL" != "off"');
expect(skillStart).toContain('-x ');
expect(skillStart).toContain('gstack-telemetry-log');
// End-of-skill telemetry (gstack-skill-end) must also be conditional
const skillEnd = readFileSync(join(ROOT, 'bin/gstack-skill-end'), 'utf-8');
expect(skillEnd).toContain('_TEL" != "off"');
expect(skillEnd).toContain('-x ');
expect(skillEnd).toContain('gstack-telemetry-log');
// The render-side epilogue prose survives in the resolvers and hands off
// to gstack-skill-end.
const preambleDir = join(ROOT, 'scripts/resolvers/preamble');
const submoduleFiles = existsSync(preambleDir)
? readdirSync(preambleDir).filter(f => f.endsWith('.ts')).map(f => readFileSync(join(preambleDir, f), 'utf-8'))
: [];
const rootPreamble = readFileSync(join(ROOT, 'scripts/resolvers/preamble.ts'), 'utf-8');
const preamble = [rootPreamble, ...submoduleFiles].join('\n');
// Pending finalization must check _TEL and binary existence
expect(preamble).toContain('_TEL" != "off"');
expect(preamble).toContain('-x ');
expect(preamble).toContain('gstack-telemetry-log');
// End-of-skill telemetry must also be conditional
const preamble = submoduleFiles.join('\n');
const completionIdx = preamble.indexOf('Telemetry (run last)');
expect(completionIdx).toBeGreaterThan(-1);
const completionSection = preamble.slice(completionIdx);
expect(completionSection).toContain('_TEL" != "off"');
expect(preamble.slice(completionIdx)).toContain('gstack-skill-end');
});
// Round 2 Fix 1: W012 — Bun install uses checksum verification
@@ -111,11 +116,27 @@ describe('Audit compliance', () => {
// Round 2 Fix 4: Chrome CDP binds to localhost only
// Fix 2+6: All generated SKILL.md files with telemetry are conditional
test('all generated SKILL.md files with telemetry calls use conditional pattern', () => {
// Phase 1 moved the _TEL-gated bash into the scripts. Render-side
// gstack-telemetry-log calls (route + first-task events) rely on two
// layers instead: every call line is best-effort (`|| true`), and the
// binary itself no-ops when the telemetry tier is off.
const telLog = readFileSync(join(ROOT, 'bin/gstack-telemetry-log'), 'utf-8');
expect(telLog).toContain('if [ "$TIER" = "off" ]');
expect(telLog).toMatch(/if \[ "\$TIER" = "off" \][\s\S]{0,200}?exit 0/);
const skills = getAllSkillMds();
let checked = 0;
for (const { name, content } of skills) {
if (content.includes('gstack-telemetry-log')) {
expect(content).toContain('_TEL" != "off"');
for (const line of content.split('\n')) {
if (!line.includes('gstack-telemetry-log')) continue;
// Prose mentions aren't calls; only executable lines invoke the binary.
if (!line.includes('bin/gstack-telemetry-log')) continue;
checked++;
expect(line, `${name}: telemetry call must be best-effort`).toContain('|| true');
expect(line, `${name}: telemetry call must not surface errors`).toContain('2>/dev/null');
}
}
// Guard against the scan silently matching nothing.
expect(checked).toBeGreaterThan(0);
});
});