From 1d709be35e041cdf5564b7d68246af7bbd3c9802 Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Sun, 22 Mar 2026 10:04:54 -0700 Subject: [PATCH] fix: move {{CODEX_PLAN_REVIEW}} after review sections in eng review Codex adversarial review caught that the placeholder was positioned before the 4 review sections, so the "After all review sections are complete" instruction could confuse the model. Moved it after Section 4's STOP directive where it belongs. Co-Authored-By: Claude Opus 4.6 (1M context) --- plan-eng-review/SKILL.md.tmpl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plan-eng-review/SKILL.md.tmpl b/plan-eng-review/SKILL.md.tmpl index f28ea932..f8936775 100644 --- a/plan-eng-review/SKILL.md.tmpl +++ b/plan-eng-review/SKILL.md.tmpl @@ -96,8 +96,6 @@ Before reviewing anything, answer these questions: If the complexity check triggers (8+ files or 2+ new classes/services), proactively recommend scope reduction via AskUserQuestion — explain what's overbuilt, propose a minimal version that achieves the core goal, and ask whether to reduce or proceed as-is. If the complexity check does not trigger, present your Step 0 findings and proceed directly to Section 1. -{{CODEX_PLAN_REVIEW}} - Always work through the full interactive review: one section at a time (Architecture → Code Quality → Tests → Performance) with at most 8 top issues per section. **Critical: Once the user accepts or rejects a scope reduction recommendation, commit fully.** Do not re-argue for smaller scope during later review sections. Do not silently reduce scope or skip planned components. @@ -176,6 +174,8 @@ Evaluate: **STOP.** For each issue found in this section, call AskUserQuestion individually. One issue per call. Present options, state your recommendation, explain WHY. Do NOT batch multiple issues into one AskUserQuestion. Only proceed to the next section after ALL issues in this section are resolved. +{{CODEX_PLAN_REVIEW}} + ## CRITICAL RULE — How to ask questions Follow the AskUserQuestion format from the Preamble above. Additional rules for plan reviews: * **One issue = one AskUserQuestion call.** Never combine multiple issues into one question.