From 1f3e19209846be6fdd8eedaf3c945deda6381b51 Mon Sep 17 00:00:00 2001 From: garrytan Date: Sat, 3 Oct 2026 01:48:49 +0000 Subject: [PATCH] test(W7h): drop the no-op review-report check from setup-gbrain-remote W7h retirement (t12 F9) of one assertion in the paid setup-gbrain-remote case. No registration changes (the case stays). Retirement card: - assertion: `expect(/## GSTACK REVIEW REPORT|critical_gaps/i .test(result.output)).toBe(false)` with its comment. - detects: /setup-gbrain writing a plan-review report or critical_gaps findings, which it never produces; the removed comment itself said "Setup-gbrain doesn't have a review report contract". Copied from the plan-review tests (c118e24, #2572). - non_test_callers: none. - replacement: none needed; `grep -rln "PLAN_FILE_REVIEW_REPORT\|GSTACK REVIEW REPORT\|critical_gaps" setup-gbrain/*.tmpl setup-gbrain/sections/*.tmpl` is empty, so there is no behavior to control. The case's real contracts stay: the secret token never reaches CLAUDE.md, `mcp add ... --transport http`, and `Mode: remote-http` (read by bin/gstack-gbrain-detect). - validation: bun test test/skill-e2e-setup-gbrain-remote.test.ts (skips without EVALS; module loads). --- test/skill-e2e-setup-gbrain-remote.test.ts | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/test/skill-e2e-setup-gbrain-remote.test.ts b/test/skill-e2e-setup-gbrain-remote.test.ts index dfc7354ca..e5edabddd 100644 --- a/test/skill-e2e-setup-gbrain-remote.test.ts +++ b/test/skill-e2e-setup-gbrain-remote.test.ts @@ -351,17 +351,6 @@ describeE2E('/setup-gbrain Path 4 (Remote MCP) — happy path', () => { // Assertion 4: CLAUDE.md got the remote-http block. expect(claudeMd).toMatch(/Mode: remote-http/); - // Assertion 5: classifier — the model didn't write findings before - // asking. The Path 4 prose has 5 STOP gates; if any of them got - // skipped, that's the wrote_findings_before_asking pattern. - // Scan the ASSISTANT's text only: modelTextOutput includes public - // event including the child's Read of the skill file, whose generated - // footer contains the literal "GSTACK REVIEW REPORT" — a guaranteed - // false positive on both trees. - const wroteBefore = /## GSTACK REVIEW REPORT|critical_gaps/i.test(result.output); - // Setup-gbrain doesn't have a review report contract, so this is - // a structural shape check, not a hard failure mode. - expect(wroteBefore).toBe(false); } catch (error) { assertionFailed = true; assertionFailure = error; } await cleanup(); if (assertionFailed) throw assertionFailure;