From 1f6c85af7c6da30841eeea8284b5b3b53f886037 Mon Sep 17 00:00:00 2001 From: garrytan Date: Mon, 26 Oct 2026 06:02:49 +0000 Subject: [PATCH] docs(browse): keep a basic-auth URL out of the scheme-guard comment so the pregate secret scan stays clean Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --- browse/src/proxy-config.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/browse/src/proxy-config.ts b/browse/src/proxy-config.ts index c3e19e8b0..297ae9631 100644 --- a/browse/src/proxy-config.ts +++ b/browse/src/proxy-config.ts @@ -332,9 +332,9 @@ export function directProxyLogLine(env: NodeJS.ProcessEnv, platform: NodeJS.Plat * parser as written, so a typo such as `http:/host:3128` keeps the * diagnostic it had; parseProxyConfig then rejects any path, query or * fragment, so no part of a password can land outside the redacted userinfo. - * A userinfo that opens with a known scheme (`https:bob:pw@host:3128`, the - * slash-less spelling the URL parser reads as `https://bob:pw@host:3128`) - * is a scheme, not credentials, so it is excluded too. + * A userinfo that opens with a known scheme (`https:bob@host:3128`, the + * slash-less spelling the URL parser reads as an `https://` URL with user + * `bob`) is a scheme, not credentials, so it is excluded too. */ const SCHEMELESS_PROXY_RE = /^(?:[^/\\?#@\s]+@)?(?:\[[0-9a-f:.]+\]|(?=[^:]*[a-z.])[^/\\?#@\s:[\]]+)(?::\d+)?$/i; const LEADING_SCHEME_RE = /^(?:https?|socks5h?):/i;