From 21daf76723069ebeb4df0b04fec9d7f38a15c346 Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Wed, 18 Mar 2026 11:09:19 -0700 Subject: [PATCH] feat: add reverted QA commit detection to /ship MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit During pre-landing review, /ship now checks for reverted fix(qa): commits in the branch history and recommends /debug for systematic investigation. Informational only — does not block shipping. Co-Authored-By: Claude Opus 4.6 (1M context) --- ship/SKILL.md | 8 ++++++++ ship/SKILL.md.tmpl | 8 ++++++++ 2 files changed, 16 insertions(+) diff --git a/ship/SKILL.md b/ship/SKILL.md index 3f0f0067..8b1f5015 100644 --- a/ship/SKILL.md +++ b/ship/SKILL.md @@ -727,6 +727,14 @@ Substitute: TIMESTAMP = ISO 8601 datetime, STATUS = "clean" if 0 findings or "is Save the review output — it goes into the PR body in Step 8. +**Reverted QA fix detection:** Check if the branch history contains reverted QA commits: +```bash +git log origin/..HEAD --oneline | grep -i 'revert.*fix(qa)' +``` +If reverted QA commits are found, note in review output: +"This branch has reverted QA fixes — the underlying bugs may still be present. Consider running `/debug` on the affected areas before shipping." +This is INFORMATIONAL only — does not block shipping. + --- ## Step 3.75: Address Greptile review comments (if PR exists) diff --git a/ship/SKILL.md.tmpl b/ship/SKILL.md.tmpl index aef5c9d3..44d459f9 100644 --- a/ship/SKILL.md.tmpl +++ b/ship/SKILL.md.tmpl @@ -361,6 +361,14 @@ Review the diff for structural issues that tests don't catch. Save the review output — it goes into the PR body in Step 8. +**Reverted QA fix detection:** Check if the branch history contains reverted QA commits: +```bash +git log origin/..HEAD --oneline | grep -i 'revert.*fix(qa)' +``` +If reverted QA commits are found, note in review output: +"This branch has reverted QA fixes — the underlying bugs may still be present. Consider running `/debug` on the affected areas before shipping." +This is INFORMATIONAL only — does not block shipping. + --- ## Step 3.75: Address Greptile review comments (if PR exists)