diff --git a/plan-eng-review/SKILL.md b/plan-eng-review/SKILL.md index ac127e9e..8a1b2c05 100644 --- a/plan-eng-review/SKILL.md +++ b/plan-eng-review/SKILL.md @@ -222,11 +222,17 @@ A) Yes — let Codex critique the plan independently B) No — proceed with the Claude review only ``` -If the user chooses A: read the plan file and run Codex with the plan review persona: +If the user chooses A: read the plan file content, then pass it into the Codex prompt so it has the actual plan to critique: ```bash -codex exec "You are a brutally honest technical reviewer. Review this plan for: logical gaps and unstated assumptions, missing error handling or edge cases, overcomplexity (is there a simpler approach?), feasibility risks (what could go wrong?), and missing dependencies or sequencing issues. Be direct. Be terse. No compliments. Just the problems." -s read-only +PLAN_CONTENT=$(cat ) +codex exec "You are a brutally honest technical reviewer. Review this plan for: logical gaps and unstated assumptions, missing error handling or edge cases, overcomplexity (is there a simpler approach?), feasibility risks (what could go wrong?), and missing dependencies or sequencing issues. Be direct. Be terse. No compliments. Just the problems. + +THE PLAN: +$PLAN_CONTENT" -s read-only -c 'model_reasoning_effort="high"' --enable web_search_cached ``` +Replace `` with the actual path to the plan file detected earlier. + Present the full output under a `CODEX SAYS (plan review):` header. Note any concerns that should inform the subsequent engineering review sections. diff --git a/plan-eng-review/SKILL.md.tmpl b/plan-eng-review/SKILL.md.tmpl index 3e206507..df5e775a 100644 --- a/plan-eng-review/SKILL.md.tmpl +++ b/plan-eng-review/SKILL.md.tmpl @@ -93,11 +93,17 @@ A) Yes — let Codex critique the plan independently B) No — proceed with the Claude review only ``` -If the user chooses A: read the plan file and run Codex with the plan review persona: +If the user chooses A: read the plan file content, then pass it into the Codex prompt so it has the actual plan to critique: ```bash -codex exec "You are a brutally honest technical reviewer. Review this plan for: logical gaps and unstated assumptions, missing error handling or edge cases, overcomplexity (is there a simpler approach?), feasibility risks (what could go wrong?), and missing dependencies or sequencing issues. Be direct. Be terse. No compliments. Just the problems." -s read-only +PLAN_CONTENT=$(cat ) +codex exec "You are a brutally honest technical reviewer. Review this plan for: logical gaps and unstated assumptions, missing error handling or edge cases, overcomplexity (is there a simpler approach?), feasibility risks (what could go wrong?), and missing dependencies or sequencing issues. Be direct. Be terse. No compliments. Just the problems. + +THE PLAN: +$PLAN_CONTENT" -s read-only -c 'model_reasoning_effort="high"' --enable web_search_cached ``` +Replace `` with the actual path to the plan file detected earlier. + Present the full output under a `CODEX SAYS (plan review):` header. Note any concerns that should inform the subsequent engineering review sections.