fix(ship): one decision each for the review-loop exits, the planned adversarial skip and Step 16's TODOS rerun (screen judge repair)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This commit is contained in:
garrytanandcapy-ai[bot] committed 2026-10-28 02:50:35 +00:00
1 parent c5e13f9167
commit 243ca8ea21
17 files changed
+110 -118

No files matched your search

+7 -7
View File
@@ -116,7 +116,7 @@ If A: revise the premise and note the revision. If B: proceed (and note that the
// ─── Adversarial Review (always-on) ──────────────────────────────────
function adversarialNativePass(ctx: TemplateContext, isShip: boolean): string {
return `### ${outsideVoiceFor(ctx).nativeLabel} adversarial subagent (always runs)
return `### ${outsideVoiceFor(ctx).nativeLabel} adversarial subagent (${isShip ? 'on \`DISPATCH: adversarial-native\`' : 'always runs'})
Before dispatch, run \`~/.claude/skills/gstack/bin/gstack-review-log --start adversarial-review\`
and save the returned token for this native attempt. Do the same before each outside
@@ -235,9 +235,9 @@ export function generateAdversarialStep(ctx: TemplateContext): string {
const isShip = ctx.skillName === 'ship';
const stepNum = isShip ? '11' : '4.8';
return `## Step ${stepNum}: Adversarial review (always-on)
return `## Step ${stepNum}: Adversarial review${isShip ? '' : ' (always-on)'}
Every diff gets the ${outsideVoiceFor(ctx).nativeLabel} adversarial pass. Add ${outsideVoiceFor(ctx).label} when its preflight is ready; unavailable or disabled outside coverage stays explicit.
${isShip ? 'Unavailable' : `Every diff gets the ${outsideVoiceFor(ctx).nativeLabel} adversarial pass. Add ${outsideVoiceFor(ctx).label} when its preflight is ready; unavailable`} or disabled outside coverage stays explicit.
**Detect diff size:**
@@ -252,8 +252,8 @@ echo "DIFF_SIZE: $DIFF_TOTAL"
${outsideVoicePreflight(ctx, { disabledBehavior: 'codex-only', nativeReview: true })}
\`CODEX_MODE: disabled\` means skip the ${outsideVoiceFor(ctx).label} passes ONLY.
\`ready\` and \`unverified\` run them; every other mode skips them with the printed reason.
The ${outsideVoiceFor(ctx).nativeLabel} adversarial subagent always runs.
\`ready\` and \`unverified\` run them; every other mode skips them with the printed reason.${isShip ? '' : `
The ${outsideVoiceFor(ctx).nativeLabel} adversarial subagent always runs.`}
**User override:** If the user explicitly requested "full review", "structured review", or "P1 gate", also run the ${outsideVoiceFor(ctx).label} structured review regardless of diff size (still requires \`CODEX_MODE: ready\` (or \`unverified\`)).
@@ -274,7 +274,7 @@ ${outsideVoiceProvenance(ctx, 'adversarial')}
After all passes complete, synthesize findings across all sources:
\`\`\`
ADVERSARIAL REVIEW SYNTHESIS (always-on, N lines):
ADVERSARIAL REVIEW SYNTHESIS (${isShip ? '' : 'always-on, '}N lines):
════════════════════════════════════════════════════════════
High confidence (found by multiple sources): [findings agreed on by >1 pass]
Unique to the parent checklist/specialists: [from earlier steps]
@@ -309,7 +309,7 @@ in order before leaving Step 11:
Step 9 completes full review before fixes; any further repair inserts its checks
ahead of the remaining items. These fresh reviews after code edits are not recovery retries.
Returning here never resets Step 9's three-cycle fix limit.
3. **Native complete with no queued fixes:** Finish the memory updates below,
3. **Native complete with no queued fixes, or not dispatched:** Finish the memory updates below,
then continue to Step 11.5. Never jump directly to release preparation.` : 'The native pass is required for Step 5.8 completion. Optional outside failures remain separately recorded, not completed by native coverage. Return all findings and structured-review decisions to Step 5; the parent owns fixes and the full rerun.'}
---`;
+1 -3
View File
@@ -65,9 +65,7 @@ ${ctx.skillName === 'ship' ? 'This verdict never skips Step 9 or its finding, ap
Other rows provide context, not a substitute for Eng Review:
- Recommend CEO Review for product/business or scope decisions, not routine fixes or cleanup.
- Recommend Design Review for UI/UX work, not backend, infrastructure or prompt-only work.
- Adversarial review always includes a native pass. Available, enabled outside
challenges supplement it; diffs of 200+ lines also get the structured P1 gate.
- Outside Voice is the default-on plan review after CEO/Eng review. \`codex_reviews\`
${ctx.skillName === 'ship' ? '- Step 9\'s review plan decides the adversarial passes (Step 11).\n' : '- Adversarial review always includes a native pass. Available, enabled outside\n challenges supplement it; diffs of 200+ lines also get the structured P1 gate.\n'}- Outside Voice is the default-on plan review after CEO/Eng review. \`codex_reviews\`
disables that extra step. Provider failure uses native fallback and records
missing outside coverage; this dashboard row never gates shipping.