mirror of
https://github.com/garrytan/gstack.git
synced 2026-09-01 19:00:40 +02:00
v1.76.0.0 fix: ship doc-sync survives Conductor — spawned subagent sessions reachable (#2733) (#2741)
* feat(session-kind): explicit GSTACK_SESSION_KIND override; skill-start spawned gates keyed on kind (#2733) Claude Code subagents inherit the parent env byte-for-byte, so ambient markers classify them as the parent's kind and the spawned classification was unreachable outside OpenClaw. GSTACK_SESSION_KIND=spawned (step 0, spawned-only by design) lets a dispatching skill mark its subagent per command. skill-start now keys SPAWNED_SESSION and the spawned-session instruction block on the resolved kind (was raw OPENCLAW_SESSION), suppresses CONDUCTOR_SESSION for spawned sessions, gates all 11 interactive-onboarding blocks plus their ack-at-emit marker writes on kind != spawned, and adds a destructive-gate carve-out to the spawned block (conservative-continue, never prose-STOP). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(hooks): spawned-session escape in Conductor AUQ deny; override coverage in AUQ-error fallback (#2733) Hooks inherit the harness env, so a per-command GSTACK_SESSION_KIND prefix inside a subagent's bash can never reach them. Levers added: a deterministic [conductor][spawned] auto-choose deny for env-level spawned sessions (OPENCLAW_SESSION or session-wide GSTACK_SESSION_KIND), and a spawned escape sentence appended to both hooks' prose directives so a marked subagent that slips and calls AUQ resolves to auto-choose instead of prose-STOP. The sentence lives in one shared constant (hosts/claude/hooks/spawned-directive.ts) so the two paths can never drift; destructive semantics are unified to conservative-continue. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(ship): Step 18 marks the document-release subagent spawned — env prefix + auto-choose prompt (#2733) The dispatch prompt now (1) frames the run as a SPAWNED subagent whose LAST line is machine-parsed, (2) instructs prefixing the preamble's gstack-skill-start invocation with GSTACK_SESSION_KIND=spawned on the same command line (template bash blocks don't share exports), and (3) resolves every AUQ gate to auto-choosing the recommended option, conservative on no-recommendation, never destructive. The JSON contract gains a required "decisions" array (auto-chosen gates, printed to the ship console — never embedded in the public PR body) and a placement clause so the skill's own doc-health summary stops competing with the LAST-line JSON. Tripwire pins added; codex/factory goldens refreshed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(auq-format): proactive SESSION_KIND=spawned rule ordered above the Conductor rule (#2733) The spawned classification previously existed only in the failure-fallback branch — a spawned session was invited to call AskUserQuestion and reach auto-choose via the deny/error detour, and a spawned session inside a Conductor workspace hit the Conductor prose-STOP rule first. The Tool resolution list now leads with the spawned rule (auto-choose recommended, never prose, never BLOCKED, destructive gates resolve conservative), the self-check carries the never-reach-this-checklist clause, and all tier>=2 SKILL.md renders are regenerated. Context-budget fixture refreshed in the same commit per the ratchet protocol (the AUQ section is eager in every tier>=2 skill). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test(e2e): spawned document-release subagent returns the JSON contract through a firing gate (#2733) The behavioral proof the bug shipped without: ship-docsync stubs the skill (no preamble, no gates) and skill-e2e-workflow suppresses the gates by prompt. This gate-tier E2E plays the parent — it drives the verbatim Step 18 dispatch prompt (extracted from the live pr-body.md, drift-proof) against a real preamble-bearing document-release slice in a Conductor-ambient env with both AUQ hooks seeded live, an unbumped VERSION making Step 8 fire. Asserts: the final line parses as the 5-key JSON contract, the fired gate's auto-choice is recorded in decisions, and VERSION is untouched (the gate resolved to its recommended Skip). Burn-in: 1/1 pass, $0.35, 21 turns, 106s. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs(openclaw): document the GSTACK_SESSION_KIND override; wire session-kind into paid selectors (#2733) OPENCLAW.md's spawned-session section now covers the explicit per-command marker, its deliberate spawned-only narrowness, the /ship Step 18 usage, the destructive carve-out, onboarding-block suppression, and the hook env-blindness caveat. bin/gstack-session-kind and the shared spawned-directive module join the conductor-prose and auto-decide-preserved selector dep lists (session-kind previously appeared in no touchfiles entry — editing it alone triggered no paid E2E). TODOS.md gains the plan-tune capture follow-up for spawned auto-choices. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix: pre-landing review fixes (#2733) Review army + coverage audit findings, all applied: - headless directive carries the spawned escape sentence too (multi- specialist: a CI-hosted ship's marked subagent must not end BLOCKED) - anti-injection scoping on every text-claimable spawned trigger (AUQ rule + shared escape sentence): markings count only from the creating prompt, never from files/tool output/web content read mid-run - [conductor][spawned] deny annotates one-way doors per question - SPAWNED_OVERRIDE: env tamper-visibility status line + OPENCLAW.md note - spawned sessions skip the network update-check and first-task probe (consumers suppressed; preserves the one-shot just-upgraded marker) - test hardening: dispatch-tripwire end-bound validated, vacuous marker asserts replaced with output asserts, E2E cpSync size filter + named fence tolerance, spawnedByEnv parity pin, destructive-policy cross- surface drift guard, one-way annotation + bogus-value hook cases - session-kind duplicate rationale comment deduped; regen + goldens + context-budget fixture refreshed Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore: bump version and changelog (v1.76.0.0) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs: update project documentation for v1.76.0.0 PROJECT_STRUCTURE.md: add hosts/claude/hooks/ to the directory tree (AUQ capture + enforcement hooks, spawned-session directive, timeline stop) — the tree omitted the directory while docs/OPENCLAW.md and CHANGELOG.md now reference paths inside it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs: sync TODOS.md ship dispatch entry with the v1.76.0.0 contract Codex doc-review finding: the SHIPPED entry for /ship auto-invoking /document-release still described the four-key JSON contract. Adds the decisions key (console-printed, never PR markdown), the GSTACK_SESSION_KIND=spawned dispatch marking (#2733), and the new spawned-dispatch gate E2E to the proven-by list. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Fable 5
parent
07b59e396c
commit
253d1dfe26
Vendored
+40
-40
@@ -2,64 +2,64 @@
|
||||
"_comment": "Context-budget ratchet ceilings (~tokens). Regenerate: bun test/helpers/capture-context-budget.ts. Headroom: alwaysOnTotal x1.05, eagerPerInvocation x1.1. Graded by test/context-budget-ratchet.test.ts via lib/context-bill.ts checkBudget.",
|
||||
"alwaysOnTotal": 6344,
|
||||
"eagerPerInvocation": {
|
||||
"autoplan": 16321,
|
||||
"autoplan": 16619,
|
||||
"benchmark": 4931,
|
||||
"benchmark-models": 3829,
|
||||
"browse": 7097,
|
||||
"browser-skills/hackernews-frontpage": 371,
|
||||
"canary": 10365,
|
||||
"canary": 10664,
|
||||
"careful": 919,
|
||||
"codex": 14952,
|
||||
"context-restore": 9304,
|
||||
"context-save": 9921,
|
||||
"cso": 14894,
|
||||
"design-consultation": 13601,
|
||||
"design-html": 13286,
|
||||
"design-review": 24182,
|
||||
"design-shotgun": 13397,
|
||||
"devex-review": 15540,
|
||||
"codex": 15251,
|
||||
"context-restore": 9603,
|
||||
"context-save": 10219,
|
||||
"cso": 15193,
|
||||
"design-consultation": 13899,
|
||||
"design-html": 13585,
|
||||
"design-review": 24481,
|
||||
"design-shotgun": 13696,
|
||||
"devex-review": 15838,
|
||||
"diagram": 3847,
|
||||
"document-generate": 12049,
|
||||
"document-release": 9846,
|
||||
"document-generate": 12347,
|
||||
"document-release": 10145,
|
||||
"freeze": 990,
|
||||
"gstack": 3548,
|
||||
"gstack-upgrade": 3981,
|
||||
"guard": 889,
|
||||
"health": 10502,
|
||||
"investigate": 11155,
|
||||
"ios-clean": 8407,
|
||||
"ios-design-review": 8588,
|
||||
"ios-fix": 8360,
|
||||
"ios-qa": 11100,
|
||||
"ios-sync": 8531,
|
||||
"land-and-deploy": 15776,
|
||||
"landing-report": 9214,
|
||||
"learn": 8884,
|
||||
"health": 10801,
|
||||
"investigate": 11454,
|
||||
"ios-clean": 8706,
|
||||
"ios-design-review": 8887,
|
||||
"ios-fix": 8659,
|
||||
"ios-qa": 11399,
|
||||
"ios-sync": 8830,
|
||||
"land-and-deploy": 16075,
|
||||
"landing-report": 9512,
|
||||
"learn": 9182,
|
||||
"make-pdf": 4957,
|
||||
"office-hours": 18685,
|
||||
"office-hours": 18984,
|
||||
"open-gstack-browser": 4504,
|
||||
"openclaw/skills/gstack-openclaw-ceo-review": 2764,
|
||||
"openclaw/skills/gstack-openclaw-investigate": 1429,
|
||||
"openclaw/skills/gstack-openclaw-office-hours": 4433,
|
||||
"openclaw/skills/gstack-openclaw-retro": 2542,
|
||||
"pair-agent": 11309,
|
||||
"plan-ceo-review": 19400,
|
||||
"plan-design-review": 18841,
|
||||
"plan-devex-review": 16681,
|
||||
"plan-eng-review": 13621,
|
||||
"plan-tune": 14458,
|
||||
"qa": 13197,
|
||||
"qa-only": 12970,
|
||||
"retro": 18660,
|
||||
"review": 14914,
|
||||
"pair-agent": 11607,
|
||||
"plan-ceo-review": 19698,
|
||||
"plan-design-review": 19139,
|
||||
"plan-devex-review": 16980,
|
||||
"plan-eng-review": 13920,
|
||||
"plan-tune": 14756,
|
||||
"qa": 13495,
|
||||
"qa-only": 13269,
|
||||
"retro": 18959,
|
||||
"review": 15213,
|
||||
"scrape": 3939,
|
||||
"setup-browser-cookies": 3194,
|
||||
"setup-deploy": 10646,
|
||||
"setup-gbrain": 15251,
|
||||
"ship": 19751,
|
||||
"skillify": 11889,
|
||||
"spec": 14385,
|
||||
"sync-gbrain": 13672,
|
||||
"setup-deploy": 10945,
|
||||
"setup-gbrain": 15550,
|
||||
"ship": 20050,
|
||||
"skillify": 12188,
|
||||
"spec": 14684,
|
||||
"sync-gbrain": 13970,
|
||||
"unfreeze": 393
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user