From 25a7e31e4986986a6ad53d8f97a3421470e23f16 Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Mon, 17 Aug 2026 11:20:34 -0700 Subject: [PATCH] test: re-anchor the referenced-path scanner self-check to the gstack-rooted review refs The self-check pinned the review checklist as a class-1 alias-relative ref; #2518 moved those refs to the installed gstack root (class 2). The guard now proves the scanner sees them in their new class, so the class-2 assertion can't go vacuous. Co-Authored-By: Claude Fable 5 --- test/setup-claude-skill-assets.test.ts | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/test/setup-claude-skill-assets.test.ts b/test/setup-claude-skill-assets.test.ts index 8cabfadab..f8dcf4796 100644 --- a/test/setup-claude-skill-assets.test.ts +++ b/test/setup-claude-skill-assets.test.ts @@ -207,12 +207,14 @@ describe('two-class referenced-paths (ENG-OV7)', () => { }); test('the referenced-path scan actually sees the review checklist refs (self-check)', () => { - // Guard against the extraction regex silently rotting: the review skill is - // KNOWN to carry alias-relative refs; if the scanner stops seeing them the - // class-1 assertion is vacuous. - const class1 = collectRefs().filter((r) => r.skillName !== 'gstack'); - expect(class1.length).toBeGreaterThan(0); - expect(class1.some((r) => r.skillName === 'review' && r.rel === 'checklist.md')).toBe(true); + // Guard against the extraction regex silently rotting: the review skill's + // checklist refs are KNOWN to exist. Since #2518 they anchor at the + // installed gstack root (class 2: gstack/review/checklist.md), not the + // alias-relative form — if the scanner stops seeing them, the class-2 + // assertion is vacuous. + const refs = collectRefs(); + expect(refs.length).toBeGreaterThan(0); + expect(refs.some((r) => r.skillName === 'gstack' && r.rel === 'review/checklist.md')).toBe(true); }); test('KNOWN_BROKEN_CLASS2 entries are still actually broken (ratchet)', () => {