READY prints real trial merges and the second-model trail read, plus six small ship-tool fixes (GST-3200) (#4529)

READY now prints each open PR's trial-merge result and the reader of the
second-model trail read, or a loud MISSING line, instead of lines left
to fill in.

Why: agents dropped those lines as noise and skipped the trail read on
three gate-class PRs. Six more small ship-tool bugs from 2026-11-19
reports are fixed here too.

Nothing to do: pass `--trail ` to `gstack-ship-queue ready` on
risk-class PRs.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1/outside-voice#1 reader=outside-voice
Review-Finding: p1/outside-voice#2 reader=outside-voice
Review-Finding: p1/outside-voice#3 reader=outside-voice
Review-Finding: p1/outside-voice#4 reader=outside-voice
Review-Finding: p1/outside-voice#5 reader=outside-voice
Review-Finding: p1/red-team#1 reader=red-team
Review-Finding: p1/adversarial-native#4 reader=adversarial-native
This commit is contained in:
Garry Tanandcapy-ai[bot] authored and GitHub committed 2026-11-19 17:05:16 +00:00
1 parent 50cc282273
commit 2714e9f7f3
36 files changed
+503 -68

No files matched your search

+4 -3
View File
@@ -228,9 +228,10 @@ caught on another crew's PRs.
first dispatch, which writes a grant record into the runs block; a grant
another run claimed is refused (`GRANT_SPENT`), a voided run's claim still
spends it, and stop and grant records are never trimmed from the block.
gstack never grants itself a round: `--by` naming gstack (any name starting
with "gstack", so a Captain called GStack Minder writes "Captain GStack
Minder") and a grant from inside an open `/ship` run are refused, and `add`
gstack never grants itself a round: `--by` naming gstack (one of the names
gstack writes for itself, `gstack` or `gstack no-stop default (K1)`, matched
whole and case-insensitively, so "gstack-evals Captain" or "GStack Minder" can
grant) and a grant from inside an open `/ship` run are refused, and `add`
refuses the scope. `--by` is otherwise the caller's own text, recorded and
not checked: a lane that records a grant (or a ruling) from another checkout
under its Captain's name can't be told apart from the Captain doing it, so the
+13 -2
View File
@@ -1765,8 +1765,13 @@ and ask `ruled_note <fingerprint> at <head>: <reason>`, with the head's full sha
two findings ruled with the same reason in one reply get two rows, and a ruling at
a later head is a new row. Its `by` is the ruler and its `recorded_at` the time.
`rule` refuses a `--head` that is not a commit in the repository, a reason with a
newline or control character, a `--by` naming gstack, and any ruling while this
checkout holds an open /ship run's marker (the lane's own runner). `add` refuses a
newline or control character, a `--by` naming gstack, and a ruling while this
checkout holds an open /ship run's marker (the lane's own runner) unless the lane
relays the owner's words with `--owner-ref <thread code>:<message id or timestamp>`
(on Capy the owner, a Captain, has no session on the lane's checkout). A relayed row's
source is `relayed:<owner ref>`, and its `RULED_NOTE:`, receipt entry and `Ruled note:`
line say `(relayed from <owner ref>)`, so a reader can check the words against that
message; without it the refusal is `APPROVAL_RULING_RUN_OPEN`. `add` refuses a
`ruled_note` scope, so `rule` is the only path. A review-log field never makes a
ruling: `ruled`, `action: "ruled"` or any other claim the lane writes on its own
row is ignored. Step 16's `finish` reads the branch's rulings
@@ -1814,6 +1819,12 @@ visibility lookup that can fail or change, and a private repository can go
public with its PR history. As a backstop, `gstack-ship-receipt write` refuses a
`--body` and `gstack-post` refuses any text that names a raw security
fingerprint such as `src/x.ts:12:security`. Other findings print as before.
The red-team reviewer tags every finding `red-team`, a statistics or scoring
fix included, so the owner can rule one not security class with `gstack-approvals
rule --not-security` (only on a `path:line:red-team` fingerprint; a `security`,
`auth` or `secret` finding stays security class, and the flag is refused while a
/ship run is open on the checkout, so a run never lifts its own finding's redaction).
That ruling's lines show its reason and its location as `<path>:<line> (red-team, ruled not security class)`.
<a id="gate-dispositions"></a>
**Gate dispositions (GST-2491).** A ruling never closes a gate finding (a loosened
+17 -2
View File
@@ -2250,6 +2250,20 @@ empty or holds whitespace. `add` refuses a `ruled_note` or
ruling or a test-lane exception is the owner's: record it from the owner's
session, outside the lane's /ship run.
<a id="approval-ruling-run-open"></a>
### `gstack-approvals rule: ... (APPROVAL_RULING_RUN_OPEN)`
**Meaning.** A /ship run is open on this checkout (its marker is in the git dir until
finish), and `rule` was given no `--owner-ref`. A ruling is the owner's, and the run's own
runner never rules on the findings it is stopped on. Exit 2. Nothing was written.
**Fix.** On Capy the owner (a Captain) has no session on the lane's checkout, so the lane
relays the ruling: `gstack-approvals rule --finding <fp> --head <stop head> --reason <why>
--words "<the owner's exact words>" --by "<the owner>" --owner-ref <thread code>:<message id
or timestamp>`. The row, the receipt and the PR body's Ruled note line say it was relayed
and from which message, so a reader can check the words against it. Otherwise record the
ruling after the run stops.
<a id="approval-record-secret"></a>
### `gstack-approvals: ... (APPROVAL_RECORD_SECRET)`
@@ -2407,8 +2421,9 @@ this check exists to catch (GST-1751).
**Meaning.** `Plan: exempt: <reason>` names a reason outside the list: `bug fix`, `s1`,
`flaky`, `stamp`, `changelog-resolve`, `cap-repin`, `audited-list`, `read-only`,
or `crew:<rule>` for an exemption a crew's rules file records. A trailing
parenthetical such as `(R65)` is ignored. A diff of changelog fragments only needs
no line.
parenthetical such as `(R65)` is ignored, and a reason that starts with bug-fix
wording (`bug fix with failing-first tests`, `bugfix`, `bug-fixes`) counts as
`bug fix`. A diff of changelog fragments only needs no line.
**Fix.** Use the exemption the brief names. A change none of them covers is a feature
and needs `Plan: required` and a plan run.
+7 -2
View File
@@ -1090,8 +1090,13 @@ for that read. Every other PR skips it: the run's own audit is the review. The
run's final report ends with an `Attention` section that opens with `reviewed
by <model>` (risk class) or `self-audited` (every other PR) on its own line
and lists each flag against its rows; `No flags` is a valid body, a missing
opening line is not. `gstack-ship-queue ready` prints the stub with the right
opening line for the receipt it bound. `decisions.jsonl` stays the typed record `gstack-artifact` validates; the
opening line is not. The reader's read is a trail row with phase `trail-read`
whose decision names the reader (`gstack-decision-trail <file> trail-read
"openai/gpt-6.2-sol (Subagent 4)" <why> <evidence> <flags>`).
`gstack-ship-queue ready --trail <file>` prints the opening line from that row
for a risk-class receipt, or `MISSING: cross-family trail read` when the trail
has none, and one `TRIAL_MERGES` line per open PR that shares a file, from
`git merge-tree` at both heads. `decisions.jsonl` stays the typed record `gstack-artifact` validates; the
trail is the plain one a person reads, and `column -s$'\t' -t decisions.tsv`
renders it in a terminal.