CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-09-18 02:42:25 +02:00
Code Issues Packages Projects Releases Wiki Activity

test(gen-skill-docs): review render pins read the carved union

Browse Source 
The review carve's readSkillUnion conversions (same pattern its neighbor
carved-skill pins already use).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-08-25 16:36:37 +00:00
co-authored by Claude Fable 5
parent 00737fcb1b
commit 2877b63afe
1 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/gen-skill-docs.test.ts
+11 -6
View File
@@ -829,7 +829,7 @@ describe('REVIEW_DASHBOARD resolver', () => {
describe('TEST_COVERAGE_AUDIT placeholders', () => { describe('TEST_COVERAGE_AUDIT placeholders', () => {
const planSkill = readSkillUnion('plan-eng-review'); // carved const planSkill = readSkillUnion('plan-eng-review'); // carved
const shipSkill = readShipUnion(); const shipSkill = readShipUnion();
const reviewSkill = fs.readFileSync(path.join(ROOT, 'review', 'SKILL.md'), 'utf-8'); const reviewSkill = readSkillUnion('review'); // carved: Review Army moved to sections/review-army.md
test('plan and ship modes share codepath tracing methodology', () => { test('plan and ship modes share codepath tracing methodology', () => {
// Review mode delegates test coverage to the Testing specialist subagent (Review Army) // Review mode delegates test coverage to the Testing specialist subagent (Review Army)
@@ -1050,7 +1050,7 @@ describe('PLAN_FILE_REVIEW_REPORT resolver', () => {
describe('PLAN_COMPLETION_AUDIT placeholders', () => { describe('PLAN_COMPLETION_AUDIT placeholders', () => {
const shipSkill = readShipUnion(); const shipSkill = readShipUnion();
const reviewSkill = fs.readFileSync(path.join(ROOT, 'review', 'SKILL.md'), 'utf-8'); const reviewSkill = readSkillUnion('review'); // carved: plan-completion audit moved to sections/plan-completion.md
test('ship SKILL.md contains plan completion audit step', () => { test('ship SKILL.md contains plan completion audit step', () => {
expect(shipSkill).toContain('Plan Completion Audit'); expect(shipSkill).toContain('Plan Completion Audit');
@@ -1133,7 +1133,7 @@ describe('PLAN_VERIFICATION_EXEC placeholder', () => {
describe('Coverage gate in ship', () => { describe('Coverage gate in ship', () => {
const shipSkill = readShipUnion(); const shipSkill = readShipUnion();
const reviewSkill = fs.readFileSync(path.join(ROOT, 'review', 'SKILL.md'), 'utf-8'); const reviewSkill = readSkillUnion('review'); // carved: testing.md specialist ref lives in sections/review-army.md
test('ship SKILL.md contains coverage gate with thresholds', () => { test('ship SKILL.md contains coverage gate with thresholds', () => {
expect(shipSkill).toContain('Coverage gate'); expect(shipSkill).toContain('Coverage gate');
@@ -1178,7 +1178,7 @@ describe('Plan file discovery shared helper', () => {
// The shared helper should appear in ship (via PLAN_COMPLETION_AUDIT_SHIP) // The shared helper should appear in ship (via PLAN_COMPLETION_AUDIT_SHIP)
// and in review (via PLAN_COMPLETION_AUDIT_REVIEW) // and in review (via PLAN_COMPLETION_AUDIT_REVIEW)
const shipSkill = readShipUnion(); const shipSkill = readShipUnion();
const reviewSkill = fs.readFileSync(path.join(ROOT, 'review', 'SKILL.md'), 'utf-8'); const reviewSkill = readSkillUnion('review'); // carved: plan-completion audit moved to sections/plan-completion.md
test('plan file discovery appears in both ship and review', () => { test('plan file discovery appears in both ship and review', () => {
expect(shipSkill).toContain('Plan File Discovery'); expect(shipSkill).toContain('Plan File Discovery');
@@ -1410,8 +1410,9 @@ describe('Codex filesystem boundary', () => {
}); });
test('review.ts CODEX_BOUNDARY constant is interpolated into resolver output', () => { test('review.ts CODEX_BOUNDARY constant is interpolated into resolver output', () => {
// The adversarial step resolver should include boundary text in codex exec prompts // The adversarial step resolver should include boundary text in codex exec
const reviewContent = fs.readFileSync(path.join(ROOT, 'review', 'SKILL.md'), 'utf-8'); // prompts. Carved: the adversarial step lives in sections/adversarial.md.
const reviewContent = readSkillUnion('review');
// Boundary should appear near codex exec invocations // Boundary should appear near codex exec invocations
const boundaryIdx = reviewContent.indexOf(BOUNDARY_MARKER); const boundaryIdx = reviewContent.indexOf(BOUNDARY_MARKER);
const codexExecIdx = reviewContent.indexOf('codex exec'); const codexExecIdx = reviewContent.indexOf('codex exec');
@@ -3126,6 +3127,10 @@ describe('codex commands must not use inline $(git rev-parse --show-toplevel) fo
'ship/SKILL.md', 'ship/SKILL.md',
'codex/SKILL.md.tmpl', 'codex/SKILL.md.tmpl',
'codex/SKILL.md', 'codex/SKILL.md',
// codex's scoped invocations moved into the carved review-mode section
// (T9) — keep sweeping both the .tmpl source and the generated section.
'codex/sections/review-mode.md.tmpl',
'codex/sections/review-mode.md',
]; ];
const violations: string[] = []; const violations: string[] = [];