W7 T9 T7: archaeology lint on generated skill text; drop issue numbers from runtime prose

test/archaeology-lint.test.ts renders every host, scans each generated
SKILL.md and section for issue/PR numbers and incident stories, maps each hit
to the template or resolver that emitted it, and fails with that source, the
matched text and the allowlist entry shape to paste (reason required). Entries
are keyed by skill plus a nearby anchor; a stale entry fails.

Removed the IDs from runtime prose in codex, context-restore, scrape,
skillify, setup-gbrain, sync-gbrain, the model_unusable resolver line and the
tasks aggregator comment; every rule stays. Upstream bug IDs, usage examples
and sample output are allowlisted. Hits in files other workstreams own
(design-doc-discovery.ts, codex consult-mode) carry PENDING entries.
Generated SKILL.md files and goldens are regenerated by the integrator.
This commit is contained in:
garrytan committed 2026-10-03 21:11:07 +00:00
1 parent 053def75eb
commit 294b165743
12 files changed
+213 -16

No files matched your search

+2 -2
View File
@@ -84,7 +84,7 @@ if ! _gstack_codex_auth_probe >/dev/null; then
_gstack_codex_log_event "codex_auth_failed"
echo "AUTH_FAILED"
else
_gstack_codex_model_probe # ~10s round trip on first run, cached 1h (#2477)
_gstack_codex_model_probe # ~10s round trip on first run, cached 1h
fi
_gstack_codex_version_check # warns if known-bad, non-blocking
```
@@ -99,7 +99,7 @@ source on the `CODEX_MODEL:` line) is invalid or the account cannot use it. Rela
probe's HINT lines and
follow the "Model not supported (HTTP 400)" recovery steps in
`## Error Handling` below. Running the modes anyway just burns four
invocations on the same 400 (#2477).
invocations on the same 400.
`MODEL_PROBE_INCONCLUSIVE` is non-blocking (timeout/transient network): pass
the warning through and continue.
+3 -3
View File
@@ -67,14 +67,14 @@ for line in sys.stdin:
err = obj.get('error',{}).get('message','') or 'no error message in event'
print(f'[codex turn FAILED] {err}', flush=True, file=sys.stderr)
except: pass
# Fix 2: three-way completeness check (#2671) — a STATED failure is a failure,
# Fix 2: three-way completeness check — a STATED failure is a failure,
# not a network problem; only silence with no terminal event is a disconnect.
if turn_failed:
print('[codex] turn.failed received — the turn errored (reason above), not a disconnect.', flush=True, file=sys.stderr)
elif turn_completed_count == 0:
print('[codex warning] No turn.completed event received — possible mid-stream disconnect.', flush=True, file=sys.stderr)
"
_CODEX_EXIT=${PIPESTATUS[0]:-${pipestatus[1]}} # bash sets PIPESTATUS; zsh (lowercase, 1-indexed) falls through (#2669)
_CODEX_EXIT=${PIPESTATUS[0]:-${pipestatus[1]}} # bash sets PIPESTATUS; zsh (lowercase, 1-indexed) falls through
# Fix 1: hang detection — log + surface actionable message
if [ "$_CODEX_EXIT" = "124" ]; then
_gstack_codex_log_event "codex_timeout" "540"
@@ -82,7 +82,7 @@ if [ "$_CODEX_EXIT" = "124" ]; then
echo "Codex stalled past 9 minutes. Common causes: model API stall, long prompt, network issue. Try re-running. If persistent, split the prompt or check ~/.codex/logs/."
elif [ "$_CODEX_EXIT" != "0" ]; then
# Surface non-zero exits so the calling agent doesn't read "no output" as
# a silent model/API stall. See #1327.
# a silent model/API stall.
echo "[codex exit $_CODEX_EXIT] $(head -1 "$TMPERR" 2>/dev/null || echo "no stderr captured")"
head -20 "$TMPERR" 2>/dev/null | sed 's/^/ /' || true
_gstack_codex_log_event "codex_nonzero_exit" "challenge:$_CODEX_EXIT"
+2 -2
View File
@@ -37,7 +37,7 @@ Use only one command path below. Remember its printed start token as CODEX_REVIE
read-only sandbox is set with `-c 'sandbox_mode="read-only"'` — the same form the
consult resume path uses. Without it the call inherits the user's
`~/.codex/config.toml` default, which on a trusted project can be WRITE access —
contradicting this skill's read-only contract (#2496, #2524):
contradicting this skill's read-only contract:
```bash
_REPO_ROOT=$(git rev-parse --show-toplevel) || { echo "ERROR: not in a git repo" >&2; exit 1; }
@@ -57,7 +57,7 @@ if [ "$_CODEX_EXIT" = "124" ]; then
elif [ "$_CODEX_EXIT" != "0" ]; then
# Surface non-zero exits (parse errors, arg-shape breaks, etc.) so the
# calling agent doesn't read "no output" as a silent model/API stall and
# burn 30-60min misdiagnosing it. See #1327.
# burn 30-60min misdiagnosing it.
echo "[codex exit $_CODEX_EXIT] $(head -1 "$TMPERR" 2>/dev/null || echo "no stderr captured")"
head -20 "$TMPERR" 2>/dev/null | sed 's/^/ /' || true
_gstack_codex_log_event "codex_nonzero_exit" "review:$_CODEX_EXIT"