fix(catalog): preserve routing prose when first sentence exceeds 200 chars

mirror of https://github.com/garrytan/gstack.git synced 2026-08-07 23:08:36 +02:00

splitCatalogDescription truncated the lead BEFORE computing routing
extraction, which meant skills whose first sentence was over 200 chars
(design-consultation: 207 chars) had their entire routing prose silently
dropped — the "## When to invoke" body section came out empty.

Root cause: routing was extracted via `collapsed.indexOf(lead)` after lead
was suffixed with "...". The "..." never appeared in the original string,
so indexOf returned -1 and routingProse fell back to empty.

Fix: compute routing from sentenceLead (the untruncated first sentence)
BEFORE truncating the displayed lead. The displayed lead still gets "..."
when over 200 chars, but the routing extraction uses the real boundary.

Also: refresh golden snapshots for claude/codex/factory ship and update
two unit tests that asserted v1.44 behavior:
- skill-validation.test.ts: trigger-phrase + proactive-routing tests now
  search whole content, not just frontmatter (T4 moved them to a body
  "## When to invoke" section)
- writing-style-resolver.test.ts: jargon-list assertion now expects the
  T3 reference pointer, not the inline list

Test plan:
- bun test test/skill-validation.test.ts test/writing-style-resolver.test.ts
  test/host-config.test.ts test/skill-size-budget.test.ts
  test/parity-suite.test.ts test/skill-coverage-matrix.test.ts
  test/skill-coverage-floor.test.ts test/cso-preserved.test.ts
  test/resolver-entry.test.ts test/helpers/capture-parity-baseline.test.ts
  test/gen-skill-docs.test.ts: 1134 pass, 0 fail
- Manual verify: design-consultation/SKILL.md "## When to invoke this skill"
  body section now contains "Use when asked to..." + "Proactively suggest..."

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

This commit is contained in:

Garry Tan

2026-05-25 21:09:59 -07:00

co-authored by

Claude Opus 4.7

parent 43e18af4ad

commit 2aff29e956

8 changed files with 57 additions and 264 deletions

									
										design-consultation/SKILL.md
									
		+6
		
												View File
												
				@@ -46,6 +46,12 @@ gbrain:

				## When to invoke this skill

				Creates DESIGN.md as your project's design source

				of truth. For existing sites, use /plan-design-review to infer the system instead.

				Use when asked to "design system", "brand guidelines", or "create DESIGN.md".

				Proactively suggest when starting a new project's UI with no existing

				design system or DESIGN.md.

				## Preamble (run first)

				```bash