diff --git a/review/SKILL.md b/review/SKILL.md index d43064512..c2e05ded6 100644 --- a/review/SKILL.md +++ b/review/SKILL.md @@ -666,7 +666,7 @@ Sanitize every query before it leaves the machine: strip hostnames, IPs, file pa ## Step 4: Critical pass (core review) -> **STOP.** Before any probe, including plan checks, complete the ordered scope/method Reads below. Templates cannot replace them. +> **STOP.** Before any probe, including plan checks, complete the ordered scope/method Reads below and await them. Templates cannot replace them. Step 4 is read-only: defer charters, setup and probes to Step 4.7. From the installed /review SKILL.md's directory, choose one path: diff --git a/scripts/resolvers/qa.ts b/scripts/resolvers/qa.ts index ff8816c3c..b16accf36 100644 --- a/scripts/resolvers/qa.ts +++ b/scripts/resolvers/qa.ts @@ -225,7 +225,7 @@ ${setup ? 'Read `sections/browser-setup.md` in full unless already completed;\n' export function generateQAReviewPreflight(ctx: TemplateContext): string { sectionPath(ctx, 'qa', 'exploratory'); - return `> **STOP.** Before any probe, including plan checks, complete the ordered scope/method Reads below. Templates cannot replace them. + return `> **STOP.** Before any probe, including plan checks, complete the ordered scope/method Reads below and await them. Templates cannot replace them. ${ctx.skillName === 'review' ? 'Step 4 is read-only: defer charters, setup and probes to Step 4.7.\n' : ''} {{QA_RESOURCE:exploratory}} diff --git a/ship/sections/review-army.md b/ship/sections/review-army.md index 2c749d39b..dbf0dd014 100644 --- a/ship/sections/review-army.md +++ b/ship/sections/review-army.md @@ -487,7 +487,7 @@ Never overwrite another run's reports. Batch only independent Reads. **1. Load methods before any QA or explicit-verification probe.** -> **STOP.** Before any probe, including plan checks, complete the ordered scope/method Reads below. Templates cannot replace them. +> **STOP.** Before any probe, including plan checks, complete the ordered scope/method Reads below and await them. Templates cannot replace them. From the installed /ship SKILL.md's directory, Read `../qa/sections/exploratory.md` in full. If the caller directory is prefixed `gstack-ship`, use `../gstack-qa/sections/exploratory.md` instead. Use this host's installation, never the product tree. If missing or unreadable, report a QA setup blocker and its affected probes as blocked; continue other safe probes (independent functional/static checks). Missing/unreadable assets block required QA. diff --git a/test/fixtures/golden/codex-ship-SKILL.md b/test/fixtures/golden/codex-ship-SKILL.md index 69d65ce74..1bd69570a 100644 --- a/test/fixtures/golden/codex-ship-SKILL.md +++ b/test/fixtures/golden/codex-ship-SKILL.md @@ -2090,7 +2090,7 @@ Never overwrite another run's reports. Batch only independent Reads. **1. Load methods before any QA or explicit-verification probe.** -> **STOP.** Before any probe, including plan checks, complete the ordered scope/method Reads below. Templates cannot replace them. +> **STOP.** Before any probe, including plan checks, complete the ordered scope/method Reads below and await them. Templates cannot replace them. From the installed /ship SKILL.md's directory, Read `../gstack-qa/sections/exploratory.md` in full. Use this host's installation, never the product tree. If missing or unreadable, report a QA setup blocker and its affected probes as blocked; continue other safe probes (independent functional/static checks). Missing/unreadable assets block required QA. diff --git a/test/fixtures/golden/factory-ship-SKILL.md b/test/fixtures/golden/factory-ship-SKILL.md index c882d1736..964281625 100644 --- a/test/fixtures/golden/factory-ship-SKILL.md +++ b/test/fixtures/golden/factory-ship-SKILL.md @@ -2347,7 +2347,7 @@ Never overwrite another run's reports. Batch only independent Reads. **1. Load methods before any QA or explicit-verification probe.** -> **STOP.** Before any probe, including plan checks, complete the ordered scope/method Reads below. Templates cannot replace them. +> **STOP.** Before any probe, including plan checks, complete the ordered scope/method Reads below and await them. Templates cannot replace them. From the installed /ship SKILL.md's directory, Read `../gstack-qa/sections/exploratory.md` in full. Use this host's installation, never the product tree. If missing or unreadable, report a QA setup blocker and its affected probes as blocked; continue other safe probes (independent functional/static checks). Missing/unreadable assets block required QA.