CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-09-21 04:10:47 +02:00
Code Issues Packages Projects Releases Wiki Activity

review: check loosened inputs and stale user strings

Browse Source 
Reconstructs the useful review-method additions from PR #2141 and keeps generated output in sync.
This commit is contained in:
t
2026-07-14 11:10:38 -07:00
parent 411b606021
commit 2e3695339e
3 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
review/SKILL.md.tmpl
+1 -1
View File
@@ -125,7 +125,7 @@ available (e.g., slop-scan not installed), skip this step silently.
Apply the CRITICAL categories from the checklist against the diff:
SQL & Data Safety, Race Conditions & Concurrency, LLM Output Trust Boundary, Shell Injection, Enum & Value Completeness.
Also apply the remaining INFORMATIONAL categories that are still in the checklist (Async/Sync Mixing, Column/Field Name Safety, LLM Prompt Issues, Type Coercion, View/Frontend, Time Window Safety, Completeness Gaps, Distribution & CI/CD).
Also apply the remaining INFORMATIONAL categories that are still in the checklist (Async/Sync Mixing, Column/Field Name Safety, LLM Prompt Issues, Type Coercion, View/Frontend, Time Window Safety, Completeness Gaps, Stale User-Facing Strings, Distribution & CI/CD).
**Enum & Value Completeness requires reading code OUTSIDE the diff.** When the diff introduces a new enum value, status, tier, or type constant, use Grep to find all files that reference sibling values, then Read those files to check if the new value is handled. This is the one category where within-diff review is insufficient.