From 34b54d890086a4fe6df412980c322815901c8be3 Mon Sep 17 00:00:00 2001 From: garrytan Date: Sun, 1 Nov 2026 21:57:42 +0000 Subject: [PATCH] fix: pre-landing review fixes (runtime-root header documents the plain skill-start fence, GST-882) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --- scripts/resolvers/runtime-root.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/scripts/resolvers/runtime-root.ts b/scripts/resolvers/runtime-root.ts index ff0044fc7..ad000e3a0 100644 --- a/scripts/resolvers/runtime-root.ts +++ b/scripts/resolvers/runtime-root.ts @@ -3,8 +3,9 @@ * bash finds gstack on Codex and every other `usesEnvVars` host. * * Those hosts run each fenced block in a fresh shell, so `GSTACK_ROOT`, `B`, - * `D` and `P` set by an earlier block are gone. The preamble's root resolution and - * the per-fence prelude come from `runtimeRootPrelude()`; `insertRuntimePreludes()` + * `D` and `P` set by an earlier block are gone. The preamble's skill-start fence + * comes from `skillStartLines()` and the per-fence prelude from + * `runtimeRootPrelude()`; `insertRuntimePreludes()` * is the single post-render pass (gen-skill-docs, before rewriteInstallRoot) * that puts it into every fence that uses these variables without assigning * them. Claude output is returned unchanged. @@ -13,6 +14,9 @@ * on a per-install render, the literal install root (no git call); otherwise the * repo-local install, then the host's global root (`CODEX_HOME` on Codex). No * root prints one line naming what was tried and the setup command, and exits. + * The skill-start fence differs (GST-882): an install-root render calls the + * literal install root's start script and ignores an exported `GSTACK_ROOT`, and + * with no root either render prints that line and lets the call fail. */ import { getHostConfig } from '../../hosts/index'; import { toShellPath, type TemplateContext } from './types';