CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-09-11 23:49:01 +02:00
Code Issues Packages Projects Releases Wiki Activity

feat(design): {{DESIGN_DETECTOR}} wired into design-review, ship review-lite, review army, design-html

Browse Source 
The user-installed impeccable engine becomes a deterministic pre-pass in four
skills, through one resolver with three renders: {{DESIGN_DETECTOR}} (the probe
block and how to read every sentinel), {{DESIGN_DETECTOR:phase0}} (design-
review's mechanical scan), {{DESIGN_DETECTOR:gate}} (design-html's bounded slop
gate). Every rendered invocation is `bun --no-env-file run <bin>/gstack-design-
detect.ts ... --host <host>` and every scan ends with the DETECT_EXIT_CODE echo
so exit 2 (findings) never aborts a block.

design-review: probe in Setup; Phase 0 picks DOM mode (URL target) or source
mode (diff-aware, no URL) once; source mode scans the changed frontend files in
Setup, DOM mode never reads source (Rule 4). Phase 3 gains a DOM-dump step per
page: both browser engines load the shared script from lib/dom-dump.js (Aside
splices it into a double-quoted repl script; the fallback engine copies it into
a temp dir for `$B eval --out --raw`), the dump is size-capped, run through
gstack-redact (a HIGH finding skips the page), and persisted under
$REPORT_DIR/dom/$RUN_ID/; one scan runs after the last page, labeled "static
scan of the rendered DOM; cross-origin CSS not resolved". REPORT_DIR honors
GSTACK_HOME so the wrapper's allow-list and the report dir agree; RUN_ID is set
once in Setup. design-baseline.json is schemaVersion 2 with runId, targetSet,
base, and a detector block (mode, engine, byRule, byPage), written temp+rename
with a per-run copy; Regression Output diffs ids only when mode and target set
match, caveats an engine change, and calls live-page count deltas advisory.
Phase 7 hands deferred detector findings to the `handoff=` command the scan
printed; Phase 9 recomputes the same way and deletes the dumps unless
--keep-dom; Phase 10 reports `Detector: N → M`.

ship review-lite gains step 0 (probe, `scan --changed <base>`, tier buckets,
detector + checklist dedupe, advisory and ignored never count) and a
`detector` count in its log payload; the PR body gets a Detector line (rule
ids and counts only). The Review Army Design specialist runs the mechanical
pass at the top of review/design-checklist.md, which now carries it. design-
html probes after DESIGN_SETUP and runs the one-pass gate before screenshots.

lib/dom-dump.js is generated by gen-skill-docs from lib/dom-dump-script.ts
(Claude host, --out-dir aware, dry-run freshness) and pinned byte-equal, so the
prose never carries the script. The contract gains DETECT_JSON, DOM_DUMP_OK,
and the self-describing set; its test now checks both directions.

Budget: design-review eager 25.6K → 28.5K. The plan's target was +2.5K; after
the levers it named (ids-only detector rules, no inline script, trimmed prose)
it lands at +2.87K, and the remainder is doctrine and detector wiring, so the
ceiling moves to the captured 31,319 for design-review only (the full capture
would also have loosened 21 ceilings this branch never touched; those stay).
design-html skeleton re-baselined to 54,000 (measured 53,592). Codex and
Factory ship goldens refreshed (review-lite step 0 and the PR-body line render
inline there).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-09-08 16:14:03 +00:00
co-authored by Claude Fable 5.1
parent 3867dae355
commit 3522073ef0
25 changed files with 525 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/gen-skill-docs.test.ts
+90 -3
View File
@@ -1843,12 +1843,12 @@ describe('DESIGN_HARD_RULES resolver', () => {
test('design-review renders the catalog once: Methodology category 9 carries it, Hard Rules points at it', () => {
const content = fs.readFileSync(path.join(ROOT, 'design-review', 'SKILL.md'), 'utf-8');
expect(content.split('### Design Hard Rules').length - 1).toBe(1);
// Category 9 lists the rule once; Typography points at the same id from its overused-face item.
expect(content.split('- [overused-font] ').length - 1).toBe(1);
// Category 9 lists the rule once (ids only); Typography points at the same id from its overused-face item.
expect(content.split('[overused-font]').length - 1).toBe(2);
expect(content).toContain('are Methodology category 9');
expect(content).toContain('**9. AI Slop Detection**');
expect(content).toContain('- [nested-cards] ');
expect(content).toContain('Detector rules (ids only;');
expect(content).toContain('[nested-cards] nested cards');
expect(content).toContain('Judgment tells (no detector rule');
// The legacy blacklist is not repeated as a numbered list in design-review.
expect(content).not.toMatch(/^1\. Purple\/violet\/indigo/m);
@@ -1873,6 +1873,93 @@ describe('DESIGN_HARD_RULES resolver', () => {
});
});
// --- {{DESIGN_DETECTOR}} resolver tests ---
describe('DESIGN_DETECTOR resolver', () => {
const designReview = () => fs.readFileSync(path.join(ROOT, 'design-review', 'SKILL.md'), 'utf-8');
const designHtml = () => fs.readFileSync(path.join(ROOT, 'design-html', 'SKILL.md'), 'utf-8');
const bashBlocksOf = (content: string) => [...content.matchAll(/```bash\n([\s\S]*?)```/g)].map(m => m[1]);
test('design-review carries the probe, Phase 0, the DOM dump, and the run id', () => {
const c = designReview();
expect(c).toContain('gstack-design-detect.ts probe --host claude');
expect(c).toContain('IMPECCABLE_READY');
expect(c).toContain('**Phase 0: mechanical scan**');
expect(c).toContain('scan --changed <base> --format gstack --host claude');
expect(c).toContain('### DOM dump (DOM mode only');
expect(c).toContain('data-gstack-dom-css');
expect(c).toContain('$B eval "$_TMP/dom-dump.js" --out "$_TMP/{page}.dom.html" --raw');
expect(c).toContain('DOM_DUMP_OK');
expect(c).toContain('DOM_DUMP_REDACTION_BLOCKED');
expect(c).toContain('DOM_DUMP_TOO_LARGE');
expect(c).toContain('REPORT_DIR="${GSTACK_HOME:-$HOME/.gstack}/projects/$SLUG/designs/design-audit-$(date +%Y%m%d)"');
expect(c).toContain('RUN_ID="$(date +%H%M%S)-$$"');
expect(c).toContain('"schemaVersion": 2');
expect(c).toContain('engine changed X → Y; rule set may differ');
expect(c).toContain('Detector: N → M');
expect(c).toContain('/impeccable typeset');
});
test('the DOM-dump script is loaded from lib/dom-dump.js, never inlined in the prose', () => {
const c = designReview();
expect(c).not.toMatch(/```js\n/);
expect(c).not.toContain('document.documentElement.cloneNode');
expect(c).toContain('_DUMP=$(cat "$HOME/.claude/skills/gstack/lib/dom-dump.js")');
expect(c).toContain('const html = await pg.evaluate($_DUMP);');
expect(c).toContain('cp "$HOME/.claude/skills/gstack/lib/dom-dump.js" "$_TMP/"');
});
test('design-html carries the probe and the bounded slop gate', () => {
const c = designHtml();
expect(c).toContain('gstack-design-detect.ts probe --host claude');
expect(c).toContain('### Slop Gate (bounded, never a loop)');
expect(c).toContain('One pass, not a loop.');
expect(c).toContain('impeccable-disable <rule>: <reason>');
});
test('ship and review unions reach the detector through review-lite and the checklist', () => {
const ship = readSkillUnion('ship');
expect(ship).toContain('**Mechanical pass first.**');
expect(ship).toContain('scan --changed <base> --format gstack --host claude');
expect(ship).toContain('"detector":D');
expect(ship).toContain('Detector: "clean" | "N findings');
const review = readSkillUnion('review');
expect(review).toContain('run the mechanical pass at the top of that checklist');
const checklist = fs.readFileSync(path.join(ROOT, 'review', 'design-checklist.md'), 'utf-8');
expect(checklist).toContain('**0. Mechanical pass first.**');
expect(checklist).toContain('IMPECCABLE_READY');
});
test('every rendered invocation uses bun --no-env-file and ends a scan with the exit echo; no bash block runs npx impeccable', () => {
for (const content of [designReview(), designHtml(), readSkillUnion('ship'), readSkillUnion('review'), fs.readFileSync(path.join(ROOT, 'review', 'design-checklist.md'), 'utf-8')]) {
for (const block of bashBlocksOf(content)) {
expect(block).not.toContain('npx impeccable');
for (const line of block.split('\n')) {
if (!line.includes('gstack-design-detect.ts')) continue;
expect(line).toContain('bun --no-env-file run ');
if (/gstack-design-detect\.ts scan /.test(line)) expect(line).toContain('echo "DETECT_EXIT_CODE=$?"');
}
}
}
});
test('--host is rendered per host', () => {
// Fresh codex render into a temp out-dir: the tracked tree is Claude-only and
// the gitignored .agents/ copy may be stale.
const out = fs.mkdtempSync(path.join(os.tmpdir(), 'gstack-detector-host-'));
try {
const r = Bun.spawnSync(['bun', 'run', 'scripts/gen-skill-docs.ts', '--host', 'codex', '--out-dir', out], { cwd: ROOT, timeout: 120_000 });
expect(r.exitCode).toBe(0);
const codex = fs.readFileSync(path.join(out, '.agents', 'skills', 'gstack-design-review', 'SKILL.md'), 'utf-8');
expect(codex).toContain('gstack-design-detect.ts probe --host codex');
expect(codex).not.toContain('probe --host claude');
expect(codex).toContain('$GSTACK_ROOT/lib/dom-dump.js');
} finally {
fs.rmSync(out, { recursive: true, force: true });
}
});
});
// --- Extended DESIGN_SKETCH resolver tests ---
describe('DESIGN_SKETCH extended with outside voices', () => {