From 385ca732835f7d8d90c07be4176220da1ed8d09e Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Sat, 29 Aug 2026 05:18:34 +0000 Subject: [PATCH] fix(retro): shortcut harvest drops placeholder markers and convention docs The Step 11.5 grep matched documentation mentions (dec-, dec-*) in checklists, resolver sources, and convention tests, reporting phantom debt rows on gstack itself. A trailing filter kills placeholder forms; prose tells the agent to discard convention-quoting hits. Co-Authored-By: Claude Fable 5 --- retro/SKILL.md | 9 +++++++-- retro/SKILL.md.tmpl | 9 +++++++-- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/retro/SKILL.md b/retro/SKILL.md index ce1cfaa8a..90a7c1918 100644 --- a/retro/SKILL.md +++ b/retro/SKILL.md @@ -795,11 +795,16 @@ matches is the healthy case, not a failure: grep -rn "gstack-shortcut(" . \ --exclude-dir=.git --exclude-dir=node_modules --exclude-dir=vendor \ --exclude-dir=.claude --exclude-dir=dist \ - --exclude="SKILL.md" --exclude="*.md.tmpl" 2>/dev/null || true + --exclude="SKILL.md" --exclude="*.md.tmpl" 2>/dev/null \ + | grep -vE "gstack-shortcut\(dec-(<|\*)" || true ``` (The exclusions keep docs that merely document the convention — generated -SKILL.md, templates, skill installs — out of the ledger.) +SKILL.md, templates, skill installs — out of the ledger, and the trailing +filter drops placeholder forms like `dec-` / `dec-*` that documentation +uses. Judgment call on what survives: discard any hit that quotes or tests +the convention itself — a sample marker in a checklist, resolver source, or +convention test — rather than marking a real cut corner in this repo's code.) For each hit, one ledger row: `:, . ceiling: . upgrade: .` - Markers carry a decision id (`dec-`): join against `gstack-decision-search` diff --git a/retro/SKILL.md.tmpl b/retro/SKILL.md.tmpl index 9ce49df58..dceaeac03 100644 --- a/retro/SKILL.md.tmpl +++ b/retro/SKILL.md.tmpl @@ -319,11 +319,16 @@ matches is the healthy case, not a failure: grep -rn "gstack-shortcut(" . \ --exclude-dir=.git --exclude-dir=node_modules --exclude-dir=vendor \ --exclude-dir=.claude --exclude-dir=dist \ - --exclude="SKILL.md" --exclude="*.md.tmpl" 2>/dev/null || true + --exclude="SKILL.md" --exclude="*.md.tmpl" 2>/dev/null \ + | grep -vE "gstack-shortcut\(dec-(<|\*)" || true ``` (The exclusions keep docs that merely document the convention — generated -SKILL.md, templates, skill installs — out of the ledger.) +SKILL.md, templates, skill installs — out of the ledger, and the trailing +filter drops placeholder forms like `dec-` / `dec-*` that documentation +uses. Judgment call on what survives: discard any hit that quotes or tests +the convention itself — a sample marker in a checklist, resolver source, or +convention test — rather than marking a real cut corner in this repo's code.) For each hit, one ledger row: `:, . ceiling: . upgrade: .` - Markers carry a decision id (`dec-`): join against `gstack-decision-search`