From 38bccc33a4400722c12b93d9a90e28ca897d2281 Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Fri, 20 Mar 2026 16:18:34 -0700 Subject: [PATCH] fix: broaden codex-host stripping test to accommodate triage section "Investigate and fix" now appears in TEST_FAILURE_TRIAGE (not just the Codex review step). Use CODEX_REVIEWS config string as a more specific marker for detecting the Codex review step in Codex-hosted skills. --- test/gen-skill-docs.test.ts | 4 ++-- test/skill-validation.test.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/gen-skill-docs.test.ts b/test/gen-skill-docs.test.ts index 64b39118..dd13195d 100644 --- a/test/gen-skill-docs.test.ts +++ b/test/gen-skill-docs.test.ts @@ -587,11 +587,11 @@ describe('Codex generation (--host codex)', () => { test('Codex review step stripped from Codex-host ship and review', () => { const shipContent = fs.readFileSync(path.join(AGENTS_DIR, 'gstack-ship', 'SKILL.md'), 'utf-8'); expect(shipContent).not.toContain('codex review --base'); - expect(shipContent).not.toContain('Investigate and fix'); + expect(shipContent).not.toContain('CODEX_REVIEWS'); const reviewContent = fs.readFileSync(path.join(AGENTS_DIR, 'gstack-review', 'SKILL.md'), 'utf-8'); expect(reviewContent).not.toContain('codex review --base'); - expect(reviewContent).not.toContain('Investigate and fix'); + expect(reviewContent).not.toContain('CODEX_REVIEWS'); }); test('--host codex --dry-run freshness', () => { diff --git a/test/skill-validation.test.ts b/test/skill-validation.test.ts index b49d9b9f..f66c6ac5 100644 --- a/test/skill-validation.test.ts +++ b/test/skill-validation.test.ts @@ -1280,12 +1280,12 @@ describe('Codex skill', () => { test('codex-host ship/review do NOT contain codex review step', () => { const shipContent = fs.readFileSync(path.join(ROOT, '.agents', 'skills', 'gstack-ship', 'SKILL.md'), 'utf-8'); expect(shipContent).not.toContain('codex review --base'); - expect(shipContent).not.toContain('Investigate and fix'); + expect(shipContent).not.toContain('CODEX_REVIEWS'); const reviewContent = fs.readFileSync(path.join(ROOT, '.agents', 'skills', 'gstack-review', 'SKILL.md'), 'utf-8'); expect(reviewContent).not.toContain('codex review --base'); expect(reviewContent).not.toContain('codex_reviews'); - expect(reviewContent).not.toContain('Investigate and fix'); + expect(reviewContent).not.toContain('CODEX_REVIEWS'); }); test('codex integration in /plan-eng-review offers plan critique', () => {