CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-08-23 14:32:33 +02:00
Code Issues Packages Projects Releases Wiki Activity

test: revert GSTACK_HOME injection in the free runner — shared mutable state

Browse Source 
The first full run under the strict runner surfaced 12 failures with one
root cause: injecting a single throwaway GSTACK_HOME per invocation made
6,900 tests share a MUTABLE scratch home. gstack-config tests wrote keys
into it; relink and update-check tests then read them (e.g. relink saw
skill_prefix left behind by a config test and produced prefixed names).
All 12 pass when run directly.

TMPDIR isolation stays (mkdtemp inside it is still per-call unique).
Tests needing GSTACK_HOME isolation mkdtemp their own per test — the
repo convention — and hermetic-env covers E2E children. The env-dump pin
now asserts GSTACK_HOME passes through UNTOUCHED so the injection can't
come back.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-08-15 08:38:06 -07:00
co-authored by Claude Fable 5
parent 0a292dc063
commit 39715addff
2 changed files with 19 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/test-free-shards.ts
+8 -9
View File
@@ -446,12 +446,14 @@ function shardEpilogue(outcome: FreeShardOutcome, totalShards: number): string {
* so tests can pin the summary-missing => failure backstop; fake passing
* commands must print a synthetic `Ran N tests across M files. [Xms]` line.
*
* Per-shard state isolation: each spawned child gets its own throwaway
* GSTACK_HOME and TMPDIR (TEMP/TMP on Windows) so shards — and the bun
* --parallel workers inside the full-suite invocation — can't contend on the
* operator's real ~/.gstack or trip over each other's temp files. Tests that
* mkdtemp their own state dirs are unaffected: this only moves the DEFAULT
* location. The throwaway dirs are removed when the shard finishes.
* Per-shard temp isolation: each spawned child gets its own throwaway TMPDIR
* (TEMP/TMP on Windows) so shards can't trip over each other's temp files.
* Deliberately NOT GSTACK_HOME: injecting one shared scratch home for a whole
* invocation made 6,900 tests share a MUTABLE state dir — config tests wrote
* keys into it and relink/update-check tests then read them (measured: 12
* cross-contamination failures on the first full run). Tests that need
* GSTACK_HOME isolation mkdtemp their own per test — the repo convention —
* and the hermetic-env machinery covers E2E children.
*/
export async function runFreeShard(
files: string[],
@@ -482,11 +484,8 @@ export async function runFreeShard(
const env = { ...(options.env ?? process.env) };
const stateDir = fs.mkdtempSync(path.join(os.tmpdir(), 'gstack-free-shard-'));
const gstackHome = path.join(stateDir, 'gstack-home');
const childTmp = path.join(stateDir, 'tmp');
fs.mkdirSync(gstackHome);
fs.mkdirSync(childTmp);
env.GSTACK_HOME = gstackHome;
env.TMPDIR = childTmp;
env.TEMP = childTmp;
env.TMP = childTmp;