diff --git a/CHANGELOG.md b/CHANGELOG.md index c91bd583f..f73fedaa3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -33,6 +33,7 @@ This release closes the follow-ups filed by the v1.91.15.0 prompt cleanup. The c - /review's specialist header counted advisory findings in its total; the header's N is now defined as critical plus informational. - Free-lane shards failed with "browser ownership deadline exceeded" when a browse daemon took more than 5 seconds to exit after SIGINT. Reaching the force-kill point now ends the graceful phase instead of recording a cleanup failure; a probe cut off at that point still fails the shard. - `bun run audit:manifest` printed backslash paths on Windows. +- /review and /ship's design-review scope check sourced `gstack-diff-scope` without printing `SCOPE_FRONTEND`, so the agent could not see the value and reran the helper by hand. The block now prints it. - Exploratory QA could publish its evidence before listing captures taken before an input change, which left the verdict inconclusive (materialize runs once). The probe loop now says to annotate every capture and mark older-snapshot ones `superseded`. #### For contributors diff --git a/scripts/resolvers/design.ts b/scripts/resolvers/design.ts index 0f74c918c..1731a6f07 100644 --- a/scripts/resolvers/design.ts +++ b/scripts/resolvers/design.ts @@ -33,6 +33,7 @@ Check if the diff touches frontend files using \`gstack-diff-scope\`: \`\`\`bash source <(${ctx.paths.binDir}/gstack-diff-scope 2>/dev/null) +echo "SCOPE_FRONTEND=$SCOPE_FRONTEND" \`\`\` **If \`SCOPE_FRONTEND=false\`:** Skip design review silently. No output. diff --git a/ship/sections/review-army.md b/ship/sections/review-army.md index ee852eda0..6b2cc761f 100644 --- a/ship/sections/review-army.md +++ b/ship/sections/review-army.md @@ -94,6 +94,7 @@ Check if the diff touches frontend files using `gstack-diff-scope`: ```bash source <(~/.claude/skills/gstack/bin/gstack-diff-scope 2>/dev/null) +echo "SCOPE_FRONTEND=$SCOPE_FRONTEND" ``` **If `SCOPE_FRONTEND=false`:** Skip design review silently. No output. diff --git a/test/fixtures/golden/codex-ship-SKILL.md b/test/fixtures/golden/codex-ship-SKILL.md index 42660f382..290648a7d 100644 --- a/test/fixtures/golden/codex-ship-SKILL.md +++ b/test/fixtures/golden/codex-ship-SKILL.md @@ -1885,6 +1885,7 @@ Check if the diff touches frontend files using `gstack-diff-scope`: ```bash source <($GSTACK_BIN/gstack-diff-scope 2>/dev/null) +echo "SCOPE_FRONTEND=$SCOPE_FRONTEND" ``` **If `SCOPE_FRONTEND=false`:** Skip design review silently. No output. diff --git a/test/fixtures/golden/factory-ship-SKILL.md b/test/fixtures/golden/factory-ship-SKILL.md index 54341009f..7fd8e5a03 100644 --- a/test/fixtures/golden/factory-ship-SKILL.md +++ b/test/fixtures/golden/factory-ship-SKILL.md @@ -1893,6 +1893,7 @@ Check if the diff touches frontend files using `gstack-diff-scope`: ```bash source <($GSTACK_BIN/gstack-diff-scope 2>/dev/null) +echo "SCOPE_FRONTEND=$SCOPE_FRONTEND" ``` **If `SCOPE_FRONTEND=false`:** Skip design review silently. No output.