CalvinBackup/gstack
1
0
Fork 0
mirror of https://github.com/garrytan/gstack.git synced 2026-09-15 09:25:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(pty-runner): active-render gate veto in the floor check + honest periodic-wiring docs

Browse Source 
Codex re-review P2s on the fix wave, both verified:

- A finding AUQ rendering within TAIL_SCAN_BYTES of the gate (model waiting,
  no further output) was vetoed by the blanket tail exclusion until timeout.
  The veto is now ACTIVE-RENDER-aware: parseNumberedOptions anchors the last
  cursor menu, so only a pending GATE menu vetoes; the judge fallback shares
  the same check. Residual (documented): prose gate + prose finding inside
  one tail — floors run the native-menu path in practice.
- The four demoted periodic tests are not in evals-periodic.yml's explicit
  matrix (a named instance of the pre-existing periodic-orphans TODO), so
  they run locally/manually until the PTY-capable periodic job lands.
  CHANGELOG claim softened accordingly; TODO filed with the wiring recipe.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Garry Tan
2026-08-12 09:19:00 -07:00
co-authored by Claude Fable 5
parent bd8c1f64b3
commit 3d2dd4a33f
4 changed files with 59 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
TODOS.md
+17
View File
@@ -233,6 +233,23 @@ SKILL.md untouched). `bun test` is green again.
## Scope-gate follow-ups (filed via /plan-eng-review on the plan-mode auto-select-B change)
### P2: Wire the four demoted plan-mode/finding-floor PTY tests into periodic CI
**What:** `evals-periodic.yml` runs an explicit 9-file matrix; the four tests
demoted to `periodic` in v1.62.0.0 (`skill-e2e-plan-eng-plan-mode`,
`skill-e2e-plan-design-plan-mode`, `skill-e2e-plan-eng-finding-floor`,
`skill-e2e-plan-design-finding-floor`) are not in it, so they currently run
only locally/manually (`bun run test:periodic` or `eval:bg:periodic`). Wiring
them needs a PTY-capable periodic job: the container skill-registration setup
from evals.yml's `e2e-pty-plan-smoke` job (real-file SKILL.md copies for the
TUI's cross-mount symlink bug) with `EVALS_TIER=periodic`.
**Why:** Codex re-review P2 on the v1.62.0.0 ship. This is a named instance of
the existing periodic-orphans problem (see "P1/P2 periodic coverage" TODO in
Test infrastructure) — solve it there or here, once.
**Depends on / blocked by:** none; sibling of the periodic-orphans TODO above.
### P3: Extract the whole scope gate to a shared `{{SCOPE_GATE}}` resolver
**What:** Move the duplicated scope-gate prose (heading, intro sentence, the